github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 11:42:54 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #1150] [MERGED] ♻️ (crdt) moved re-used utils in actual-server to separate package #3555

New Issue
Closed
opened 2026-02-28 20:43:21 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:43:21 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/1150
Author: @MatissJanis
Created: 6/18/2023
Status: ✅ Merged
Merged: 6/18/2023
Merged by: @MatissJanis

Base: master ← Head: matiss/crdt

📝 Commits (7)

📊 Changes

36 files changed (+162 additions, -86 deletions)

View changed files

📝 .github/workflows/build.yml (+16 -0)
📝 .gitignore (+1 -0)
➕ packages/crdt/.eslintignore (+1 -0)
➕ packages/crdt/index.ts (+1 -0)
➕ packages/crdt/jest.config.js (+4 -0)
➕ packages/crdt/package.json (+28 -0)
📝 packages/crdt/src/crdt/__snapshots__/merkle.test.ts.snap (+0 -0)
📝 packages/crdt/src/crdt/index.ts (+0 -0)
📝 packages/crdt/src/crdt/merkle.test.ts (+0 -0)
📝 packages/crdt/src/crdt/merkle.ts (+0 -0)
📝 packages/crdt/src/crdt/timestamp.test.ts (+0 -0)
📝 packages/crdt/src/crdt/timestamp.ts (+2 -3)
➕ packages/crdt/src/main.ts (+13 -0)
📝 packages/crdt/src/proto/sync_pb.d.ts (+0 -0)
📝 packages/crdt/src/proto/sync_pb.js (+0 -0)
➕ packages/crdt/tsconfig.dist.json (+14 -0)
📝 packages/loot-core/package.json (+1 -2)
📝 packages/loot-core/src/mocks/setup.ts (+5 -3)
➖ packages/loot-core/src/platform/uuid/index.testing.ts (+0 -9)
📝 packages/loot-core/src/server/api.ts (+2 -1)

...and 16 more files

📄 Description

actual-server does not need to import the full actual-app/api package. It can import only the CRDT stuff.. so I'm extracting it into a new package to reduce the size of actual-server and make the link between things more transparent.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/1150 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 6/18/2023 **Status:** ✅ Merged **Merged:** 6/18/2023 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `matiss/crdt` --- ### 📝 Commits (7) - [`9904a87`](https://github.com/actualbudget/actual/commit/9904a8779a6a8c42457a629cc26f27b45cd31b91) :recycle: (crdt) moved re-used utils in actual-server to separate package - [`ffab14d`](https://github.com/actualbudget/actual/commit/ffab14d403e2428aeaacf8857bcdc674334fa57a) Gitignore - [`110a096`](https://github.com/actualbudget/actual/commit/110a096c1beca37f921303662b18bfaa7991f430) Release notes - [`80e6271`](https://github.com/actualbudget/actual/commit/80e62717499e1a63979d837a158601d145e477a1) Add tests - [`9dd23a8`](https://github.com/actualbudget/actual/commit/9dd23a8e5ac96938386c0ac27c4b57e5e038c8ff) Further backwards compatibility fix - [`606340e`](https://github.com/actualbudget/actual/commit/606340ead81f1865271537240bec7296ea3a197c) Gitlab job for CRDT pkg - [`0bbb095`](https://github.com/actualbudget/actual/commit/0bbb095337a0517242613df36d380f1dc77f6902) fix: unit tests ### 📊 Changes **36 files changed** (+162 additions, -86 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/build.yml` (+16 -0) 📝 `.gitignore` (+1 -0) ➕ `packages/crdt/.eslintignore` (+1 -0) ➕ `packages/crdt/index.ts` (+1 -0) ➕ `packages/crdt/jest.config.js` (+4 -0) ➕ `packages/crdt/package.json` (+28 -0) 📝 `packages/crdt/src/crdt/__snapshots__/merkle.test.ts.snap` (+0 -0) 📝 `packages/crdt/src/crdt/index.ts` (+0 -0) 📝 `packages/crdt/src/crdt/merkle.test.ts` (+0 -0) 📝 `packages/crdt/src/crdt/merkle.ts` (+0 -0) 📝 `packages/crdt/src/crdt/timestamp.test.ts` (+0 -0) 📝 `packages/crdt/src/crdt/timestamp.ts` (+2 -3) ➕ `packages/crdt/src/main.ts` (+13 -0) 📝 `packages/crdt/src/proto/sync_pb.d.ts` (+0 -0) 📝 `packages/crdt/src/proto/sync_pb.js` (+0 -0) ➕ `packages/crdt/tsconfig.dist.json` (+14 -0) 📝 `packages/loot-core/package.json` (+1 -2) 📝 `packages/loot-core/src/mocks/setup.ts` (+5 -3) ➖ `packages/loot-core/src/platform/uuid/index.testing.ts` (+0 -9) 📝 `packages/loot-core/src/server/api.ts` (+2 -1) _...and 16 more files_ </details> ### 📄 Description actual-server does not need to import the full actual-app/api package. It can import only the CRDT stuff.. so I'm extracting it into a new package to reduce the size of actual-server and make the link between things more transparent. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:43:21 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#3555
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?