[PR #4141] [MERGED] Add sorting option to custom reports #35402

Closed
opened 2026-04-20 22:23:59 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/4141
Author: @matt-fidd
Created: 1/12/2025
Status: Merged
Merged: 1/13/2025
Merged by: @matt-fidd

Base: masterHead: custom-report-sorting


📝 Commits (10+)

📊 Changes

30 files changed (+180 additions, -21 deletions)

View changed files

📝 packages/desktop-client/e2e/reports.test.js-snapshots/Reports-custom-reports-Switches-to-Data-Table-and-checks-the-visuals-1-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/reports.test.js-snapshots/Reports-custom-reports-Switches-to-Data-Table-and-checks-the-visuals-2-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/reports.test.js-snapshots/Reports-custom-reports-Switches-to-Data-Table-and-checks-the-visuals-3-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/reports.test.js-snapshots/Reports-custom-reports-Switches-to-Donut-Graph-and-checks-the-visuals-1-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/reports.test.js-snapshots/Reports-custom-reports-Switches-to-Donut-Graph-and-checks-the-visuals-2-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/reports.test.js-snapshots/Reports-custom-reports-Switches-to-Donut-Graph-and-checks-the-visuals-3-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/reports.test.js-snapshots/Reports-custom-reports-Validates-that-show-labels-button-shows-the-labels-1-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/reports.test.js-snapshots/Reports-custom-reports-Validates-that-show-labels-button-shows-the-labels-2-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/reports.test.js-snapshots/Reports-custom-reports-Validates-that-show-labels-button-shows-the-labels-3-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/reports.test.js-snapshots/Reports-custom-reports-Validates-that-show-legend-button-shows-the-legend-side-bar-1-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/reports.test.js-snapshots/Reports-custom-reports-Validates-that-show-legend-button-shows-the-legend-side-bar-2-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/reports.test.js-snapshots/Reports-custom-reports-Validates-that-show-legend-button-shows-the-legend-side-bar-3-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/reports.test.js-snapshots/Reports-custom-reports-Validates-that-show-summary-button-shows-the-summary-1-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/reports.test.js-snapshots/Reports-custom-reports-Validates-that-show-summary-button-shows-the-summary-2-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/reports.test.js-snapshots/Reports-custom-reports-Validates-that-show-summary-button-shows-the-summary-3-chromium-linux.png (+0 -0)
📝 packages/desktop-client/src/components/reports/ReportOptions.ts (+12 -0)
📝 packages/desktop-client/src/components/reports/ReportSidebar.tsx (+41 -0)
📝 packages/desktop-client/src/components/reports/disabledList.ts (+14 -1)
📝 packages/desktop-client/src/components/reports/graphs/BarGraph.tsx (+2 -8)
📝 packages/desktop-client/src/components/reports/graphs/DonutGraph.tsx (+2 -6)

...and 10 more files

📄 Description

{\color{red}\text{This PR contains a migration, don't connect it to a server you'd like to continue using}}

Adds support for sorting data in barcharts, pie charts and data tables
Disabled on time mode graphs and total mode graphs split by interval

Sort modes:

  • Ascending
  • Descending
  • Name (alphabetical)
  • Budget order

Sort is reversed to make ascending/descending more natural on all negative values


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/4141 **Author:** [@matt-fidd](https://github.com/matt-fidd) **Created:** 1/12/2025 **Status:** ✅ Merged **Merged:** 1/13/2025 **Merged by:** [@matt-fidd](https://github.com/matt-fidd) **Base:** `master` ← **Head:** `custom-report-sorting` --- ### 📝 Commits (10+) - [`bc9e454`](https://github.com/actualbudget/actual/commit/bc9e454444170a919216df7d3da7be5af674f3f4) support sorting data in custom reports - [`01e8ce4`](https://github.com/actualbudget/actual/commit/01e8ce4bb0afe9011627ab7bfd6110fa121ed12c) disable on unsupported report types - [`e0476e1`](https://github.com/actualbudget/actual/commit/e0476e1fbeadb0616461f0314555bc39cd6426f9) db migration - [`55ed701`](https://github.com/actualbudget/actual/commit/55ed7018f3665754dcbb411637f9dce68f11a409) note - [`410b545`](https://github.com/actualbudget/actual/commit/410b54506360a701395b66ffea5f3ab1101acb66) typecheck - [`ef8bfdf`](https://github.com/actualbudget/actual/commit/ef8bfdfbd777ad6d163414e00e93e8a9230ca1f2) split out sorting function and support complete sorting of nested data - [`23bf09f`](https://github.com/actualbudget/actual/commit/23bf09f7836bce133c15559f6e1041531c9d5422) Merge branch 'master' into custom-report-sorting - [`c0b31e1`](https://github.com/actualbudget/actual/commit/c0b31e1444a444d1e4aa76b20246a483167d2666) Update VRT - [`b08e1a5`](https://github.com/actualbudget/actual/commit/b08e1a573438bc42d21aefcb9f7fcb593b12ba89) fix defaults - [`3b41d56`](https://github.com/actualbudget/actual/commit/3b41d5623c80cbc3f57c5dc5ddbf7299c3d2e64c) Update VRT ### 📊 Changes **30 files changed** (+180 additions, -21 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/e2e/reports.test.js-snapshots/Reports-custom-reports-Switches-to-Data-Table-and-checks-the-visuals-1-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/reports.test.js-snapshots/Reports-custom-reports-Switches-to-Data-Table-and-checks-the-visuals-2-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/reports.test.js-snapshots/Reports-custom-reports-Switches-to-Data-Table-and-checks-the-visuals-3-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/reports.test.js-snapshots/Reports-custom-reports-Switches-to-Donut-Graph-and-checks-the-visuals-1-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/reports.test.js-snapshots/Reports-custom-reports-Switches-to-Donut-Graph-and-checks-the-visuals-2-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/reports.test.js-snapshots/Reports-custom-reports-Switches-to-Donut-Graph-and-checks-the-visuals-3-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/reports.test.js-snapshots/Reports-custom-reports-Validates-that-show-labels-button-shows-the-labels-1-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/reports.test.js-snapshots/Reports-custom-reports-Validates-that-show-labels-button-shows-the-labels-2-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/reports.test.js-snapshots/Reports-custom-reports-Validates-that-show-labels-button-shows-the-labels-3-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/reports.test.js-snapshots/Reports-custom-reports-Validates-that-show-legend-button-shows-the-legend-side-bar-1-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/reports.test.js-snapshots/Reports-custom-reports-Validates-that-show-legend-button-shows-the-legend-side-bar-2-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/reports.test.js-snapshots/Reports-custom-reports-Validates-that-show-legend-button-shows-the-legend-side-bar-3-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/reports.test.js-snapshots/Reports-custom-reports-Validates-that-show-summary-button-shows-the-summary-1-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/reports.test.js-snapshots/Reports-custom-reports-Validates-that-show-summary-button-shows-the-summary-2-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/reports.test.js-snapshots/Reports-custom-reports-Validates-that-show-summary-button-shows-the-summary-3-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/src/components/reports/ReportOptions.ts` (+12 -0) 📝 `packages/desktop-client/src/components/reports/ReportSidebar.tsx` (+41 -0) 📝 `packages/desktop-client/src/components/reports/disabledList.ts` (+14 -1) 📝 `packages/desktop-client/src/components/reports/graphs/BarGraph.tsx` (+2 -8) 📝 `packages/desktop-client/src/components/reports/graphs/DonutGraph.tsx` (+2 -6) _...and 10 more files_ </details> ### 📄 Description $${\color{red}\text{This PR contains a migration, don't connect it to a server you'd like to continue using}}$$ Adds support for sorting data in barcharts, pie charts and data tables Disabled on time mode graphs and total mode graphs split by interval Sort modes: - Ascending - Descending - Name (alphabetical) - Budget order Sort is reversed to make ascending/descending more natural on all negative values --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 22:23:59 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#35402