github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 11:42:54 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #1126] [CLOSED] [WIP] Adding new linter rule 'import/no-unused-modules' & amending code as needed to resolve issues #3534

New Issue
Closed
opened 2026-02-28 20:43:02 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:43:02 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/1126
Author: @Shazib
Created: 6/12/2023
Status: ❌ Closed

Base: master ← Head: master

📝 Commits (10+)

  • 2df202d Add lint rule to check for unused modules
  • a67b69f Enable eslint import on typescript
  • 8f7e02a Exclude loot-core from the new importer rule because too many errors
  • de96384 Fix exports on mobile pages
  • 1a7a985 Delete files not exported anywhere
  • 2f1347a Delete unused functions
  • b227e6e Tidy up & Remove exports that aren't needed
  • 96a6313 More export tidy up
  • 024bb37 Add ignore rules for some files
  • 3090347 yarn update

📊 Changes

58 files changed (+344 additions, -1246 deletions)

View changed files

📝 .eslintrc.js (+15 -0)
📝 package.json (+1 -0)
📝 packages/desktop-client/src/components/FixedSizeList.js (+1 -1)
📝 packages/desktop-client/src/components/KeyHandlers.tsx (+1 -1)
📝 packages/desktop-client/src/components/ManageRules.js (+2 -9)
📝 packages/desktop-client/src/components/NotesButton.tsx (+1 -1)
➖ packages/desktop-client/src/components/SyncNotifications.js (+0 -65)
📝 packages/desktop-client/src/components/Titlebar.js (+1 -1)
📝 packages/desktop-client/src/components/accounts/MobileAccount.js (+1 -1)
📝 packages/desktop-client/src/components/accounts/MobileAccounts.js (+3 -3)
📝 packages/desktop-client/src/components/accounts/MobileTransaction.js (+4 -21)
📝 packages/desktop-client/src/components/accounts/TransactionsTable.js (+3 -3)
📝 packages/desktop-client/src/components/alerts.tsx (+1 -1)
📝 packages/desktop-client/src/components/autocomplete/AccountAutocomplete.js (+1 -6)
📝 packages/desktop-client/src/components/autocomplete/Autocomplete.tsx (+2 -2)
📝 packages/desktop-client/src/components/autocomplete/CategorySelect.tsx (+1 -1)
📝 packages/desktop-client/src/components/autocomplete/PayeeAutocomplete.js (+1 -1)
📝 packages/desktop-client/src/components/budget/BudgetMonthCountContext.js (+1 -1)
📝 packages/desktop-client/src/components/budget/MobileBudgetTable.js (+8 -8)
📝 packages/desktop-client/src/components/budget/misc.js (+3 -3)

...and 38 more files

📄 Description

  • I think import doesn't work by default with typescript so i had to add an extra package for typescript support
  • I've disabled checking on the /icons subfolder because it warns about every unused icon
  • I've temporarily disabled it on loot-core because it was returning a lot of false positives. (help?)
  • I have not compared benchmarked performance but it doesn't feel too slow.

Code Changes:

  • Changes to mobile pages were a separate commit as i know this is still WIP so we can undo these
  • Ignored the plaid file as i know this is also still wip.
  • Hopefully the rest all makes sense.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/1126 **Author:** [@Shazib](https://github.com/Shazib) **Created:** 6/12/2023 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (10+) - [`2df202d`](https://github.com/actualbudget/actual/commit/2df202d458c30ec71bdd89bd337fe9b90ec3b535) Add lint rule to check for unused modules - [`a67b69f`](https://github.com/actualbudget/actual/commit/a67b69f539469fcb2b7e0895b73a702f714d43f5) Enable eslint import on typescript - [`8f7e02a`](https://github.com/actualbudget/actual/commit/8f7e02ad39cd1a998a55fe8873b07469cd6b7763) Exclude loot-core from the new importer rule because too many errors - [`de96384`](https://github.com/actualbudget/actual/commit/de9638436521aa054cdea78e09a32ea4b9bb9782) Fix exports on mobile pages - [`1a7a985`](https://github.com/actualbudget/actual/commit/1a7a9859e4f16f9ea86156ea43feaf793c23a783) Delete files not exported anywhere - [`2f1347a`](https://github.com/actualbudget/actual/commit/2f1347aa26ce317a0f55aaafc598f384b62222db) Delete unused functions - [`b227e6e`](https://github.com/actualbudget/actual/commit/b227e6efd17607aba9057b91abba15de41551318) Tidy up & Remove exports that aren't needed - [`96a6313`](https://github.com/actualbudget/actual/commit/96a6313df998fa1c8f614ca49bfbb25d3aec19af) More export tidy up - [`024bb37`](https://github.com/actualbudget/actual/commit/024bb37949dc644c64fefc88e569328d3a04f3f6) Add ignore rules for some files - [`3090347`](https://github.com/actualbudget/actual/commit/3090347db3e20e2ef50dd1d194cb5477cea0e344) yarn update ### 📊 Changes **58 files changed** (+344 additions, -1246 deletions) <details> <summary>View changed files</summary> 📝 `.eslintrc.js` (+15 -0) 📝 `package.json` (+1 -0) 📝 `packages/desktop-client/src/components/FixedSizeList.js` (+1 -1) 📝 `packages/desktop-client/src/components/KeyHandlers.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/ManageRules.js` (+2 -9) 📝 `packages/desktop-client/src/components/NotesButton.tsx` (+1 -1) ➖ `packages/desktop-client/src/components/SyncNotifications.js` (+0 -65) 📝 `packages/desktop-client/src/components/Titlebar.js` (+1 -1) 📝 `packages/desktop-client/src/components/accounts/MobileAccount.js` (+1 -1) 📝 `packages/desktop-client/src/components/accounts/MobileAccounts.js` (+3 -3) 📝 `packages/desktop-client/src/components/accounts/MobileTransaction.js` (+4 -21) 📝 `packages/desktop-client/src/components/accounts/TransactionsTable.js` (+3 -3) 📝 `packages/desktop-client/src/components/alerts.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/autocomplete/AccountAutocomplete.js` (+1 -6) 📝 `packages/desktop-client/src/components/autocomplete/Autocomplete.tsx` (+2 -2) 📝 `packages/desktop-client/src/components/autocomplete/CategorySelect.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/autocomplete/PayeeAutocomplete.js` (+1 -1) 📝 `packages/desktop-client/src/components/budget/BudgetMonthCountContext.js` (+1 -1) 📝 `packages/desktop-client/src/components/budget/MobileBudgetTable.js` (+8 -8) 📝 `packages/desktop-client/src/components/budget/misc.js` (+3 -3) _...and 38 more files_ </details> ### 📄 Description - I think import doesn't work by default with typescript so i had to add an extra package for typescript support - I've disabled checking on the `/icons` subfolder because it warns about every unused icon - I've temporarily disabled it on `loot-core` because it was returning a lot of false positives. (help?) - I have not compared benchmarked performance but it doesn't feel too slow. Code Changes: - Changes to mobile pages were a separate commit as i know this is still WIP so we can undo these - Ignored the plaid file as i know this is also still wip. - Hopefully the rest all makes sense. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:43:02 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#3534
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?