github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-08 21:12:08 -05:00
Code Issues 1.6k Packages Projects Releases 55 Wiki Activity

[PR #3984] [CLOSED] Convert SelectLinkedAccountsModal to TypeScript #35334

New Issue
Closed
opened 2026-04-20 22:19:18 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-20 22:19:18 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/3984
Author: @dkhalife
Created: 12/14/2024
Status: ❌ Closed

Base: master ← Head: dkhalife/ts/select-linked-accounts

📝 Commits (10+)

  • d3de35f initial attempt
  • 1c51a5c release notes
  • 2bf3b70 type fixes
  • 126c4bd hardening
  • 7bb4289 Merge branch 'actualbudget:master' into dkhalife/ts/select-linked-accounts
  • 2a270c8 address bot comments
  • c1d7672 Merge branch 'master' into dkhalife/ts/select-linked-accounts
  • 3a893fe Merge branch 'master' into dkhalife/ts/select-linked-accounts
  • 71c6d07 Merge branch 'master' into dkhalife/ts/select-linked-accounts
  • a8446f2 empty commit to see if mergefreeze resets

📊 Changes

3 files changed (+109 additions, -48 deletions)

View changed files

📝 packages/desktop-client/src/components/modals/CreateAccountModal.tsx (+11 -11)
📝 packages/desktop-client/src/components/modals/SelectLinkedAccountsModal.tsx (+92 -37)
➕ upcoming-release-notes/3984.md (+6 -0)

📄 Description

Major changes:

  • Extracted the NormalizedAccount type and renamed its account_id field into id so it can be reused as the key for table rows
  • Added the necessary props for the modal component and propagated the types where they could not be inferred
  • Changed the TableHeader portion to JSX

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/3984 **Author:** [@dkhalife](https://github.com/dkhalife) **Created:** 12/14/2024 **Status:** ❌ Closed **Base:** `master` ← **Head:** `dkhalife/ts/select-linked-accounts` --- ### 📝 Commits (10+) - [`d3de35f`](https://github.com/actualbudget/actual/commit/d3de35f536c99cc8f9c78e9b35df91a3fd04056b) initial attempt - [`1c51a5c`](https://github.com/actualbudget/actual/commit/1c51a5c69391f2d9a57d6a1e17dcedc346f4d636) release notes - [`2bf3b70`](https://github.com/actualbudget/actual/commit/2bf3b70699042fc7ae7d5d330fa888cbe01f888b) type fixes - [`126c4bd`](https://github.com/actualbudget/actual/commit/126c4bdb9efa5940ada15f110cb00d07a5055260) hardening - [`7bb4289`](https://github.com/actualbudget/actual/commit/7bb4289a1e4272849ee44245fe6823ad35a47524) Merge branch 'actualbudget:master' into dkhalife/ts/select-linked-accounts - [`2a270c8`](https://github.com/actualbudget/actual/commit/2a270c8f50e75bee4ee914b676af629392ab650e) address bot comments - [`c1d7672`](https://github.com/actualbudget/actual/commit/c1d7672a8ab92ef9d28054ff381b9cab262a0852) Merge branch 'master' into dkhalife/ts/select-linked-accounts - [`3a893fe`](https://github.com/actualbudget/actual/commit/3a893fe1b6a9b0d04d5e9a7c63f36afd2187b3f3) Merge branch 'master' into dkhalife/ts/select-linked-accounts - [`71c6d07`](https://github.com/actualbudget/actual/commit/71c6d07c64eda420db66e58e5c55d13449b4fb3e) Merge branch 'master' into dkhalife/ts/select-linked-accounts - [`a8446f2`](https://github.com/actualbudget/actual/commit/a8446f28c6474ce119bf9753bbdf0f2a47100328) empty commit to see if mergefreeze resets ### 📊 Changes **3 files changed** (+109 additions, -48 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/modals/CreateAccountModal.tsx` (+11 -11) 📝 `packages/desktop-client/src/components/modals/SelectLinkedAccountsModal.tsx` (+92 -37) ➕ `upcoming-release-notes/3984.md` (+6 -0) </details> ### 📄 Description Major changes: - Extracted the `NormalizedAccount` type and renamed its `account_id` field into `id` so it can be reused as the key for table rows - Added the necessary props for the modal component and propagated the types where they could not be inferred - Changed the TableHeader portion to JSX --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 22:19:18 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#35334
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?