github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 20:15:33 -05:00
Code Issues 1.5k Packages Projects Releases 55 Wiki Activity

[PR #3815] [MERGED] fix: don't clobber server pathname #35266

New Issue
Closed
opened 2026-04-20 22:15:33 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-20 22:15:33 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/3815
Author: @joshyrobot
Created: 11/10/2024
Status: ✅ Merged
Merged: 11/12/2024
Merged by: @matt-fidd

Base: master ← Head: master

📝 Commits (3)

  • 8b117f6 fix: don't clobber server pathname
  • 42fdbcc add release notes
  • 19a87da use fs.join to avoid double slashes

📊 Changes

2 files changed (+7 additions, -1 deletions)

View changed files

📝 packages/loot-core/src/server/server-config.ts (+1 -1)
➕ upcoming-release-notes/3815.md (+6 -0)

📄 Description

The provided server URL may already include a pathname, so all further segments need to be appended. This also more closely matches the name joinURL. Currently if https://example.com/actual is passed in to getServer, it will return URLs derived from https://example.com only.

While this doesn't implement #672, it would allow for any existing Actual client to access a server that's proxied behind a pathname.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/3815 **Author:** [@joshyrobot](https://github.com/joshyrobot) **Created:** 11/10/2024 **Status:** ✅ Merged **Merged:** 11/12/2024 **Merged by:** [@matt-fidd](https://github.com/matt-fidd) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (3) - [`8b117f6`](https://github.com/actualbudget/actual/commit/8b117f6b079b553112156c1628874b31b522a4d8) fix: don't clobber server pathname - [`42fdbcc`](https://github.com/actualbudget/actual/commit/42fdbcca5a96842f798de6d9ce5e6fa6500d37a8) add release notes - [`19a87da`](https://github.com/actualbudget/actual/commit/19a87da22e48b4a4a6b7dd155cce1a0f52222d4a) use `fs.join` to avoid double slashes ### 📊 Changes **2 files changed** (+7 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/loot-core/src/server/server-config.ts` (+1 -1) ➕ `upcoming-release-notes/3815.md` (+6 -0) </details> ### 📄 Description The provided server URL may already include a pathname, so all further segments need to be appended. This also more closely matches the name `joinURL`. Currently if `https://example.com/actual` is passed in to `getServer`, it will return URLs derived from `https://example.com` only. While this doesn't implement #672, it would allow for any existing Actual client to access a server that's proxied behind a pathname. <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 22:15:33 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#35266
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?