github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 03:32:54 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #1114] [MERGED] Stop mixing platform-specific code #3526

New Issue
Closed
opened 2026-02-28 20:42:55 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:42:55 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/1114
Author: @j-f1
Created: 6/8/2023
Status: ✅ Merged
Merged: 6/9/2023
Merged by: @j-f1

Base: master ← Head: jed/fs-cleanup

📝 Commits (6)

  • ce718a5 Extract shared fs code into shared.ts, simplify getDataDir on web
  • 01fa0e3 Ban direct imports of platform-specific modules
  • 82fdb96 Add import/extensions so we avoid unnecessary extensions
  • 4da7fbb Add release note
  • 72e627c Fix lint errors when file doesn’t exist
  • e852093 Fix path error

📊 Changes

21 files changed (+77 additions, -46 deletions)

View changed files

📝 .eslintrc.js (+16 -0)
📝 packages/api/index.js (+2 -1)
📝 packages/desktop-client/src/components/budget/misc.js (+1 -1)
📝 packages/desktop-client/src/components/sidebar.js (+1 -1)
📝 packages/desktop-client/src/components/spreadsheet/SheetValue.tsx (+1 -1)
📝 packages/desktop-client/src/components/spreadsheet/useSheetValue.js (+1 -1)
📝 packages/desktop-electron/index.js (+1 -0)
📝 packages/desktop-electron/server.js (+1 -0)
📝 packages/desktop-electron/window-state.js (+1 -0)
📝 packages/loot-core/init-node.js (+2 -1)
📝 packages/loot-core/src/platform/client/fetch/index.testing.ts (+1 -0)
📝 packages/loot-core/src/platform/server/fs/index.electron.ts (+1 -31)
📝 packages/loot-core/src/platform/server/fs/index.web.ts (+2 -6)
➕ packages/loot-core/src/platform/server/fs/path-join.electron.ts (+3 -0)
➕ packages/loot-core/src/platform/server/fs/shared.ts (+32 -0)
📝 packages/loot-core/src/platform/server/sqlite/index.web.test.ts (+2 -0)
📝 packages/loot-core/src/server/migrate/migrations.ts (+1 -1)
📝 packages/loot-core/src/types/api-handlers.d.ts (+0 -0)
📝 packages/loot-core/src/types/handlers.d.ts (+2 -2)
📝 packages/loot-core/src/types/main-handlers.d.ts (+0 -0)

...and 1 more files

📄 Description

Bundle sizes are unchanged but now we no longer pull in the Electron-specific FS code on the web version

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/1114 **Author:** [@j-f1](https://github.com/j-f1) **Created:** 6/8/2023 **Status:** ✅ Merged **Merged:** 6/9/2023 **Merged by:** [@j-f1](https://github.com/j-f1) **Base:** `master` ← **Head:** `jed/fs-cleanup` --- ### 📝 Commits (6) - [`ce718a5`](https://github.com/actualbudget/actual/commit/ce718a5c3ad5e26f2771ba6e3911e9a342b02f1f) Extract shared fs code into shared.ts, simplify getDataDir on web - [`01fa0e3`](https://github.com/actualbudget/actual/commit/01fa0e39b2b1ce669a380e3572eca794ed836f94) Ban direct imports of platform-specific modules - [`82fdb96`](https://github.com/actualbudget/actual/commit/82fdb964df9897abfeb2fd1f739e21a785e646af) Add import/extensions so we avoid unnecessary extensions - [`4da7fbb`](https://github.com/actualbudget/actual/commit/4da7fbb17911fbb11c4dcc795292a37a3bf0afc3) Add release note - [`72e627c`](https://github.com/actualbudget/actual/commit/72e627c81b63bf4ddcd0505ddb2d35a9693114e4) Fix lint errors when file doesn’t exist - [`e852093`](https://github.com/actualbudget/actual/commit/e852093a483e2532931cb7e34e263e4a31862da0) Fix path error ### 📊 Changes **21 files changed** (+77 additions, -46 deletions) <details> <summary>View changed files</summary> 📝 `.eslintrc.js` (+16 -0) 📝 `packages/api/index.js` (+2 -1) 📝 `packages/desktop-client/src/components/budget/misc.js` (+1 -1) 📝 `packages/desktop-client/src/components/sidebar.js` (+1 -1) 📝 `packages/desktop-client/src/components/spreadsheet/SheetValue.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/spreadsheet/useSheetValue.js` (+1 -1) 📝 `packages/desktop-electron/index.js` (+1 -0) 📝 `packages/desktop-electron/server.js` (+1 -0) 📝 `packages/desktop-electron/window-state.js` (+1 -0) 📝 `packages/loot-core/init-node.js` (+2 -1) 📝 `packages/loot-core/src/platform/client/fetch/index.testing.ts` (+1 -0) 📝 `packages/loot-core/src/platform/server/fs/index.electron.ts` (+1 -31) 📝 `packages/loot-core/src/platform/server/fs/index.web.ts` (+2 -6) ➕ `packages/loot-core/src/platform/server/fs/path-join.electron.ts` (+3 -0) ➕ `packages/loot-core/src/platform/server/fs/shared.ts` (+32 -0) 📝 `packages/loot-core/src/platform/server/sqlite/index.web.test.ts` (+2 -0) 📝 `packages/loot-core/src/server/migrate/migrations.ts` (+1 -1) 📝 `packages/loot-core/src/types/api-handlers.d.ts` (+0 -0) 📝 `packages/loot-core/src/types/handlers.d.ts` (+2 -2) 📝 `packages/loot-core/src/types/main-handlers.d.ts` (+0 -0) _...and 1 more files_ </details> ### 📄 Description Bundle sizes are unchanged but now we no longer pull in the Electron-specific FS code on the web version --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:42:55 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#3526
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?