github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 07:01:45 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #3782] [MERGED] :electron: Removing node-fetch and updating root ca impl for more support #35249

New Issue
Closed
opened 2026-04-20 22:14:54 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-20 22:14:54 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/3782
Author: @MikesGlitch
Created: 11/4/2024
Status: ✅ Merged
Merged: 11/4/2024
Merged by: @MikesGlitch

Base: master ← Head: electron/use-env-ca-auth-instead-of-https-agent

📝 Commits (6)

📊 Changes

9 files changed (+57 additions, -74 deletions)

View changed files

📝 packages/desktop-electron/index.ts (+42 -2)
📝 packages/desktop-electron/package.json (+0 -1)
📝 packages/desktop-electron/server.ts (+7 -6)
📝 packages/loot-core/package.json (+0 -1)
📝 packages/loot-core/src/platform/server/fetch/index.electron.ts (+1 -4)
📝 packages/loot-core/src/server/main.ts (+0 -19)
📝 packages/loot-core/webpack/webpack.desktop.config.js (+1 -1)
➕ upcoming-release-notes/3782.md (+6 -0)
📝 yarn.lock (+0 -40)

📄 Description

Why

  • The less Electron specific dependencies the better
  • Electron supports Fetch out of the box nowadays so there's no reason to have node-fetch in Electron. Fetch supports the env variable but not the https.agent implementation - that's why that's updated.
  • I'd like us to start moving Electron specific functionality out of loot-core and into Electrons main process to make the system more rebust. This should prevent any issues in the event that loot-core bundle crashes (this has caused issues in the past)
  • It will reduce our electron bundle size a little bit

Found while working on this: #3631

Tested on:

  • Windows
  • Linux

Didn't test Mac but should be fine.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/3782 **Author:** [@MikesGlitch](https://github.com/MikesGlitch) **Created:** 11/4/2024 **Status:** ✅ Merged **Merged:** 11/4/2024 **Merged by:** [@MikesGlitch](https://github.com/MikesGlitch) **Base:** `master` ← **Head:** `electron/use-env-ca-auth-instead-of-https-agent` --- ### 📝 Commits (6) - [`2265164`](https://github.com/actualbudget/actual/commit/22651649eb0d8b6abaa253a29f5d74865d7e3f2b) updating root ca impl to use node env variable for more support - [`4400ff1`](https://github.com/actualbudget/actual/commit/4400ff11d9d57040257e28b94655e7d8c0ed86f2) release notes - [`98174bb`](https://github.com/actualbudget/actual/commit/98174bb0bd987d028c5baeb83b6a34f6c727b606) removing node-fetch - [`26adfec`](https://github.com/actualbudget/actual/commit/26adfecbdd1cb45b8859c1c93c54eeb3d7db2bdf) clean up - [`8cfd39f`](https://github.com/actualbudget/actual/commit/8cfd39fdc4504c723d9a71806ca8c81d57ae316d) error message - [`2d84b10`](https://github.com/actualbudget/actual/commit/2d84b1099563cac4f658805e711fb2097a9acdf0) Update 3782.md ### 📊 Changes **9 files changed** (+57 additions, -74 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-electron/index.ts` (+42 -2) 📝 `packages/desktop-electron/package.json` (+0 -1) 📝 `packages/desktop-electron/server.ts` (+7 -6) 📝 `packages/loot-core/package.json` (+0 -1) 📝 `packages/loot-core/src/platform/server/fetch/index.electron.ts` (+1 -4) 📝 `packages/loot-core/src/server/main.ts` (+0 -19) 📝 `packages/loot-core/webpack/webpack.desktop.config.js` (+1 -1) ➕ `upcoming-release-notes/3782.md` (+6 -0) 📝 `yarn.lock` (+0 -40) </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes --> # Why - The less Electron specific dependencies the better - Electron supports Fetch out of the box nowadays so there's no reason to have node-fetch in Electron. Fetch supports the env variable but not the https.agent implementation - that's why that's updated. - I'd like us to start moving Electron specific functionality out of loot-core and into Electrons main process to make the system more rebust. This should prevent any issues in the event that loot-core bundle crashes (this has caused issues in the past) - It will reduce our electron bundle size a little bit Found while working on this: #3631 **Tested on:** - [x] Windows - [x] Linux Didn't test Mac but should be fine. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 22:14:54 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#35249
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?