github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 15:12:35 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #3527] [MERGED] Fix ability to have duplicate account names #35104

New Issue
Closed
opened 2026-04-20 22:07:57 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-20 22:07:57 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/3527
Author: @qedi-r
Created: 9/28/2024
Status: ✅ Merged
Merged: 10/11/2024
Merged by: @youngcw

Base: master ← Head: issue-316

📝 Commits (10+)

  • 3738bde add duplicate name validation to sidebar, and both narrow/wide Account pages
  • 8c87837 unify error messages and styles
  • a54c1c9 keep state for the current account name on the mobile account modal
  • c1011f1 add release notes
  • 8a6b13e remove extra validation function
  • 4d7a0f7 fix typo in AccountSyncSidebar params
  • 7a3529d don't set current account name to empty string and prevent further changes on AccountMenuModal
  • a52d173 lint imports
  • b6df9c5 update error message to Name x already exists
  • 2642df5 Merge remote-tracking branch 'upstream/master' into issue-316

📊 Changes

6 files changed (+243 additions, -119 deletions)

View changed files

📝 packages/desktop-client/src/components/accounts/Account.tsx (+15 -5)
📝 packages/desktop-client/src/components/accounts/Header.jsx (+138 -94)
📝 packages/desktop-client/src/components/modals/AccountMenuModal.tsx (+42 -10)
📝 packages/desktop-client/src/components/modals/CreateLocalAccountModal.tsx (+19 -10)
➕ packages/desktop-client/src/components/util/accountValidation.ts (+23 -0)
➕ upcoming-release-notes/3527.md (+6 -0)

📄 Description

Fixes #316

I took a look at PR #2776, and I think I addressed all the original comments there. I tried to keep it consistently styled as well.

Create account:
image

Desktop account page:
image

Mobile account page:
image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/3527 **Author:** [@qedi-r](https://github.com/qedi-r) **Created:** 9/28/2024 **Status:** ✅ Merged **Merged:** 10/11/2024 **Merged by:** [@youngcw](https://github.com/youngcw) **Base:** `master` ← **Head:** `issue-316` --- ### 📝 Commits (10+) - [`3738bde`](https://github.com/actualbudget/actual/commit/3738bde9c3d0e811ae5a3b7007ee2c0e4773dec9) add duplicate name validation to sidebar, and both narrow/wide Account pages - [`8c87837`](https://github.com/actualbudget/actual/commit/8c8783716c5e228aa1c46aa1d4f3258b79185b88) unify error messages and styles - [`a54c1c9`](https://github.com/actualbudget/actual/commit/a54c1c93670e2d8a0ec7965f8ed9fe67c3fac308) keep state for the current account name on the mobile account modal - [`c1011f1`](https://github.com/actualbudget/actual/commit/c1011f176d8998a0b23edc1782cb72c4a17b706b) add release notes - [`8a6b13e`](https://github.com/actualbudget/actual/commit/8a6b13e65644f385681576d62f9a07733a6baafe) remove extra validation function - [`4d7a0f7`](https://github.com/actualbudget/actual/commit/4d7a0f770d2d5da3ff8b6c4f9c91f8900f866166) fix typo in AccountSyncSidebar params - [`7a3529d`](https://github.com/actualbudget/actual/commit/7a3529d73d3c378417513677f4bbecca86b374df) don't set current account name to empty string and prevent further changes on AccountMenuModal - [`a52d173`](https://github.com/actualbudget/actual/commit/a52d1730a65c61ae6bea4ae10a20159e7c4fa4b4) lint imports - [`b6df9c5`](https://github.com/actualbudget/actual/commit/b6df9c57f756373f734ac62cc41d53e11c11a2f8) update error message to Name x already exists - [`2642df5`](https://github.com/actualbudget/actual/commit/2642df54e65fb48d6d3c8a99ae4ae00df62d3dc0) Merge remote-tracking branch 'upstream/master' into issue-316 ### 📊 Changes **6 files changed** (+243 additions, -119 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/accounts/Account.tsx` (+15 -5) 📝 `packages/desktop-client/src/components/accounts/Header.jsx` (+138 -94) 📝 `packages/desktop-client/src/components/modals/AccountMenuModal.tsx` (+42 -10) 📝 `packages/desktop-client/src/components/modals/CreateLocalAccountModal.tsx` (+19 -10) ➕ `packages/desktop-client/src/components/util/accountValidation.ts` (+23 -0) ➕ `upcoming-release-notes/3527.md` (+6 -0) </details> ### 📄 Description Fixes #316 I took a look at PR #2776, and I think I addressed all the original comments there. I tried to keep it consistently styled as well. Create account: ![image](https://github.com/user-attachments/assets/c5961d03-a623-4f32-953b-696fdcfa27b7) Desktop account page: ![image](https://github.com/user-attachments/assets/3ab0a08d-6775-4e59-b885-4aed894ab958) Mobile account page: ![image](https://github.com/user-attachments/assets/c66a6be1-3680-4a4b-a1d3-d13702634b59) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 22:07:57 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#35104
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?