github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 19:52:56 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #1077] [MERGED] chore: enforce proper types in sync/index #3505

New Issue
Closed
opened 2026-02-28 20:42:37 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:42:37 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/1077
Author: @TomAFrench
Created: 5/30/2023
Status: ✅ Merged
Merged: 6/25/2023
Merged by: @MatissJanis

Base: master ← Head: message-types

📝 Commits (10+)

📊 Changes

14 files changed (+114 additions, -64 deletions)

View changed files

📝 packages/crdt/src/crdt/timestamp.ts (+1 -1)
📝 packages/loot-core/src/server/budget/actions.ts (+3 -3)
📝 packages/loot-core/src/server/db/index.ts (+2 -2)
📝 packages/loot-core/src/server/main.ts (+1 -1)
📝 packages/loot-core/src/server/mutators.ts (+2 -2)
📝 packages/loot-core/src/server/sync/encoder.ts (+12 -3)
📝 packages/loot-core/src/server/sync/index.ts (+47 -31)
📝 packages/loot-core/src/server/sync/migrate.test.ts (+12 -5)
📝 packages/loot-core/src/server/sync/sync.property.test.ts (+5 -4)
📝 packages/loot-core/src/server/sync/sync.test.ts (+7 -5)
➕ packages/loot-core/src/server/sync/utils.ts (+3 -0)
📝 packages/loot-core/src/shared/async.ts (+5 -3)
📝 packages/loot-core/src/shared/util.ts (+8 -4)
➕ upcoming-release-notes/1077.md (+6 -0)

📄 Description

I've updated the return values in sync/index to sensible values based on how they're being called.

I've updated the type of msg.value to be string | number | null to match the values expected by serializeValue

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/1077 **Author:** [@TomAFrench](https://github.com/TomAFrench) **Created:** 5/30/2023 **Status:** ✅ Merged **Merged:** 6/25/2023 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `message-types` --- ### 📝 Commits (10+) - [`51dfaba`](https://github.com/actualbudget/actual/commit/51dfababa716d1d3dfafce45ee745e82357bca9f) chore: enforce proper types in `sync/index` - [`42cbc46`](https://github.com/actualbudget/actual/commit/42cbc46f5d185bd8f4a4667c1e22dceeaf6bfc39) chore: add changelog entry - [`8d888e6`](https://github.com/actualbudget/actual/commit/8d888e6dd007830935495bfe2d4b1a76e39d5b39) chore: update types - [`bba3d2b`](https://github.com/actualbudget/actual/commit/bba3d2bc29b4a353a5bee995ac080fa7ea84f9bf) chore: fixup types - [`37045fd`](https://github.com/actualbudget/actual/commit/37045fde61e7e2d2c9b261429a8f9e6181db336e) chore: correct spelling of `transactionsMap` - [`50e1382`](https://github.com/actualbudget/actual/commit/50e138204ef5975edee35a425293d5acb7ab36c0) chore: address review comments - [`b0bfcdf`](https://github.com/actualbudget/actual/commit/b0bfcdfe43a65d9af0d822939b8b1abb8d38cf69) chore: linter - [`ed6a23f`](https://github.com/actualbudget/actual/commit/ed6a23f48884ecc54bda6415d883f5b55d5331d4) chore: linter - [`47c0ce8`](https://github.com/actualbudget/actual/commit/47c0ce80a55935981807ec965d8382ce67d55726) Merge branch 'master' into message-types - [`01241f7`](https://github.com/actualbudget/actual/commit/01241f76a9112b867565c8336b7f52c483f6ac88) chore: linter ### 📊 Changes **14 files changed** (+114 additions, -64 deletions) <details> <summary>View changed files</summary> 📝 `packages/crdt/src/crdt/timestamp.ts` (+1 -1) 📝 `packages/loot-core/src/server/budget/actions.ts` (+3 -3) 📝 `packages/loot-core/src/server/db/index.ts` (+2 -2) 📝 `packages/loot-core/src/server/main.ts` (+1 -1) 📝 `packages/loot-core/src/server/mutators.ts` (+2 -2) 📝 `packages/loot-core/src/server/sync/encoder.ts` (+12 -3) 📝 `packages/loot-core/src/server/sync/index.ts` (+47 -31) 📝 `packages/loot-core/src/server/sync/migrate.test.ts` (+12 -5) 📝 `packages/loot-core/src/server/sync/sync.property.test.ts` (+5 -4) 📝 `packages/loot-core/src/server/sync/sync.test.ts` (+7 -5) ➕ `packages/loot-core/src/server/sync/utils.ts` (+3 -0) 📝 `packages/loot-core/src/shared/async.ts` (+5 -3) 📝 `packages/loot-core/src/shared/util.ts` (+8 -4) ➕ `upcoming-release-notes/1077.md` (+6 -0) </details> ### 📄 Description I've updated the return values in `sync/index` to sensible values based on how they're being called. I've updated the type of `msg.value` to be `string | number | null` to match the values expected by `serializeValue` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:42:37 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#3505
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?