github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-07 20:38:54 -05:00
Code Issues 1.6k Packages Projects Releases 55 Wiki Activity

[PR #3308] [MERGED] :electron: Desktop app to work with self signed certificates #34984

New Issue
Closed
opened 2026-04-20 22:02:58 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-20 22:02:58 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/3308
Author: @MikesGlitch
Created: 8/23/2024
Status: ✅ Merged
Merged: 8/28/2024
Merged by: @MikesGlitch

Base: master ← Head: electron/self-signed-certs

📝 Commits (10+)

📊 Changes

6 files changed (+94 additions, -11 deletions)

View changed files

📝 packages/desktop-client/src/components/manager/ConfigServer.tsx (+59 -10)
📝 packages/loot-core/src/platform/server/fetch/index.electron.ts (+1 -1)
📝 packages/loot-core/src/server/main.ts (+26 -0)
📝 packages/loot-core/src/types/prefs.d.ts (+1 -0)
📝 packages/loot-core/webpack/webpack.browser.config.js (+1 -0)
➕ upcoming-release-notes/3308.md (+6 -0)

📄 Description

#3304

Allowing users to select their self-signed certificate and save it to global-store.json. We manually add the certificate to the trusted cert chain (required for node).

This allows the desktop app to call servers that use self-signed certs. We support .crt and .pem.

test

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/3308 **Author:** [@MikesGlitch](https://github.com/MikesGlitch) **Created:** 8/23/2024 **Status:** ✅ Merged **Merged:** 8/28/2024 **Merged by:** [@MikesGlitch](https://github.com/MikesGlitch) **Base:** `master` ← **Head:** `electron/self-signed-certs` --- ### 📝 Commits (10+) - [`4c8611c`](https://github.com/actualbudget/actual/commit/4c8611c804c494ace143f7643dc3e0394b74f146) solves the problem but creates a vulnerability - [`8d569b3`](https://github.com/actualbudget/actual/commit/8d569b369e32511958031c8cf6028e914625819f) sake... - [`ab7c846`](https://github.com/actualbudget/actual/commit/ab7c846a166dee93f9e776ce552242b5b9d8a476) working but need to specify rootca.pem - [`5489969`](https://github.com/actualbudget/actual/commit/5489969b1b127e337fa2a20defbfde3de846e7af) works - [`7bfbc68`](https://github.com/actualbudget/actual/commit/7bfbc68fdeb1a87cd58286052dbad32600063459) being flexible on the cert names, as long as its a crt or pem - [`bff073e`](https://github.com/actualbudget/actual/commit/bff073e54b18b9a4a313199559194f0314e5e68c) remove console logs - [`e1b6759`](https://github.com/actualbudget/actual/commit/e1b67595e4b304080c9d7520fcec56a4e4e25513) initial setup for adding cert - [`d4b1752`](https://github.com/actualbudget/actual/commit/d4b1752b317f37082e2a68e8955389c1f316556b) caps - [`3a55248`](https://github.com/actualbudget/actual/commit/3a55248ce40a12bf5c8e1d6daa0300e92d3b303a) comments - [`561890d`](https://github.com/actualbudget/actual/commit/561890d5d9135003b29d02ce893c80c865149e9f) fix ts strict ### 📊 Changes **6 files changed** (+94 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/manager/ConfigServer.tsx` (+59 -10) 📝 `packages/loot-core/src/platform/server/fetch/index.electron.ts` (+1 -1) 📝 `packages/loot-core/src/server/main.ts` (+26 -0) 📝 `packages/loot-core/src/types/prefs.d.ts` (+1 -0) 📝 `packages/loot-core/webpack/webpack.browser.config.js` (+1 -0) ➕ `upcoming-release-notes/3308.md` (+6 -0) </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes --> #3304 Allowing users to select their self-signed certificate and save it to global-store.json. We manually add the certificate to the trusted cert chain (required for node). This allows the desktop app to call servers that use self-signed certs. We support .crt and .pem. ![test](https://github.com/user-attachments/assets/ed332bcf-b458-4fcb-b91d-649122f78509) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 22:02:58 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#34984
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?