github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-25 15:52:59 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #1034] [MERGED] Updated account ordering in the account autocomplete popup #3478

New Issue
Closed
opened 2026-02-28 20:42:14 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:42:14 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/1034
Author: @Miodec
Created: 5/15/2023
Status: ✅ Merged
Merged: 5/15/2023
Merged by: @j-f1

Base: master ← Head: account-autocomplete

📝 Commits (8)

  • 7fcf280 showing if account is closed in the title
  • fb5bd20 ordering accounts by their "offbudget" property
  • 77d6f75 not including closed accounts in the transaction table account autocomplete
  • 9cfc0e7 showing "closed accounts" title for all closed accounts instead of grouping them by "closed on budget" and "closed off budget"
  • 7802e2e added a release note file
  • 6daffac authors should be a list
  • a91c8a3 one line
  • 36a6355 Merge branch 'master' into account-autocomplete

📊 Changes

3 files changed (+33 additions, -7 deletions)

View changed files

📝 packages/desktop-client/src/components/accounts/TransactionsTable.js (+1 -0)
📝 packages/desktop-client/src/components/autocomplete/AccountAutocomplete.js (+26 -7)
➕ upcoming-release-notes/1034.md (+6 -0)

📄 Description

Changes in the pr:

  • Removed closed accounts when adding a transaction
  • Updated ordering of the account autocomplete popup
    Previous ordering seemed to put closed accounts at the top, then order accounts by name. This PR makes the accounts appear in the same order as they do on the left panel - on budget first, then off budget, then closed accounts.

(increased max height just for the screenshots)
Before:
Screenshot 2023-05-15 at 19 09 07

After, without closed accounts (adding a transaction):
Screenshot 2023-05-15 at 19 09 42

After, including closed accounts:
Screenshot 2023-05-15 at 19 10 11

First PR to this project - let me know if i messed something up.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/1034 **Author:** [@Miodec](https://github.com/Miodec) **Created:** 5/15/2023 **Status:** ✅ Merged **Merged:** 5/15/2023 **Merged by:** [@j-f1](https://github.com/j-f1) **Base:** `master` ← **Head:** `account-autocomplete` --- ### 📝 Commits (8) - [`7fcf280`](https://github.com/actualbudget/actual/commit/7fcf2805724b1511e881535fa650cf40a7eb70b3) showing if account is closed in the title - [`fb5bd20`](https://github.com/actualbudget/actual/commit/fb5bd20afdb6d90ccf108d33eb6955f3a56e309d) ordering accounts by their "offbudget" property - [`77d6f75`](https://github.com/actualbudget/actual/commit/77d6f75f18349df1cd79c66b6a94cc95c362bba7) not including closed accounts in the transaction table account autocomplete - [`9cfc0e7`](https://github.com/actualbudget/actual/commit/9cfc0e715945ecdc78fb24933bce01a8905f8da3) showing "closed accounts" title for all closed accounts instead of grouping them by "closed on budget" and "closed off budget" - [`7802e2e`](https://github.com/actualbudget/actual/commit/7802e2e139113466507b952a563ff3c9525db696) added a release note file - [`6daffac`](https://github.com/actualbudget/actual/commit/6daffacb14149f64ce831312df2cbcdbe9579bac) authors should be a list - [`a91c8a3`](https://github.com/actualbudget/actual/commit/a91c8a39e5c89ca37367d5e8d7d372dc3bb971b3) one line - [`36a6355`](https://github.com/actualbudget/actual/commit/36a635570cec4b5d9bd329a961a6a72cb87ecfc2) Merge branch 'master' into account-autocomplete ### 📊 Changes **3 files changed** (+33 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/accounts/TransactionsTable.js` (+1 -0) 📝 `packages/desktop-client/src/components/autocomplete/AccountAutocomplete.js` (+26 -7) ➕ `upcoming-release-notes/1034.md` (+6 -0) </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes --> Changes in the pr: - Removed closed accounts when adding a transaction - Updated ordering of the account autocomplete popup Previous ordering seemed to put closed accounts at the top, then order accounts by name. This PR makes the accounts appear in the same order as they do on the left panel - on budget first, then off budget, then closed accounts. (increased max height just for the screenshots) Before: ![Screenshot 2023-05-15 at 19 09 07](https://github.com/actualbudget/actual/assets/13181393/a8727443-5934-4c42-9e6b-ec22cc768234) After, without closed accounts (adding a transaction): ![Screenshot 2023-05-15 at 19 09 42](https://github.com/actualbudget/actual/assets/13181393/7a9e77c0-4fb7-4c6a-9c7d-7b4e3eab9e95) After, including closed accounts: ![Screenshot 2023-05-15 at 19 10 11](https://github.com/actualbudget/actual/assets/13181393/ec91d17a-7a2e-407e-bfab-395224b198b5) First PR to this project - let me know if i messed something up. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:42:14 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#3478
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?