github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 07:01:45 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #2707] [MERGED] Custom Reports convert all jsx files #34660

New Issue
Closed
opened 2026-04-20 21:47:25 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-20 21:47:25 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/2707
Author: @carkom
Created: 5/4/2024
Status: ✅ Merged
Merged: 5/7/2024
Merged by: @carkom

Base: master ← Head: CR-TS

📝 Commits (10+)

📊 Changes

16 files changed (+466 additions, -225 deletions)

View changed files

📝 packages/desktop-client/src/components/autocomplete/CategoryAutocomplete.tsx (+1 -1)
📝 packages/desktop-client/src/components/reports/CategorySelector.tsx (+2 -3)
📝 packages/desktop-client/src/components/reports/Overview.tsx (+3 -5)
📝 packages/desktop-client/src/components/reports/ReportOptions.ts (+60 -33)
📝 packages/desktop-client/src/components/reports/ReportRouter.tsx (+0 -0)
📝 packages/desktop-client/src/components/reports/ReportSidebar.tsx (+57 -15)
📝 packages/desktop-client/src/components/reports/ReportTopbar.tsx (+40 -12)
📝 packages/desktop-client/src/components/reports/disabledList.ts (+67 -38)
📝 packages/desktop-client/src/components/reports/getLiveRange.ts (+3 -3)
📝 packages/desktop-client/src/components/reports/reportRanges.ts (+3 -3)
📝 packages/desktop-client/src/components/reports/reports/CustomReport.tsx (+206 -98)
📝 packages/desktop-client/src/components/reports/spreadsheets/custom-spreadsheet.ts (+6 -6)
📝 packages/desktop-client/src/components/reports/spreadsheets/grouped-spreadsheet.ts (+6 -6)
📝 packages/desktop-client/src/hooks/useFilters.ts (+5 -1)
📝 packages/loot-core/src/types/models/reports.d.ts (+1 -1)
➕ upcoming-release-notes/2707.md (+6 -0)

📄 Description

There's about 5 jsx files left in the custom reports files. All the newly minted tsx files are strict.

I need some assistance as Typescript is not my strong suit. I've got it 90% of the way there. Just need some seasoned pros to have a look at what I can improve on.

Next step is to make strict all the non-strict TS files within custom reports files.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/2707 **Author:** [@carkom](https://github.com/carkom) **Created:** 5/4/2024 **Status:** ✅ Merged **Merged:** 5/7/2024 **Merged by:** [@carkom](https://github.com/carkom) **Base:** `master` ← **Head:** `CR-TS` --- ### 📝 Commits (10+) - [`c6f4da3`](https://github.com/actualbudget/actual/commit/c6f4da351ad52ed9844ea82e453f19e2e52d1af4) Overview - [`f3233f6`](https://github.com/actualbudget/actual/commit/f3233f64bb22487f57133b3268f5b01debcfee8f) Router and Selector - [`e2d3bab`](https://github.com/actualbudget/actual/commit/e2d3bab5b195a6a1d75ded40e8a584b28b6bd235) ReportSidebar - [`f5b5c27`](https://github.com/actualbudget/actual/commit/f5b5c2787cda667070dc98db59896ca4cbc72c50) ReportTopbar - [`337e42e`](https://github.com/actualbudget/actual/commit/337e42e8a6ad2fb4e2ac4244ff76a4926f980cf0) CustomReport - [`e473fe5`](https://github.com/actualbudget/actual/commit/e473fe5db25bebac65a9adaf0feca43a9fffd47d) updates - [`ae5ee9d`](https://github.com/actualbudget/actual/commit/ae5ee9d4157a8ae96ba6a0439a44f5a64b557be3) notes - [`be0fbfe`](https://github.com/actualbudget/actual/commit/be0fbfed18b09650ce30d21519bc05dbe582d269) Patch some TS issues - [`32b72e5`](https://github.com/actualbudget/actual/commit/32b72e52e4954ddb3e66bd5cc7ed9b3450e4f6b5) Merge branch 'master' into CR-TS - [`5b0138a`](https://github.com/actualbudget/actual/commit/5b0138a43e2129d26f33c5055b5aa2a4716bfcda) fix malfunctioning disabled lists ### 📊 Changes **16 files changed** (+466 additions, -225 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/autocomplete/CategoryAutocomplete.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/reports/CategorySelector.tsx` (+2 -3) 📝 `packages/desktop-client/src/components/reports/Overview.tsx` (+3 -5) 📝 `packages/desktop-client/src/components/reports/ReportOptions.ts` (+60 -33) 📝 `packages/desktop-client/src/components/reports/ReportRouter.tsx` (+0 -0) 📝 `packages/desktop-client/src/components/reports/ReportSidebar.tsx` (+57 -15) 📝 `packages/desktop-client/src/components/reports/ReportTopbar.tsx` (+40 -12) 📝 `packages/desktop-client/src/components/reports/disabledList.ts` (+67 -38) 📝 `packages/desktop-client/src/components/reports/getLiveRange.ts` (+3 -3) 📝 `packages/desktop-client/src/components/reports/reportRanges.ts` (+3 -3) 📝 `packages/desktop-client/src/components/reports/reports/CustomReport.tsx` (+206 -98) 📝 `packages/desktop-client/src/components/reports/spreadsheets/custom-spreadsheet.ts` (+6 -6) 📝 `packages/desktop-client/src/components/reports/spreadsheets/grouped-spreadsheet.ts` (+6 -6) 📝 `packages/desktop-client/src/hooks/useFilters.ts` (+5 -1) 📝 `packages/loot-core/src/types/models/reports.d.ts` (+1 -1) ➕ `upcoming-release-notes/2707.md` (+6 -0) </details> ### 📄 Description There's about 5 jsx files left in the custom reports files. All the newly minted tsx files are strict. I need some assistance as Typescript is not my strong suit. I've got it 90% of the way there. Just need some seasoned pros to have a look at what I can improve on. Next step is to make strict all the non-strict TS files within custom reports files. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 21:47:25 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#34660
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?