github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 20:15:33 -05:00
Code Issues 1.5k Packages Projects Releases 55 Wiki Activity

[PR #2398] [MERGED] Add option to make a transfer from two selected transactions #34478

New Issue
Closed
opened 2026-04-20 21:38:06 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-20 21:38:06 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/2398
Author: @twk3
Created: 2/26/2024
Status: ✅ Merged
Merged: 3/3/2024
Merged by: @twk3

Base: master ← Head: twk3/make-transfers

📝 Commits (3)

  • 463aa43 Adds option to make a transfer from two selected transactions
  • fe067b7 Move common transfer logic to loot-core
  • 6a3f3ad Add end-to-end test for make transfer

📊 Changes

9 files changed (+268 additions, -2 deletions)

View changed files

📝 packages/desktop-client/e2e/accounts.test.js (+49 -2)
📝 packages/desktop-client/e2e/page-models/account-page.js (+30 -0)
📝 packages/desktop-client/src/components/accounts/Account.jsx (+48 -0)
📝 packages/desktop-client/src/components/accounts/Header.jsx (+6 -0)
📝 packages/desktop-client/src/components/table.tsx (+2 -0)
📝 packages/desktop-client/src/components/transactions/SelectedTransactions.jsx (+33 -0)
➕ packages/loot-core/src/client/transfer.test.ts (+75 -0)
➕ packages/loot-core/src/client/transfer.ts (+19 -0)
➕ upcoming-release-notes/2398.md (+6 -0)

📄 Description

Summary

Add an option in the selected transactions menu in mutli-account budget pages (all accounts, for budget/etc), that allows you to relate two transactions across accounts as a transfer.

Feature

Feature: https://github.com/actualbudget/actual/issues/1891

Details

  • Transactions amount must match
  • Transactions must be from different acounts
  • Split transactions not eligible

Workflows

Single account pages don't show the option at all in the selection menu:

SingleAccountSelectTransactionsTooltip

Multi account pages always show the option in the selection menu, but disabled when the selections are not valid for the transfer action:

MultiAccountSingleTransactionTooltip

For valid selections the action is enabled in the selection tooltip:

MultiAccountValidTransferTooltip

Final PR Tasks

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/2398 **Author:** [@twk3](https://github.com/twk3) **Created:** 2/26/2024 **Status:** ✅ Merged **Merged:** 3/3/2024 **Merged by:** [@twk3](https://github.com/twk3) **Base:** `master` ← **Head:** `twk3/make-transfers` --- ### 📝 Commits (3) - [`463aa43`](https://github.com/actualbudget/actual/commit/463aa4355c2f78d29640f1c731b35b10c0564293) Adds option to make a transfer from two selected transactions - [`fe067b7`](https://github.com/actualbudget/actual/commit/fe067b78eaad5ceea33ecd50fec283283d38e6b6) Move common transfer logic to loot-core - [`6a3f3ad`](https://github.com/actualbudget/actual/commit/6a3f3ad2c1d8150ca5815bdcc9ba7ec4af4f3be8) Add end-to-end test for make transfer ### 📊 Changes **9 files changed** (+268 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/e2e/accounts.test.js` (+49 -2) 📝 `packages/desktop-client/e2e/page-models/account-page.js` (+30 -0) 📝 `packages/desktop-client/src/components/accounts/Account.jsx` (+48 -0) 📝 `packages/desktop-client/src/components/accounts/Header.jsx` (+6 -0) 📝 `packages/desktop-client/src/components/table.tsx` (+2 -0) 📝 `packages/desktop-client/src/components/transactions/SelectedTransactions.jsx` (+33 -0) ➕ `packages/loot-core/src/client/transfer.test.ts` (+75 -0) ➕ `packages/loot-core/src/client/transfer.ts` (+19 -0) ➕ `upcoming-release-notes/2398.md` (+6 -0) </details> ### 📄 Description ## Summary Add an option in the selected transactions menu in mutli-account budget pages (all accounts, for budget/etc), that allows you to relate two transactions across accounts as a transfer. ## Feature Feature: https://github.com/actualbudget/actual/issues/1891 ## Details - Transactions amount must match - Transactions must be from different acounts - Split transactions not eligible ## Workflows Single account pages don't show the option at all in the selection menu: ![SingleAccountSelectTransactionsTooltip](https://github.com/actualbudget/actual/assets/2806882/80a5a90d-68c1-4ab3-8cb9-c4ccd3f79331) Multi account pages always show the option in the selection menu, but disabled when the selections are not valid for the transfer action: ![MultiAccountSingleTransactionTooltip](https://github.com/actualbudget/actual/assets/2806882/3c89119b-a747-4842-9908-814477192d87) For valid selections the action is enabled in the selection tooltip: ![MultiAccountValidTransferTooltip](https://github.com/actualbudget/actual/assets/2806882/3b2bc1a3-e712-4adb-922c-d48f4c6d4164) ## Final PR Tasks - [x] extract the can-be-transfer logic to transfers.ts and reuse in both places - [x] Add tests - [x] Docs PR: https://github.com/actualbudget/docs/pull/321 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 21:38:06 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#34478
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?