github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-10 20:23:07 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #984] [MERGED] Fix sync-related errors that show up in the console when not using a server #3447

New Issue
Closed
opened 2026-02-28 20:41:47 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:41:47 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/984
Author: @j-f1
Created: 5/1/2023
Status: ✅ Merged
Merged: 6/11/2023
Merged by: @j-f1

Base: master ← Head: jed/sync-errors

📝 Commits (10+)

  • a26be05 Migrate to missing server being null, disable syncing when server is missing
  • 88cd730 Set reportBudget to default to false
  • fe3c345 Fix Nordigen token/server handling issues
  • 11c651f Update other checks to be consistent & use early return pattern
  • 7126b60 Create 984.md
  • 6a8d42d No need for getServerUrl()
  • dff7555 Add a did-boostrap asyncStorage item to track if the pick a server screen needs to show
  • 13b6319 Remove unnecessary multiGet
  • 06b00c4 Fix condition for returning null from subscribe-get-user
  • 80d6932 Fix useBootstrapped

📊 Changes

8 files changed (+208 additions, -189 deletions)

View changed files

📝 packages/desktop-client/src/components/ServerContext.js (+2 -10)
📝 packages/desktop-client/src/components/manager/subscribe/common.tsx (+2 -1)
📝 packages/desktop-client/src/hooks/useFeatureFlag.ts (+1 -0)
📝 packages/loot-core/src/server/accounts/sync.ts (+48 -49)
📝 packages/loot-core/src/server/cloud-storage.ts (+1 -1)
📝 packages/loot-core/src/server/main.ts (+146 -126)
📝 packages/loot-core/src/types/main-handlers.d.ts (+2 -2)
➕ upcoming-release-notes/984.md (+6 -0)

📄 Description

Previously, the frontend would attempt to make real requests to https://not-configured/, which of course failed. I’ve changed the internal structure to have the lack of a server expressed as a null server. A new did-bootstrap browser-level setting has been added to track if the user clicked “Don’t use a server.”

Finally, I updated the auth logic for methods that call out to the server to make them consistent and use the early return style which reduces indentation.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/984 **Author:** [@j-f1](https://github.com/j-f1) **Created:** 5/1/2023 **Status:** ✅ Merged **Merged:** 6/11/2023 **Merged by:** [@j-f1](https://github.com/j-f1) **Base:** `master` ← **Head:** `jed/sync-errors` --- ### 📝 Commits (10+) - [`a26be05`](https://github.com/actualbudget/actual/commit/a26be057b06d288ab7085d17e1458172d716296e) Migrate to missing server being null, disable syncing when server is missing - [`88cd730`](https://github.com/actualbudget/actual/commit/88cd730c199df7a81550f868948aa0aaea932cfe) Set reportBudget to default to false - [`fe3c345`](https://github.com/actualbudget/actual/commit/fe3c345ad3084f73d50e1b22cb2058b265484b39) Fix Nordigen token/server handling issues - [`11c651f`](https://github.com/actualbudget/actual/commit/11c651f3922006ca6fe06fd068a101058bf1f800) Update other checks to be consistent & use early return pattern - [`7126b60`](https://github.com/actualbudget/actual/commit/7126b60e2f8e2a5784bc8e29d1f40023d7351e4b) Create 984.md - [`6a8d42d`](https://github.com/actualbudget/actual/commit/6a8d42d83463d98bc4232a81c4cfc47d8d0ed070) No need for getServerUrl() - [`dff7555`](https://github.com/actualbudget/actual/commit/dff7555663109f9bb5b670a8524d4661680a780e) Add a did-boostrap asyncStorage item to track if the pick a server screen needs to show - [`13b6319`](https://github.com/actualbudget/actual/commit/13b63197a79a01752cb6fcd60afe1ebc146ba218) Remove unnecessary multiGet - [`06b00c4`](https://github.com/actualbudget/actual/commit/06b00c4f193f4f620954418a5c9613bc58c00b8d) Fix condition for returning null from subscribe-get-user - [`80d6932`](https://github.com/actualbudget/actual/commit/80d69322015a7d938f695c2c0126419deaa33599) Fix useBootstrapped ### 📊 Changes **8 files changed** (+208 additions, -189 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/ServerContext.js` (+2 -10) 📝 `packages/desktop-client/src/components/manager/subscribe/common.tsx` (+2 -1) 📝 `packages/desktop-client/src/hooks/useFeatureFlag.ts` (+1 -0) 📝 `packages/loot-core/src/server/accounts/sync.ts` (+48 -49) 📝 `packages/loot-core/src/server/cloud-storage.ts` (+1 -1) 📝 `packages/loot-core/src/server/main.ts` (+146 -126) 📝 `packages/loot-core/src/types/main-handlers.d.ts` (+2 -2) ➕ `upcoming-release-notes/984.md` (+6 -0) </details> ### 📄 Description Previously, the frontend would attempt to make real requests to `https://not-configured/`, which of course failed. I’ve changed the internal structure to have the lack of a server expressed as a `null` server. A new `did-bootstrap` browser-level setting has been added to track if the user clicked “Don’t use a server.” Finally, I updated the auth logic for methods that call out to the server to make them consistent and use the early return style which reduces indentation. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:41:47 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#3447
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?