github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-05 22:52:20 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #2325] [MERGED] Re-open autocomplete dropdown on change #34446

New Issue
Closed
opened 2026-04-20 21:36:47 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-20 21:36:47 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/2325
Author: @jfdoming
Created: 2/3/2024
Status: ✅ Merged
Merged: 2/3/2024
Merged by: @youngcw

Base: master ← Head: jfdoming/fix-autocomplete-dropdown

📝 Commits (2)

  • c149135 Re-open autocomplete dropdown on change
  • 6445963 Add release notes with new PR ID

📊 Changes

2 files changed (+7 additions, -0 deletions)

View changed files

📝 packages/desktop-client/src/components/autocomplete/Autocomplete.tsx (+1 -0)
➕ upcoming-release-notes/2325.md (+6 -0)

📄 Description

This fixes an annoying bug I noticed: if you have a dropdown open, and select an item, you can't then go and modify what you typed and select a new item without refocusing the field (it just clears a state). Illustration:

  1. Find an item
    image

  2. Select it
    image

  3. Try to edit your selection; no dropdown appears again
    image

With this PR, step 3 now looks like this:
image

This is useful for certain keyboard-based workflows, as you can CTRL-A, Backspace to search for a new category (orBackspace a single letter to search common prefixes) instead of Blur field, refocus field.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/2325 **Author:** [@jfdoming](https://github.com/jfdoming) **Created:** 2/3/2024 **Status:** ✅ Merged **Merged:** 2/3/2024 **Merged by:** [@youngcw](https://github.com/youngcw) **Base:** `master` ← **Head:** `jfdoming/fix-autocomplete-dropdown` --- ### 📝 Commits (2) - [`c149135`](https://github.com/actualbudget/actual/commit/c1491355a8363866bad6e9182114f9c35284da84) Re-open autocomplete dropdown on change - [`6445963`](https://github.com/actualbudget/actual/commit/6445963428da0a61c31cf2e307cb2e34e35c15b9) Add release notes with new PR ID ### 📊 Changes **2 files changed** (+7 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/autocomplete/Autocomplete.tsx` (+1 -0) ➕ `upcoming-release-notes/2325.md` (+6 -0) </details> ### 📄 Description This fixes an annoying bug I noticed: if you have a dropdown open, and select an item, you can't then go and modify what you typed and select a new item without refocusing the field (it just clears a state). Illustration: 1. Find an item <img width="300" alt="image" src="https://github.com/actualbudget/actual/assets/9922514/4d6f0742-6942-4852-a693-8625a9e6e9bd"> 2. Select it <img width="318" alt="image" src="https://github.com/actualbudget/actual/assets/9922514/ffd151e7-af08-4a3f-a0a0-abb169e9cce0"> 3. Try to edit your selection; no dropdown appears again <img width="312" alt="image" src="https://github.com/actualbudget/actual/assets/9922514/968f9c21-0097-44ec-8026-fd70da5efa3f"> With this PR, step 3 now looks like this: <img width="317" alt="image" src="https://github.com/actualbudget/actual/assets/9922514/a031bfb0-8ef8-4c2c-aa07-1c3993cdf5eb"> This is useful for certain keyboard-based workflows, as you can `CTRL-A, Backspace` to search for a new category (or`Backspace` a single letter to search common prefixes) instead of `Blur field, refocus field`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 21:36:47 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#34446
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?