github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-10 12:12:39 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #931] [MERGED] ♻️ (autocomplete) cleaning up state updates #3414

New Issue
Closed
opened 2026-02-28 20:41:18 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:41:18 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/931
Author: @MatissJanis
Created: 4/21/2023
Status: ✅ Merged
Merged: 4/23/2023
Merged by: @MatissJanis

Base: master ← Head: matiss/autocomplete-cleanup

📝 Commits (10+)

  • 1a85042 ♻️ (autocomplete) cleaning up state updates
  • 6e13cab React.useState -> useState
  • 74ca6b2 Release notes
  • f22cda8 Cleaned up a bit
  • 5f05b38 Payee creation fix
  • 90c23c1 remove clearAfterSelect
  • 0eef184 Fix e2e
  • 96d427c Merge branch 'master' into matiss/autocomplete-cleanup
  • 52d9a4d Merge branch 'master' into matiss/autocomplete-cleanup
  • a070240 Fix e2e by removing rawPayee workarounds

📊 Changes

4 files changed (+322 additions, -447 deletions)

View changed files

📝 packages/desktop-client/src/components/autocomplete/Autocomplete.js (+271 -391)
📝 packages/desktop-client/src/components/autocomplete/PayeeAutocomplete.js (+30 -39)
📝 packages/desktop-client/src/components/util/GenericInput.js (+15 -17)
➕ upcoming-release-notes/931.md (+6 -0)

📄 Description

Cleaning up the autocomplete state updates by removing the updater and moving to react state hooks.

This is mostly a copy&paste, but I also fixed a few small issues and improved things a bit.. apologies for the big PR, but making this smaller would be very tricky.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/931 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 4/21/2023 **Status:** ✅ Merged **Merged:** 4/23/2023 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `matiss/autocomplete-cleanup` --- ### 📝 Commits (10+) - [`1a85042`](https://github.com/actualbudget/actual/commit/1a8504256977deff0794a74bf353265dc867f88c) :recycle: (autocomplete) cleaning up state updates - [`6e13cab`](https://github.com/actualbudget/actual/commit/6e13cab499231e26524147845119cb55b09feb26) React.useState -> useState - [`74ca6b2`](https://github.com/actualbudget/actual/commit/74ca6b269205e9e50ee7f56b7ee8eaaf3cbd64a7) Release notes - [`f22cda8`](https://github.com/actualbudget/actual/commit/f22cda84d8ff533c0ae870e0d1415f7ed42985c0) Cleaned up a bit - [`5f05b38`](https://github.com/actualbudget/actual/commit/5f05b3830db387fedf1f3426f3749a00fe3620b2) Payee creation fix - [`90c23c1`](https://github.com/actualbudget/actual/commit/90c23c140697892a85c12f80db958c647af59ddb) remove clearAfterSelect - [`0eef184`](https://github.com/actualbudget/actual/commit/0eef1841a13b776c2462bff508c9af6773724539) Fix e2e - [`96d427c`](https://github.com/actualbudget/actual/commit/96d427c1d953919d6e800feb5cf8c1d8c7baf5b8) Merge branch 'master' into matiss/autocomplete-cleanup - [`52d9a4d`](https://github.com/actualbudget/actual/commit/52d9a4d8eb53fa36b42d7aa22aaa0c334d6a5a1f) Merge branch 'master' into matiss/autocomplete-cleanup - [`a070240`](https://github.com/actualbudget/actual/commit/a070240d189335130f83d8840980f5bedfd8e9bc) Fix e2e by removing rawPayee workarounds ### 📊 Changes **4 files changed** (+322 additions, -447 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/autocomplete/Autocomplete.js` (+271 -391) 📝 `packages/desktop-client/src/components/autocomplete/PayeeAutocomplete.js` (+30 -39) 📝 `packages/desktop-client/src/components/util/GenericInput.js` (+15 -17) ➕ `upcoming-release-notes/931.md` (+6 -0) </details> ### 📄 Description Cleaning up the autocomplete state updates by removing the `updater` and moving to react state hooks. This is mostly a copy&paste, but I also fixed a few small issues and improved things a bit.. apologies for the big PR, but making this smaller would be very tricky. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:41:18 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#3414
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?