github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 20:15:33 -05:00
Code Issues 1.5k Packages Projects Releases 55 Wiki Activity

[PR #1541] [MERGED] 🐛 (darkmode) fix more issues - transaction table and csv imports #34001

New Issue
Closed
opened 2026-04-20 21:14:19 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-20 21:14:19 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/1541
Author: @MatissJanis
Created: 8/18/2023
Status: ✅ Merged
Merged: 8/21/2023
Merged by: @MatissJanis

Base: master ← Head: matiss/checkbox-fix

📝 Commits (7)

  • 4bddd4e 🐛 (darkmode) fix more issues - transaction table and csv imports
  • 63ea150 Release notes
  • a05709a Update packages/desktop-client/src/components/common/View.tsx
  • 83db4b9 Fixes
  • 277d5e5 Make select always visible when selected
  • b422475 Merge branch 'master' into matiss/checkbox-fix
  • c8dc791 Fix: selected state of scheduled transactions

📊 Changes

6 files changed (+29 additions, -15 deletions)

View changed files

📝 packages/desktop-client/src/components/budget/misc.js (+0 -2)
📝 packages/desktop-client/src/components/common/View.tsx (+1 -1)
📝 packages/desktop-client/src/components/modals/ImportTransactions.js (+5 -9)
📝 packages/desktop-client/src/components/table.tsx (+6 -1)
📝 packages/desktop-client/src/components/transactions/TransactionsTable.js (+11 -2)
➕ upcoming-release-notes/1541.md (+6 -0)

📄 Description

Fixing even more darkmode regressions.

  • select boxes in csv import modals were ugly (demo import file: headerless.csv)
  • the select checkbox in transaction table was not visible on hover
  • cleaning up some unnecessary usage of borderColor

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/1541 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 8/18/2023 **Status:** ✅ Merged **Merged:** 8/21/2023 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `matiss/checkbox-fix` --- ### 📝 Commits (7) - [`4bddd4e`](https://github.com/actualbudget/actual/commit/4bddd4e46767bee95b957b8360b5823a68922e18) :bug: (darkmode) fix more issues - transaction table and csv imports - [`63ea150`](https://github.com/actualbudget/actual/commit/63ea150d471fa9e0689b9879d5eeeb765da4c513) Release notes - [`a05709a`](https://github.com/actualbudget/actual/commit/a05709a2395c83419887733626a8f2817d84e3e0) Update packages/desktop-client/src/components/common/View.tsx - [`83db4b9`](https://github.com/actualbudget/actual/commit/83db4b97ea105229d02300fa4e1995e94cad41a3) Fixes - [`277d5e5`](https://github.com/actualbudget/actual/commit/277d5e52910bc0e351071ea2cd18d6d76ea4654f) Make select always visible when selected - [`b422475`](https://github.com/actualbudget/actual/commit/b422475e69f9c4b955b25e3b7f2fc726515518fc) Merge branch 'master' into matiss/checkbox-fix - [`c8dc791`](https://github.com/actualbudget/actual/commit/c8dc791bfefc79ced6dbb08e7bc3694d5c740c58) Fix: selected state of scheduled transactions ### 📊 Changes **6 files changed** (+29 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/budget/misc.js` (+0 -2) 📝 `packages/desktop-client/src/components/common/View.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/modals/ImportTransactions.js` (+5 -9) 📝 `packages/desktop-client/src/components/table.tsx` (+6 -1) 📝 `packages/desktop-client/src/components/transactions/TransactionsTable.js` (+11 -2) ➕ `upcoming-release-notes/1541.md` (+6 -0) </details> ### 📄 Description Fixing even more darkmode regressions. - `select` boxes in csv import modals were ugly (demo import file: [headerless.csv](https://github.com/actualbudget/actual/files/12383953/headerless.csv)) - the select checkbox in transaction table was not visible on hover - cleaning up some unnecessary usage of `borderColor` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 21:14:19 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#34001
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?