github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 15:12:35 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #1287] [MERGED] Add "not" checkbox for string filters #33841

New Issue
Closed
opened 2026-04-20 21:06:51 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-20 21:06:51 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/1287
Author: @carkom
Created: 7/5/2023
Status: ✅ Merged
Merged: 7/20/2023
Merged by: @j-f1

Base: master ← Head: negateFilter

📝 Commits (10+)

📊 Changes

10 files changed (+233 additions, -49 deletions)

View changed files

📝 packages/desktop-client/e2e/page-models/rules-page.js (+1 -1)
📝 packages/desktop-client/src/components/ManageRules.js (+1 -1)
📝 packages/desktop-client/src/components/common/Select.tsx (+44 -11)
📝 packages/desktop-client/src/components/filters/FiltersMenu.js (+58 -18)
📝 packages/desktop-client/src/components/modals/EditRule.js (+18 -4)
📝 packages/loot-core/src/server/accounts/rules.ts (+52 -9)
📝 packages/loot-core/src/server/accounts/transaction-rules.ts (+20 -3)
📝 packages/loot-core/src/server/aql/compiler.ts (+25 -0)
📝 packages/loot-core/src/shared/rules.ts (+8 -2)
➕ upcoming-release-notes/1287.md (+6 -0)

📄 Description

I'm keeping with the filter improvements theme. This is a proof of concept. I'm sure there's some code that could be tidied or more efficient. I also still need to go through and bug check the reports page and the rules modal.

Right now I have the accounts page working. Check it out!

Let me know of any UI tweaks or naming adjustments. Cheers!

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/1287 **Author:** [@carkom](https://github.com/carkom) **Created:** 7/5/2023 **Status:** ✅ Merged **Merged:** 7/20/2023 **Merged by:** [@j-f1](https://github.com/j-f1) **Base:** `master` ← **Head:** `negateFilter` --- ### 📝 Commits (10+) - [`7840fa9`](https://github.com/actualbudget/actual/commit/7840fa99b5ab8e8015cbfe14062174e5a7ee8575) Add "not" checkbox for string filters - [`d9b7acb`](https://github.com/actualbudget/actual/commit/d9b7acb8b94a14c70a06d14f463e1c962b9bd03f) Release Notes - [`c64a350`](https://github.com/actualbudget/actual/commit/c64a3507170fe729c7002610b82d4fd9e8f3bdc8) lint fixes - [`a5022c3`](https://github.com/actualbudget/actual/commit/a5022c3fa3eaac0226b9c01b118223018dc1e464) remove rules.test.ts and fix type errors - [`f74f8ef`](https://github.com/actualbudget/actual/commit/f74f8efa23664be4408f210c21f0847fc548bcac) typecheck fixes - [`8bcc289`](https://github.com/actualbudget/actual/commit/8bcc289f9434e752e79241ee7456ebb7d0264bbd) undelete rules test - [`df97554`](https://github.com/actualbudget/actual/commit/df9755495eaab47a79badcf568c32aed29b457c6) Merge branch 'master' into negateFilter - [`f0b6154`](https://github.com/actualbudget/actual/commit/f0b615493df8df49aa57080a206051db02ac707a) fix rules test - [`08c78c9`](https://github.com/actualbudget/actual/commit/08c78c94d33a46f3328b3a17b832cb86e5146a71) notes - [`0fb0857`](https://github.com/actualbudget/actual/commit/0fb08573455f646594adfb770a4470a008201d1b) rules test lint fix ### 📊 Changes **10 files changed** (+233 additions, -49 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/e2e/page-models/rules-page.js` (+1 -1) 📝 `packages/desktop-client/src/components/ManageRules.js` (+1 -1) 📝 `packages/desktop-client/src/components/common/Select.tsx` (+44 -11) 📝 `packages/desktop-client/src/components/filters/FiltersMenu.js` (+58 -18) 📝 `packages/desktop-client/src/components/modals/EditRule.js` (+18 -4) 📝 `packages/loot-core/src/server/accounts/rules.ts` (+52 -9) 📝 `packages/loot-core/src/server/accounts/transaction-rules.ts` (+20 -3) 📝 `packages/loot-core/src/server/aql/compiler.ts` (+25 -0) 📝 `packages/loot-core/src/shared/rules.ts` (+8 -2) ➕ `upcoming-release-notes/1287.md` (+6 -0) </details> ### 📄 Description I'm keeping with the filter improvements theme. This is a proof of concept. I'm sure there's some code that could be tidied or more efficient. I also still need to go through and bug check the reports page and the rules modal. Right now I have the accounts page working. Check it out! Let me know of any UI tweaks or naming adjustments. Cheers! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 21:06:51 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#33841
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?