github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 07:01:45 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #1270] [MERGED] Remove page-based modals in favor of existing state-based modal logic #33832

New Issue
Closed
opened 2026-04-20 21:06:27 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-20 21:06:27 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/1270
Author: @j-f1
Created: 7/3/2023
Status: ✅ Merged
Merged: 8/9/2023
Merged by: @trevdor

Base: master ← Head: jed/no-url-modals

📝 Commits (10+)

  • 8397b19 Remove page-based modals in favor of existing state-based modal logic
  • e784b97 Remove unnecessary StackedRoutesInner
  • fba0a88 Fix build issues
  • 092ad59 More fixing
  • b9939b4 Fix closing modals
  • 2595591 Fix lint error
  • 29e60e6 Add release note
  • c4f283c Remove unused initialFields option on DiscoverSchedules
  • d263f97 fix another lint error
  • 1992cde Default modal options to {}

📊 Changes

22 files changed (+206 additions, -351 deletions)

View changed files

➖ packages/desktop-client/src/components/ActiveLocation.js (+0 -13)
📝 packages/desktop-client/src/components/FinancesApp.tsx (+71 -119)
📝 packages/desktop-client/src/components/Modals.tsx (+42 -0)
📝 packages/desktop-client/src/components/Page.tsx (+9 -43)
📝 packages/desktop-client/src/components/accounts/Account.js (+5 -7)
📝 packages/desktop-client/src/components/accounts/Header.js (+2 -0)
📝 packages/desktop-client/src/components/accounts/MobileAccountDetails.js (+2 -0)
📝 packages/desktop-client/src/components/manager/Modals.js (+1 -1)
📝 packages/desktop-client/src/components/responsive/wide.ts (+0 -3)
📝 packages/desktop-client/src/components/schedules/DiscoverSchedules.js (+12 -19)
📝 packages/desktop-client/src/components/schedules/EditSchedule.js (+17 -35)
📝 packages/desktop-client/src/components/schedules/LinkSchedule.js (+9 -10)
📝 packages/desktop-client/src/components/schedules/PostsOfflineNotification.js (+7 -12)
📝 packages/desktop-client/src/components/schedules/index.js (+5 -6)
📝 packages/desktop-client/src/components/transactions/SelectedTransactions.js (+3 -4)
📝 packages/desktop-client/src/components/transactions/TransactionList.js (+2 -3)
📝 packages/desktop-client/src/global-events.js (+1 -4)
📝 packages/desktop-client/src/util/router-tools.tsx (+3 -68)
📝 packages/desktop-electron/menu.js (+1 -1)
📝 packages/loot-core/src/client/state-types/modals.d.ts (+8 -0)

...and 2 more files

📄 Description

Fixes #1264

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/1270 **Author:** [@j-f1](https://github.com/j-f1) **Created:** 7/3/2023 **Status:** ✅ Merged **Merged:** 8/9/2023 **Merged by:** [@trevdor](https://github.com/trevdor) **Base:** `master` ← **Head:** `jed/no-url-modals` --- ### 📝 Commits (10+) - [`8397b19`](https://github.com/actualbudget/actual/commit/8397b19e9d9800192a3f7aa3059e99bac98f3b80) Remove page-based modals in favor of existing state-based modal logic - [`e784b97`](https://github.com/actualbudget/actual/commit/e784b97e8be502b5df698a06016e44364bd2eba8) Remove unnecessary StackedRoutesInner - [`fba0a88`](https://github.com/actualbudget/actual/commit/fba0a881587bdbfe4d0cc54e56f6d0dd2346c269) Fix build issues - [`092ad59`](https://github.com/actualbudget/actual/commit/092ad5942b1c4d337e629fc4aec6235722978dea) More fixing - [`b9939b4`](https://github.com/actualbudget/actual/commit/b9939b413ea08e0aaee881e226337c1aca0919af) Fix closing modals - [`2595591`](https://github.com/actualbudget/actual/commit/2595591c0ef138504672b99697a8a0261584c9e6) Fix lint error - [`29e60e6`](https://github.com/actualbudget/actual/commit/29e60e6d40c955b0eca2b62a988849229fb2ab73) Add release note - [`c4f283c`](https://github.com/actualbudget/actual/commit/c4f283c267d5546fbad37f1037828a8964d6b7d5) Remove unused initialFields option on DiscoverSchedules - [`d263f97`](https://github.com/actualbudget/actual/commit/d263f9777d437130f2553fde7104288f3ea0f644) fix another lint error - [`1992cde`](https://github.com/actualbudget/actual/commit/1992cde8d5326d1449857cfe72f32aff3567adf7) Default modal options to {} ### 📊 Changes **22 files changed** (+206 additions, -351 deletions) <details> <summary>View changed files</summary> ➖ `packages/desktop-client/src/components/ActiveLocation.js` (+0 -13) 📝 `packages/desktop-client/src/components/FinancesApp.tsx` (+71 -119) 📝 `packages/desktop-client/src/components/Modals.tsx` (+42 -0) 📝 `packages/desktop-client/src/components/Page.tsx` (+9 -43) 📝 `packages/desktop-client/src/components/accounts/Account.js` (+5 -7) 📝 `packages/desktop-client/src/components/accounts/Header.js` (+2 -0) 📝 `packages/desktop-client/src/components/accounts/MobileAccountDetails.js` (+2 -0) 📝 `packages/desktop-client/src/components/manager/Modals.js` (+1 -1) 📝 `packages/desktop-client/src/components/responsive/wide.ts` (+0 -3) 📝 `packages/desktop-client/src/components/schedules/DiscoverSchedules.js` (+12 -19) 📝 `packages/desktop-client/src/components/schedules/EditSchedule.js` (+17 -35) 📝 `packages/desktop-client/src/components/schedules/LinkSchedule.js` (+9 -10) 📝 `packages/desktop-client/src/components/schedules/PostsOfflineNotification.js` (+7 -12) 📝 `packages/desktop-client/src/components/schedules/index.js` (+5 -6) 📝 `packages/desktop-client/src/components/transactions/SelectedTransactions.js` (+3 -4) 📝 `packages/desktop-client/src/components/transactions/TransactionList.js` (+2 -3) 📝 `packages/desktop-client/src/global-events.js` (+1 -4) 📝 `packages/desktop-client/src/util/router-tools.tsx` (+3 -68) 📝 `packages/desktop-electron/menu.js` (+1 -1) 📝 `packages/loot-core/src/client/state-types/modals.d.ts` (+8 -0) _...and 2 more files_ </details> ### 📄 Description Fixes #1264 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 21:06:27 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#33832
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?