github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 07:01:45 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[Bug]: Switching a rule condition from “payee is” to “imported payee is” clears its value #337

New Issue
Closed
opened 2026-02-28 18:59:51 -06:00 by GiteaMirror · 3 comments
GiteaMirror commented 2026-02-28 18:59:51 -06:00
Owner
Copy Link

Originally created by @j-f1 on GitHub (Apr 7, 2023).

Verified issue does not already exist?

  • I have searched and found no existing issue

What happened?

  1. Select a payee in the payees list with no rule. Click “Create rule.”
  2. Change the condition from “payee is” to “imported payee is”

Expected behavior: the value field is filled with the name of the payee
Actual behavior: it is cleared

What error did you receive?

No response

Where are you hosting Actual?

Docker

What browsers are you seeing the problem on?

Safari

Operating System

Mac OSX

Originally created by @j-f1 on GitHub (Apr 7, 2023). ### Verified issue does not already exist? - [X] I have searched and found no existing issue ### What happened? 1. Select a payee in the payees list with no rule. Click “Create rule.” 2. Change the condition from “payee is” to “imported payee is” Expected behavior: the value field is filled with the name of the payee Actual behavior: it is cleared ### What error did you receive? _No response_ ### Where are you hosting Actual? Docker ### What browsers are you seeing the problem on? Safari ### Operating System Mac OSX
GiteaMirror added the buggood first issue labels 2026-02-28 18:59:51 -06:00
GiteaMirror commented 2026-02-28 18:59:52 -06:00
Author
Owner
Copy Link

@MatissJanis commented on GitHub (Apr 28, 2023):

I'm torn on this one. Practically imported_payee is different from payee. For example:

imported_payee: CRV*Starbucks Dublin Docks
payee: Starbucks

But from another perspective.. they are very related fields.

Maybe we keep this as-is? That makes the logic simpler to reason about. Switching from ANY field to ANY OTHER field just clears the value. With no exceptions.

@MatissJanis commented on GitHub (Apr 28, 2023): I'm torn on this one. Practically `imported_payee` is different from `payee`. For example: ``` imported_payee: CRV*Starbucks Dublin Docks payee: Starbucks ``` But from another perspective.. they are very related fields. Maybe we keep this as-is? That makes the logic simpler to reason about. Switching from ANY field to ANY OTHER field just clears the value. With no exceptions.
GiteaMirror commented 2026-02-28 18:59:53 -06:00
Author
Owner
Copy Link

@aaroneiche commented on GitHub (May 7, 2023):

In this case, I think the experience for the user is degraded when this happens. They approached the "create rule" interface from payees, rather than just starting with a blank rule. I'm kind of inclined to say that the field should not be cleared regardless of changing the key. Kind of...

@aaroneiche commented on GitHub (May 7, 2023): In this case, I think the experience for the user is degraded when this happens. They approached the "create rule" interface from payees, rather than just starting with a blank rule. I'm kind of inclined to say that the field should not be cleared regardless of changing the key. Kind of...
GiteaMirror commented 2026-02-28 18:59:54 -06:00
Author
Owner
Copy Link

@youngcw commented on GitHub (Feb 4, 2024):

I don't think there is a way to gracefully transition from payee to imported payee when changing the rule condition. Seems like, at best, it would only give a sometimes right imported payee and, at worst, be a useless rule that never triggers.

@MatissJanis I think this should be closed, what do you think?

@youngcw commented on GitHub (Feb 4, 2024): I don't think there is a way to gracefully transition from payee to imported payee when changing the rule condition. Seems like, at best, it would only give a sometimes right imported payee and, at worst, be a useless rule that never triggers. @MatissJanis I think this should be closed, what do you think?
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label bug good first issue
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#337
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?