github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 15:12:35 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #815] [CLOSED] #814 Update transfer add and remove logic for better behaviours #3346

New Issue
Closed
opened 2026-02-28 20:40:15 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:40:15 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/815
Author: @winklevos
Created: 3/26/2023
Status: ❌ Closed

Base: master ← Head: transfer-deletions

📝 Commits (10+)

📊 Changes

2 files changed (+54 additions, -14 deletions)

View changed files

📝 packages/loot-core/src/server/accounts/transfer.js (+48 -14)
➕ upcoming-release-notes/815.md (+6 -0)

📄 Description

  • Updating deleting logic for transactions related by transfer. This aims to ensure transactions are not deleted across accounts when the transfer is cleared in another account. Reverts linked transaction to imported_payee if not null
    https://github.com/actualbudget/actual/issues/814

  • Update transfer add logic to match existing transaction in target account if amount and date exactly match.

  • Update the updating logic of transfer transactions to not update date and note to preserve on the linked account
    https://github.com/actualbudget/actual/issues/661

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/815 **Author:** [@winklevos](https://github.com/winklevos) **Created:** 3/26/2023 **Status:** ❌ Closed **Base:** `master` ← **Head:** `transfer-deletions` --- ### 📝 Commits (10+) - [`1caf03f`](https://github.com/actualbudget/actual/commit/1caf03f35e7c626d5c727f66b0a91f9105a2a724) update transfer remove logic to preserve if clear - [`1b4b9d3`](https://github.com/actualbudget/actual/commit/1b4b9d377b6e35ed3e5fb01aeadc01d2f82418f8) add changelog - [`e854efc`](https://github.com/actualbudget/actual/commit/e854efc5819939274bb0ffaf205f797774405aec) Merge branch 'master' of https://github.com/winklevos/actual into transfer-deletions - [`1881b5d`](https://github.com/actualbudget/actual/commit/1881b5de6d2351e9c56a3e20a6493a675701a185) update id reference to be clearer - [`8c074a7`](https://github.com/actualbudget/actual/commit/8c074a7ebabf5a8324ad3a04868032789f685af4) remove extra comments - [`dcd403b`](https://github.com/actualbudget/actual/commit/dcd403bc0417df9ca4de9b87a7e666c12a4c09d7) remove whitespace - [`3e881a0`](https://github.com/actualbudget/actual/commit/3e881a00470cfd36940523c58ecc89966debf581) update transaction add logic and payee - [`14849ee`](https://github.com/actualbudget/actual/commit/14849eea6af4ad67a97db071a1819ab1a330c90d) fix changelog - [`20dbfdb`](https://github.com/actualbudget/actual/commit/20dbfdb590a8a6eea5f2431d5b622ddcd95fb47e) update release notes - [`282b0e0`](https://github.com/actualbudget/actual/commit/282b0e07b232e2189b438299461b316ed73d1fee) change update logic to preserve date and notes ### 📊 Changes **2 files changed** (+54 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `packages/loot-core/src/server/accounts/transfer.js` (+48 -14) ➕ `upcoming-release-notes/815.md` (+6 -0) </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes --> - Updating deleting logic for transactions related by transfer. This aims to ensure transactions are not deleted across accounts when the transfer is cleared in another account. Reverts linked transaction to imported_payee if not null https://github.com/actualbudget/actual/issues/814 - Update transfer add logic to match existing transaction in target account if `amount` and `date` exactly match. - Update the updating logic of transfer transactions to not update `date` and `note` to preserve on the linked account https://github.com/actualbudget/actual/issues/661 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:40:15 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#3346
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?