github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 19:52:56 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #799] [MERGED] Improve visual consistency on the settings page #3337

New Issue
Closed
opened 2026-02-28 20:40:07 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:40:07 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/799
Author: @j-f1
Created: 3/21/2023
Status: ✅ Merged
Merged: 3/21/2023
Merged by: @j-f1

Base: master ← Head: jed/more-settings-updates

📝 Commits (10+)

  • 224cc77 Update About to use
  • a294b1f Port budget name to be a too,
  • b019575 Inline final usage of
  • 835fb15 don’t like for budget name
  • 6f71b27 Fix global prefs
  • f30f480 Update styling of About section to reflect outdated version indicator
  • 3019694 Update index.js
  • 3e4c2bd Hide budget name setting on desktop
  • 9aa4c1b Add a settings button to the budget menu
  • 7153c83 Update advanced section to use Setting styling

📊 Changes

7 files changed (+156 additions, -138 deletions)

View changed files

📝 packages/desktop-client/src/components/SidebarWithData.js (+3 -2)
📝 packages/desktop-client/src/components/settings/Experimental.js (+4 -4)
📝 packages/desktop-client/src/components/settings/FixSplits.js (+16 -20)
📝 packages/desktop-client/src/components/settings/Global.js (+32 -43)
📝 packages/desktop-client/src/components/settings/UI.js (+18 -33)
📝 packages/desktop-client/src/components/settings/index.js (+77 -36)
➕ upcoming-release-notes/799.md (+6 -0)

📄 Description

This PR improves the consistency of the settings UI by moving everything (except the budget name field on mobile) into <Setting> boxes. Additionally, it adds a “Settings” option to the file dropdown menu (I keep expecting it to be there, and I think it’s reasonable to expose it in both locations so it’s easier to access)

Screenshot_2023-03-21 14 14 18 Screenshot_2023-03-21 14 14 27

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/799 **Author:** [@j-f1](https://github.com/j-f1) **Created:** 3/21/2023 **Status:** ✅ Merged **Merged:** 3/21/2023 **Merged by:** [@j-f1](https://github.com/j-f1) **Base:** `master` ← **Head:** `jed/more-settings-updates` --- ### 📝 Commits (10+) - [`224cc77`](https://github.com/actualbudget/actual/commit/224cc7728de4f9a21644b0d6241d319244780750) Update About to use <Setting> - [`a294b1f`](https://github.com/actualbudget/actual/commit/a294b1faa553fee1f2f2b26c78e415f2e85ba64f) Port budget name to be a <Setting> too, - [`b019575`](https://github.com/actualbudget/actual/commit/b019575912b453d2e297ac6883d79b895aa845d4) Inline final usage of <Section> - [`835fb15`](https://github.com/actualbudget/actual/commit/835fb1516a86e0e0d7c95174839466a1583ad8a9) don’t like <Setting> for budget name - [`6f71b27`](https://github.com/actualbudget/actual/commit/6f71b2705c5601901af343092746cfaa3a2b2d44) Fix global prefs - [`f30f480`](https://github.com/actualbudget/actual/commit/f30f4809625c7bef18798d2ce5532d95ebd636f3) Update styling of About section to reflect outdated version indicator - [`3019694`](https://github.com/actualbudget/actual/commit/30196946305a9c7c48a91440ab3c5e937048d8e5) Update index.js - [`3e4c2bd`](https://github.com/actualbudget/actual/commit/3e4c2bdfbe9dc8d9db3f4d7191fa1bd9d74adcd1) Hide budget name setting on desktop - [`9aa4c1b`](https://github.com/actualbudget/actual/commit/9aa4c1b1b91d9ad32621769520f341f0ee39b2e4) Add a settings button to the budget menu - [`7153c83`](https://github.com/actualbudget/actual/commit/7153c837b06de19ee10dc568f272bea3b5607793) Update advanced section to use Setting styling ### 📊 Changes **7 files changed** (+156 additions, -138 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/SidebarWithData.js` (+3 -2) 📝 `packages/desktop-client/src/components/settings/Experimental.js` (+4 -4) 📝 `packages/desktop-client/src/components/settings/FixSplits.js` (+16 -20) 📝 `packages/desktop-client/src/components/settings/Global.js` (+32 -43) 📝 `packages/desktop-client/src/components/settings/UI.js` (+18 -33) 📝 `packages/desktop-client/src/components/settings/index.js` (+77 -36) ➕ `upcoming-release-notes/799.md` (+6 -0) </details> ### 📄 Description This PR improves the consistency of the settings UI by moving everything (except the budget name field on mobile) into `<Setting>` boxes. Additionally, it adds a “Settings” option to the file dropdown menu (I keep expecting it to be there, and I think it’s reasonable to expose it in both locations so it’s easier to access) <img width="557" alt="Screenshot_2023-03-21 14 14 18" src="https://user-images.githubusercontent.com/25517624/226705081-a2f0caa3-75f7-4e1a-abb6-25ca17724eae.png"> <img width="557" alt="Screenshot_2023-03-21 14 14 27" src="https://user-images.githubusercontent.com/25517624/226705087-55e7bae2-c1a4-476d-a21c-77f2467e7cb3.png"> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:40:07 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#3337
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?