github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-22 20:40:08 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #797] [MERGED] Re-enable goal templates by passing flag values to the budget summary component #3336

New Issue
Closed
opened 2026-02-28 20:40:06 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:40:06 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/797
Author: @modrzew
Created: 3/21/2023
Status: ✅ Merged
Merged: 3/21/2023
Merged by: @j-f1

Base: master ← Head: modrzew-pass-flags-to-budget-summary

📝 Commits (3)

  • 43b6ae2 Pass feature flags to BudgetSummary
  • 9c4b481 extract to separate named component and use memo
  • 8411008 add changelog file

📊 Changes

2 files changed (+20 additions, -1 deletions)

View changed files

📝 packages/desktop-client/src/components/budget/index.js (+14 -1)
➕ upcoming-release-notes/797.md (+6 -0)

📄 Description

#786 changed the way feature flags are used in components. While refactoring, the BudgetSummary component was refactored to get the value of the goalTemplatesEnabled flag from props rather than Redux store, but the value of the flag was never passed down to it. Side effect of that was accidentally disabling goal templates, as the flag value was always undefined.

This PR fixes that — the flag value is now passed in so that the goal complete feature can now be correctly enabled. (And the value of the newAutocomplete flag is passed down to the ToBudget component as well.)

Before: ☹️

Screenshot 2023-03-21 at 22 30 05

After: 😄

Screenshot 2023-03-21 at 22 30 21

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/797 **Author:** [@modrzew](https://github.com/modrzew) **Created:** 3/21/2023 **Status:** ✅ Merged **Merged:** 3/21/2023 **Merged by:** [@j-f1](https://github.com/j-f1) **Base:** `master` ← **Head:** `modrzew-pass-flags-to-budget-summary` --- ### 📝 Commits (3) - [`43b6ae2`](https://github.com/actualbudget/actual/commit/43b6ae23282f9bfce38ea85c3fa48dbce9533c60) Pass feature flags to BudgetSummary - [`9c4b481`](https://github.com/actualbudget/actual/commit/9c4b4811c61942762a5b8978d50a853f5edca1c6) extract to separate named component and use memo - [`8411008`](https://github.com/actualbudget/actual/commit/84110089e646a641c661cd8c3fad17b339e05734) add changelog file ### 📊 Changes **2 files changed** (+20 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/budget/index.js` (+14 -1) ➕ `upcoming-release-notes/797.md` (+6 -0) </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes --> #786 changed the way feature flags are used in components. While refactoring, the `BudgetSummary` component was refactored to get the value of the `goalTemplatesEnabled` flag from props rather than Redux store, but the value of the flag was never passed down to it. Side effect of that was accidentally disabling goal templates, as the flag value was always `undefined`. This PR fixes that — the flag value is now passed in so that the goal complete feature can now be correctly enabled. (And the value of the `newAutocomplete` flag is passed down to the `ToBudget` component as well.) ### Before: ☹️ <img width="225" alt="Screenshot 2023-03-21 at 22 30 05" src="https://user-images.githubusercontent.com/2963462/226594392-fe6a7866-ee0a-4f91-9a64-5bb8b15db1d9.png"> ### After: 😄 <img width="217" alt="Screenshot 2023-03-21 at 22 30 21" src="https://user-images.githubusercontent.com/2963462/226594407-8299bfc1-fbb3-4f7e-805b-20ba8055b885.png"> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:40:06 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#3336
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?