github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-11-14 21:15:41 -06:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[PR #421] [MERGED] chore: remove unused variables #33316

New Issue
Closed
opened 2026-04-20 20:42:26 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-20 20:42:26 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/421
Author: @MatissJanis
Created: 1/2/2023
Status: ✅ Merged
Merged: 1/3/2023
Merged by: @MatissJanis

Base: master ← Head: matiss/unused-variables

📝 Commits (8)

  • 77795c6 chore: remove unused variables
  • ec1aeef chore: fix some more no-unused-vars issues
  • b5d34b9 undo: TransactionsTable.test.js
  • b3ebff7 Allow underscore
  • 4236b32 prune: remove scrolling code
  • 3110cab prune: remove more scrollTo code
  • 1377bce prune: useEffect import
  • a50494d Merge branch 'master' into matiss/unused-variables

📊 Changes

30 files changed (+28 additions, -192 deletions)

View changed files

📝 packages/desktop-client/src/components/AnimatedRefresh.js (+0 -5)
📝 packages/desktop-client/src/components/App.js (+3 -4)
📝 packages/desktop-client/src/components/FinancesApp.js (+0 -24)
📝 packages/desktop-client/src/components/ManageRules.js (+1 -9)
📝 packages/desktop-client/src/components/Notifications.js (+0 -1)
📝 packages/desktop-client/src/components/Settings.js (+3 -7)
📝 packages/desktop-client/src/components/accounts/Account.js (+0 -9)
📝 packages/desktop-client/src/components/accounts/SimpleTransactionsTable.js (+0 -1)
📝 packages/desktop-client/src/components/accounts/TransactionList.js (+1 -21)
📝 packages/desktop-client/src/components/accounts/TransactionsTable.js (+0 -5)
📝 packages/desktop-client/src/components/accounts/TransactionsTable.test.js (+3 -24)
📝 packages/desktop-client/src/components/budget/MonthCountSelector.js (+0 -3)
📝 packages/desktop-client/src/components/budget/index.js (+0 -3)
📝 packages/desktop-client/src/components/debug/index.js (+6 -6)
📝 packages/desktop-client/src/components/manager/subscribe/Bootstrap.js (+0 -2)
📝 packages/desktop-client/src/components/manager/subscribe/ChangePassword.js (+0 -2)
📝 packages/desktop-client/src/components/manager/subscribe/Login.js (+0 -2)
📝 packages/desktop-client/src/components/modals/ConfirmCategoryDelete.js (+1 -1)
📝 packages/desktop-client/src/components/modals/CreateEncryptionKey.js (+0 -1)
📝 packages/desktop-client/src/components/modals/EditRule.js (+1 -1)

...and 10 more files

📄 Description

Maintaining code is expensive. Lets reduce the scope by removing unused variables, functions, imports, etc.

./src/components/AnimatedRefresh.js
src/components/AnimatedRefresh.js
  Line 13:5:  'spinStop' is assigned a value but never used  no-unused-vars

./src/components/App.js
src/components/App.js
  Line 43:9:   'globalPrefs' is assigned a value but never used      no-unused-vars
  Line 91:36:  'showingTutorial' is assigned a value but never used  no-unused-vars

./src/components/FinancesApp.js
src/components/FinancesApp.js
  Line 43:10:  'URLBar' is defined but never used  no-unused-vars

./src/components/ManageRules.js
src/components/ManageRules.js
  Line 17:3:    'extractScheduleConds' is defined but never used  no-unused-vars
  Line 24:3:    'Modal' is defined but never used                 no-unused-vars
  Line 46:10:   'Page' is defined but never used                  no-unused-vars
  Line 297:9:   'dispatch' is assigned a value but never used     no-unused-vars
  Line 583:17:  'oldIdx' is assigned a value but never used       no-unused-vars

./src/components/Notifications.js
src/components/Notifications.js
  Line 30:22:  '_' is assigned a value but never used   no-unused-vars
  Line 69:5:   'id' is assigned a value but never used  no-unused-vars

./src/components/Settings.js
src/components/Settings.js
  Line 3:10:    'Route' is defined but never used                    no-unused-vars
  Line 3:17:    'Switch' is defined but never used                   no-unused-vars
  Line 3:25:    'Redirect' is defined but never used                 no-unused-vars
  Line 18:3:    'AnchorLink' is defined but never used               no-unused-vars
  Line 20:10:   'styles' is defined but never used                   no-unused-vars
  Line 21:8:    'ExpandArrow' is defined but never used              no-unused-vars
  Line 355:31:  'localServerURL' is assigned a value but never used  no-unused-vars
  Line 355:57:  'match' is assigned a value but never used           no-unused-vars

./src/components/accounts/Account.js
src/components/accounts/Account.js
  Line 492:12:   'getRealTransactions' is defined but never used        no-unused-vars
  Line 585:17:   'field' is assigned a value but never used             no-unused-vars
  Line 1104:11:  'transactions' is assigned a value but never used      no-unused-vars
  Line 1628:7:   'match' is assigned a value but never used             no-unused-vars
  Line 1635:7:   'expandSplits' is assigned a value but never used      no-unused-vars
  Line 1643:7:   'transactionCount' is assigned a value but never used  no-unused-vars

./src/components/accounts/SimpleTransactionsTable.js
src/components/accounts/SimpleTransactionsTable.js
  Line 57:7:  'schedule' is assigned a value but never used  no-unused-vars

./src/components/accounts/TransactionList.js
src/components/accounts/TransactionList.js
  Line 17:7:  'uuid' is assigned a value but never used      no-unused-vars
  Line 84:7:  'dispatch' is assigned a value but never used  no-unused-vars
  Line 85:7:  'table' is assigned a value but never used     no-unused-vars

./src/components/accounts/TransactionsTable.js
src/components/accounts/TransactionsTable.js
  Line 71:5:    'TABLE_BACKGROUND_COLOR' is assigned a value but never used  no-unused-vars
  Line 135:7:   'parent' is defined but never used                           no-unused-vars
  Line 482:7:   'Icon' is assigned a value but never used                    no-unused-vars
  Line 1517:7:  'dispatchSelected' is assigned a value but never used        no-unused-vars

./src/components/budget/MonthCountSelector.js
src/components/budget/MonthCountSelector.js
  Line 20:7:  'style' is assigned a value but never used        no-unused-vars
  Line 21:7:  'activeStyle' is assigned a value but never used  no-unused-vars

./src/components/budget/index.js
src/components/budget/index.js
  Line 323:11:  'after' is assigned a value but never used   no-unused-vars
  Line 324:11:  'before' is assigned a value but never used  no-unused-vars

./src/components/manager/subscribe/Bootstrap.js
src/components/manager/subscribe/Bootstrap.js
  Line 16:7:  'history' is assigned a value but never used  no-unused-vars

./src/components/manager/subscribe/ChangePassword.js
src/components/manager/subscribe/ChangePassword.js
  Line 13:7:  'dispatch' is assigned a value but never used  no-unused-vars

./src/components/manager/subscribe/Login.js
src/components/manager/subscribe/Login.js
  Line 20:7:  'history' is assigned a value but never used  no-unused-vars

./src/components/modals/ConfirmCategoryDelete.js
src/components/modals/ConfirmCategoryDelete.js
  Line 25:11:  'category' is assigned a value but never used  no-unused-vars
  Line 25:21:  'group' is assigned a value but never used     no-unused-vars

./src/components/modals/CreateEncryptionKey.js
src/components/modals/CreateEncryptionKey.js
  Line 26:8:   'enabling' is assigned a value but never used     no-unused-vars
  Line 26:18:  'setEnabling' is assigned a value but never used  no-unused-vars

./src/components/modals/EditRule.js
src/components/modals/EditRule.js
  Line 179:49:  'inputKey' is assigned a value but never used  no-unused-vars

./src/components/payees/ManagePayeesWithData.js
src/components/payees/ManagePayeesWithData.js
  Line 6:13:  'undo' is defined but never used  no-unused-vars

./src/components/reports/CashFlow.js
src/components/reports/CashFlow.js
  Line 25:10:  'earliestMonth' is assigned a value but never used  no-unused-vars
  Line 87:22:  'balance' is assigned a value but never used        no-unused-vars
  Line 87:31:  'totalChange' is assigned a value but never used    no-unused-vars

./src/components/reports/NetWorth.js
src/components/reports/NetWorth.js
  Line 22:10:  'earliestMonth' is assigned a value but never used  no-unused-vars

./src/components/schedules/DiscoverSchedules.js
src/components/schedules/DiscoverSchedules.js
  Line 2:10:   'useLocation' is defined but never used     no-unused-vars
  Line 4:8:    'Platform' is defined but never used        no-unused-vars
  Line 11:3:   'Button' is defined but never used          no-unused-vars
  Line 136:9:  'items' is assigned a value but never used  no-unused-vars

./src/components/schedules/EditSchedule.js
src/components/schedules/EditSchedule.js
  Line 95:7:    'pageType' is assigned a value but never used  no-unused-vars
  Line 254:11:  'dates' is assigned a value but never used     no-unused-vars
  Line 300:13:  'error' is assigned a value but never used     no-unused-vars

./src/components/schedules/LinkSchedule.js
src/components/schedules/LinkSchedule.js
  Line 18:7:  'dateFormat' is assigned a value but never used  no-unused-vars

./src/global-events.js
src/global-events.js
  Line 48:18:  'onManage' is defined but never used           no-unused-vars
  Line 85:11:  'messages' is assigned a value but never used  no-unused-vars

./src/index.js
src/index.js
  Line 40:10:  'log' is defined but never used  no-unused-vars

./src/plaid.js
src/plaid.js
  Line 38:9:  'error' is assigned a value but never used  no-unused-vars

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/421 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 1/2/2023 **Status:** ✅ Merged **Merged:** 1/3/2023 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `matiss/unused-variables` --- ### 📝 Commits (8) - [`77795c6`](https://github.com/actualbudget/actual/commit/77795c63e3716519613efc747a098d854136b5e7) chore: remove unused variables - [`ec1aeef`](https://github.com/actualbudget/actual/commit/ec1aeef49132ae07833df93a7d396cbbef7db165) chore: fix some more no-unused-vars issues - [`b5d34b9`](https://github.com/actualbudget/actual/commit/b5d34b9d11082d4b1d1afb63623966935ef77fbc) undo: TransactionsTable.test.js - [`b3ebff7`](https://github.com/actualbudget/actual/commit/b3ebff7b59e3f0fe1981791b83d6a08dab3b8a3a) Allow underscore - [`4236b32`](https://github.com/actualbudget/actual/commit/4236b3217dc4c18507b198c2532f90e8100f98b4) prune: remove scrolling code - [`3110cab`](https://github.com/actualbudget/actual/commit/3110cab06b37ce3728a7a8ab3c6adb768d4affe9) prune: remove more scrollTo code - [`1377bce`](https://github.com/actualbudget/actual/commit/1377bce501f717c6da161d8068403850e0e4f514) prune: useEffect import - [`a50494d`](https://github.com/actualbudget/actual/commit/a50494d0cd405b7125fab56516ea40509cd7c0d9) Merge branch 'master' into matiss/unused-variables ### 📊 Changes **30 files changed** (+28 additions, -192 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/AnimatedRefresh.js` (+0 -5) 📝 `packages/desktop-client/src/components/App.js` (+3 -4) 📝 `packages/desktop-client/src/components/FinancesApp.js` (+0 -24) 📝 `packages/desktop-client/src/components/ManageRules.js` (+1 -9) 📝 `packages/desktop-client/src/components/Notifications.js` (+0 -1) 📝 `packages/desktop-client/src/components/Settings.js` (+3 -7) 📝 `packages/desktop-client/src/components/accounts/Account.js` (+0 -9) 📝 `packages/desktop-client/src/components/accounts/SimpleTransactionsTable.js` (+0 -1) 📝 `packages/desktop-client/src/components/accounts/TransactionList.js` (+1 -21) 📝 `packages/desktop-client/src/components/accounts/TransactionsTable.js` (+0 -5) 📝 `packages/desktop-client/src/components/accounts/TransactionsTable.test.js` (+3 -24) 📝 `packages/desktop-client/src/components/budget/MonthCountSelector.js` (+0 -3) 📝 `packages/desktop-client/src/components/budget/index.js` (+0 -3) 📝 `packages/desktop-client/src/components/debug/index.js` (+6 -6) 📝 `packages/desktop-client/src/components/manager/subscribe/Bootstrap.js` (+0 -2) 📝 `packages/desktop-client/src/components/manager/subscribe/ChangePassword.js` (+0 -2) 📝 `packages/desktop-client/src/components/manager/subscribe/Login.js` (+0 -2) 📝 `packages/desktop-client/src/components/modals/ConfirmCategoryDelete.js` (+1 -1) 📝 `packages/desktop-client/src/components/modals/CreateEncryptionKey.js` (+0 -1) 📝 `packages/desktop-client/src/components/modals/EditRule.js` (+1 -1) _...and 10 more files_ </details> ### 📄 Description Maintaining code is expensive. Lets reduce the scope by removing unused variables, functions, imports, etc. ``` ./src/components/AnimatedRefresh.js src/components/AnimatedRefresh.js Line 13:5: 'spinStop' is assigned a value but never used no-unused-vars ./src/components/App.js src/components/App.js Line 43:9: 'globalPrefs' is assigned a value but never used no-unused-vars Line 91:36: 'showingTutorial' is assigned a value but never used no-unused-vars ./src/components/FinancesApp.js src/components/FinancesApp.js Line 43:10: 'URLBar' is defined but never used no-unused-vars ./src/components/ManageRules.js src/components/ManageRules.js Line 17:3: 'extractScheduleConds' is defined but never used no-unused-vars Line 24:3: 'Modal' is defined but never used no-unused-vars Line 46:10: 'Page' is defined but never used no-unused-vars Line 297:9: 'dispatch' is assigned a value but never used no-unused-vars Line 583:17: 'oldIdx' is assigned a value but never used no-unused-vars ./src/components/Notifications.js src/components/Notifications.js Line 30:22: '_' is assigned a value but never used no-unused-vars Line 69:5: 'id' is assigned a value but never used no-unused-vars ./src/components/Settings.js src/components/Settings.js Line 3:10: 'Route' is defined but never used no-unused-vars Line 3:17: 'Switch' is defined but never used no-unused-vars Line 3:25: 'Redirect' is defined but never used no-unused-vars Line 18:3: 'AnchorLink' is defined but never used no-unused-vars Line 20:10: 'styles' is defined but never used no-unused-vars Line 21:8: 'ExpandArrow' is defined but never used no-unused-vars Line 355:31: 'localServerURL' is assigned a value but never used no-unused-vars Line 355:57: 'match' is assigned a value but never used no-unused-vars ./src/components/accounts/Account.js src/components/accounts/Account.js Line 492:12: 'getRealTransactions' is defined but never used no-unused-vars Line 585:17: 'field' is assigned a value but never used no-unused-vars Line 1104:11: 'transactions' is assigned a value but never used no-unused-vars Line 1628:7: 'match' is assigned a value but never used no-unused-vars Line 1635:7: 'expandSplits' is assigned a value but never used no-unused-vars Line 1643:7: 'transactionCount' is assigned a value but never used no-unused-vars ./src/components/accounts/SimpleTransactionsTable.js src/components/accounts/SimpleTransactionsTable.js Line 57:7: 'schedule' is assigned a value but never used no-unused-vars ./src/components/accounts/TransactionList.js src/components/accounts/TransactionList.js Line 17:7: 'uuid' is assigned a value but never used no-unused-vars Line 84:7: 'dispatch' is assigned a value but never used no-unused-vars Line 85:7: 'table' is assigned a value but never used no-unused-vars ./src/components/accounts/TransactionsTable.js src/components/accounts/TransactionsTable.js Line 71:5: 'TABLE_BACKGROUND_COLOR' is assigned a value but never used no-unused-vars Line 135:7: 'parent' is defined but never used no-unused-vars Line 482:7: 'Icon' is assigned a value but never used no-unused-vars Line 1517:7: 'dispatchSelected' is assigned a value but never used no-unused-vars ./src/components/budget/MonthCountSelector.js src/components/budget/MonthCountSelector.js Line 20:7: 'style' is assigned a value but never used no-unused-vars Line 21:7: 'activeStyle' is assigned a value but never used no-unused-vars ./src/components/budget/index.js src/components/budget/index.js Line 323:11: 'after' is assigned a value but never used no-unused-vars Line 324:11: 'before' is assigned a value but never used no-unused-vars ./src/components/manager/subscribe/Bootstrap.js src/components/manager/subscribe/Bootstrap.js Line 16:7: 'history' is assigned a value but never used no-unused-vars ./src/components/manager/subscribe/ChangePassword.js src/components/manager/subscribe/ChangePassword.js Line 13:7: 'dispatch' is assigned a value but never used no-unused-vars ./src/components/manager/subscribe/Login.js src/components/manager/subscribe/Login.js Line 20:7: 'history' is assigned a value but never used no-unused-vars ./src/components/modals/ConfirmCategoryDelete.js src/components/modals/ConfirmCategoryDelete.js Line 25:11: 'category' is assigned a value but never used no-unused-vars Line 25:21: 'group' is assigned a value but never used no-unused-vars ./src/components/modals/CreateEncryptionKey.js src/components/modals/CreateEncryptionKey.js Line 26:8: 'enabling' is assigned a value but never used no-unused-vars Line 26:18: 'setEnabling' is assigned a value but never used no-unused-vars ./src/components/modals/EditRule.js src/components/modals/EditRule.js Line 179:49: 'inputKey' is assigned a value but never used no-unused-vars ./src/components/payees/ManagePayeesWithData.js src/components/payees/ManagePayeesWithData.js Line 6:13: 'undo' is defined but never used no-unused-vars ./src/components/reports/CashFlow.js src/components/reports/CashFlow.js Line 25:10: 'earliestMonth' is assigned a value but never used no-unused-vars Line 87:22: 'balance' is assigned a value but never used no-unused-vars Line 87:31: 'totalChange' is assigned a value but never used no-unused-vars ./src/components/reports/NetWorth.js src/components/reports/NetWorth.js Line 22:10: 'earliestMonth' is assigned a value but never used no-unused-vars ./src/components/schedules/DiscoverSchedules.js src/components/schedules/DiscoverSchedules.js Line 2:10: 'useLocation' is defined but never used no-unused-vars Line 4:8: 'Platform' is defined but never used no-unused-vars Line 11:3: 'Button' is defined but never used no-unused-vars Line 136:9: 'items' is assigned a value but never used no-unused-vars ./src/components/schedules/EditSchedule.js src/components/schedules/EditSchedule.js Line 95:7: 'pageType' is assigned a value but never used no-unused-vars Line 254:11: 'dates' is assigned a value but never used no-unused-vars Line 300:13: 'error' is assigned a value but never used no-unused-vars ./src/components/schedules/LinkSchedule.js src/components/schedules/LinkSchedule.js Line 18:7: 'dateFormat' is assigned a value but never used no-unused-vars ./src/global-events.js src/global-events.js Line 48:18: 'onManage' is defined but never used no-unused-vars Line 85:11: 'messages' is assigned a value but never used no-unused-vars ./src/index.js src/index.js Line 40:10: 'log' is defined but never used no-unused-vars ./src/plaid.js src/plaid.js Line 38:9: 'error' is assigned a value but never used no-unused-vars ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 20:42:26 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#33316