github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-11 01:18:59 -05:00
Code Issues 1.6k Packages Projects Releases 57 Wiki Activity

[PR #784] [MERGED] ♻️ refactor Nordigen and Category autocomplete usage #3326

New Issue
Closed
opened 2026-02-28 20:39:57 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:39:57 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/784
Author: @MatissJanis
Created: 3/18/2023
Status: ✅ Merged
Merged: 3/18/2023
Merged by: @MatissJanis

Base: master ← Head: matiss/autocomplete-3

📝 Commits (4)

  • c3b2257 ♻️ refactor Nordigen and Category autocomplete usage
  • 28e3dde Release notes
  • f3c09ec Merge branch 'master' into matiss/autocomplete-3
  • 45cb142 Fix lint

📊 Changes

12 files changed (+238 additions, -135 deletions)

View changed files

📝 packages/desktop-client/src/components/Modals.js (+1 -0)
📝 packages/desktop-client/src/components/accounts/TransactionsTable.js (+5 -1)
📝 packages/desktop-client/src/components/util/GenericInput.js (+5 -1)
➕ packages/loot-design/src/components/CategoryAutocomplete.js (+91 -0)
📝 packages/loot-design/src/components/budget/index.js (+8 -1)
📝 packages/loot-design/src/components/budget/rollover/BudgetSummary.js (+19 -3)
📝 packages/loot-design/src/components/budget/rollover/TransferTooltip.js (+7 -1)
📝 packages/loot-design/src/components/budget/rollover/rollover-components.js (+18 -2)
📝 packages/loot-design/src/components/modals/EditField.js (+6 -1)
📝 packages/loot-design/src/components/modals/NordigenExternalMsg.js (+10 -63)
📝 packages/loot-design/src/components/modals/countries.js (+62 -62)
➕ upcoming-release-notes/784.md (+6 -0)

📄 Description

The final Autocomplete refactors. After this is merged what's remaining is to do extensive testing and address the bugs in https://github.com/actualbudget/actual/issues/773

This PR moves Nordigen autocomplete to the new one without using a feature flag. IMO this is a safe change given the simple nature of the Nordigen autocomplete component.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/784 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 3/18/2023 **Status:** ✅ Merged **Merged:** 3/18/2023 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `matiss/autocomplete-3` --- ### 📝 Commits (4) - [`c3b2257`](https://github.com/actualbudget/actual/commit/c3b2257346ce995e7f550b2dbb7acb36b4c6c0b3) :recycle: refactor Nordigen and Category autocomplete usage - [`28e3dde`](https://github.com/actualbudget/actual/commit/28e3dde851006b935c48c81a720ab404a5730622) Release notes - [`f3c09ec`](https://github.com/actualbudget/actual/commit/f3c09ec3540c1fe178f41842b109b39a09c23364) Merge branch 'master' into matiss/autocomplete-3 - [`45cb142`](https://github.com/actualbudget/actual/commit/45cb142ccd364868c39e191e6a7c4358966ba9ff) Fix lint ### 📊 Changes **12 files changed** (+238 additions, -135 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/Modals.js` (+1 -0) 📝 `packages/desktop-client/src/components/accounts/TransactionsTable.js` (+5 -1) 📝 `packages/desktop-client/src/components/util/GenericInput.js` (+5 -1) ➕ `packages/loot-design/src/components/CategoryAutocomplete.js` (+91 -0) 📝 `packages/loot-design/src/components/budget/index.js` (+8 -1) 📝 `packages/loot-design/src/components/budget/rollover/BudgetSummary.js` (+19 -3) 📝 `packages/loot-design/src/components/budget/rollover/TransferTooltip.js` (+7 -1) 📝 `packages/loot-design/src/components/budget/rollover/rollover-components.js` (+18 -2) 📝 `packages/loot-design/src/components/modals/EditField.js` (+6 -1) 📝 `packages/loot-design/src/components/modals/NordigenExternalMsg.js` (+10 -63) 📝 `packages/loot-design/src/components/modals/countries.js` (+62 -62) ➕ `upcoming-release-notes/784.md` (+6 -0) </details> ### 📄 Description The final `Autocomplete` refactors. After this is merged what's remaining is to do extensive testing and address the bugs in https://github.com/actualbudget/actual/issues/773 This PR moves `Nordigen` autocomplete to the new one without using a feature flag. IMO this is a safe change given the simple nature of the Nordigen autocomplete component. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:39:57 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#3326
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?