github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 03:32:54 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #780] [MERGED] ✅ change unit test usage of notes field #3323

New Issue
Closed
opened 2026-02-28 20:39:54 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:39:54 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/780
Author: @MatissJanis
Created: 3/18/2023
Status: ✅ Merged
Merged: 3/18/2023
Merged by: @MatissJanis

Base: master ← Head: matiss/disable-test

📝 Commits (5)

📊 Changes

2 files changed (+10 additions, -1 deletions)

View changed files

📝 packages/desktop-client/src/components/accounts/TransactionsTable.test.js (+4 -1)
➕ upcoming-release-notes/780.md (+6 -0)

📄 Description

Added an extra waitFor after a flaky unit test step.

I'm not really super happy with this workaround.. but it does make the test much more stable (re-ran 5x and no failures: https://github.com/actualbudget/actual/actions/runs/4455134799).

I think there is some internal timeout happening somewhere which is causing this issue.. But not really sure where. And this will hopefully get auto-fixed once we migrate to a new table. 🤞

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/780 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 3/18/2023 **Status:** ✅ Merged **Merged:** 3/18/2023 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `matiss/disable-test` --- ### 📝 Commits (5) - [`caf3b1a`](https://github.com/actualbudget/actual/commit/caf3b1ae8891d4ec76bbcc0c501eb09cd17aaf24) :white_check_mark: change unit test usage of notes field - [`8d7b53a`](https://github.com/actualbudget/actual/commit/8d7b53af90b8c6101ad4d323da5a9b0ef9d2194c) Rename notes field - [`914f02f`](https://github.com/actualbudget/actual/commit/914f02ff031784450636e7168829c5ccd5560fd0) What about now? - [`b2738b8`](https://github.com/actualbudget/actual/commit/b2738b8c262c5f3896960982621ff8606b5ee3e4) possibly? - [`1d14c75`](https://github.com/actualbudget/actual/commit/1d14c7541cd29d51344b94d46c451ed8d7a48577) Update release notes ### 📊 Changes **2 files changed** (+10 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/accounts/TransactionsTable.test.js` (+4 -1) ➕ `upcoming-release-notes/780.md` (+6 -0) </details> ### 📄 Description Added an extra `waitFor` after a flaky unit test step. I'm not really super happy with this workaround.. but it does make the test much more stable (re-ran 5x and no failures: https://github.com/actualbudget/actual/actions/runs/4455134799). I think there is some internal timeout happening somewhere which is causing this issue.. But not really sure where. And this will hopefully get auto-fixed once we migrate to a new table. 🤞 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:39:54 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#3323
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?