github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-07 04:18:51 -05:00
Code Issues 1.6k Packages Projects Releases 55 Wiki Activity

[PR #117] [MERGED] Fix: parse dates without a delimiter in CSV import #33224

New Issue
Closed
opened 2026-04-20 20:38:07 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-20 20:38:07 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/117
Author: @PartyLich
Created: 7/3/2022
Status: ✅ Merged
Merged: 7/11/2022
Merged by: @jlongster

Base: master ← Head: fix/parse-dates-sans-delimiter

📝 Commits (7)

  • a194ead fix: use more versatile date regex
  • 2a836d2 test: add parseDate tests
  • 9511e5b style: apply prettier
  • acb5306 docs: update documentation/comments
  • 71972f0 test: add impossible date test cases
  • 337e5f3 test: add invalid length date test cases
  • 0b7fcfd refactor: split groups with slice

📊 Changes

2 files changed (+138 additions, -7 deletions)

View changed files

📝 packages/loot-design/src/components/modals/ImportTransactions.js (+15 -7)
➕ packages/loot-design/src/components/modals/ImportTransactions.test.js (+123 -0)

📄 Description

Addresses issue #116 by adding new regexes to meet the currently available formats. If anyone has additional test cases to suggest that would be swell.

  • Prettier applied (including changes to legacy code)
  • Tests added

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/117 **Author:** [@PartyLich](https://github.com/PartyLich) **Created:** 7/3/2022 **Status:** ✅ Merged **Merged:** 7/11/2022 **Merged by:** [@jlongster](https://github.com/jlongster) **Base:** `master` ← **Head:** `fix/parse-dates-sans-delimiter` --- ### 📝 Commits (7) - [`a194ead`](https://github.com/actualbudget/actual/commit/a194ead61fcadc7575f8d84ddef21ab2ff115ed4) fix: use more versatile date regex - [`2a836d2`](https://github.com/actualbudget/actual/commit/2a836d2c5eeeb331b67472295c73da4edae53f81) test: add parseDate tests - [`9511e5b`](https://github.com/actualbudget/actual/commit/9511e5bdf82fa3ea6139955bdf39c8a3167f35ad) style: apply prettier - [`acb5306`](https://github.com/actualbudget/actual/commit/acb53065406e78b59a51aa3b22603ce2ad623a29) docs: update documentation/comments - [`71972f0`](https://github.com/actualbudget/actual/commit/71972f06e59ee7d22b3cc6889ee12d22c2839747) test: add impossible date test cases - [`337e5f3`](https://github.com/actualbudget/actual/commit/337e5f3f5f27a2be8ca8a17531efd60f3b5d63a1) test: add invalid length date test cases - [`0b7fcfd`](https://github.com/actualbudget/actual/commit/0b7fcfd63cdfb7ab1ba6e5be74217bf33ce935a2) refactor: split groups with slice ### 📊 Changes **2 files changed** (+138 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `packages/loot-design/src/components/modals/ImportTransactions.js` (+15 -7) ➕ `packages/loot-design/src/components/modals/ImportTransactions.test.js` (+123 -0) </details> ### 📄 Description Addresses issue #116 by adding new regexes to meet the currently available formats. If anyone has additional test cases to suggest that would be swell. - [x] Prettier applied (including changes to legacy code) - [x] Tests added --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 20:38:07 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#33224
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?