[PR #772] [MERGED] ⬆️ upgrade fast-check to improve unit test perf #3317

Closed
opened 2026-02-28 20:39:49 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/772
Author: @MatissJanis
Created: 3/17/2023
Status: Merged
Merged: 3/17/2023
Merged by: @MatissJanis

Base: masterHead: matiss/upgrade-fast-check


📝 Commits (1)

  • a57c636 ⬆️ upgrade fast-check to improve unit test perf

📊 Changes

6 files changed (+26 additions, -20 deletions)

View changed files

📝 packages/loot-core/package.json (+1 -1)
📝 packages/loot-core/src/mocks/arbitrary-schema.js (+4 -4)
📝 packages/loot-core/src/server/sync/migrate.test.js (+3 -3)
📝 packages/loot-core/src/server/sync/sync.property.test.js (+2 -2)
upcoming-release-notes/772.md (+6 -0)
📝 yarn.lock (+10 -10)

📄 Description

Upgraded fast-check to improve unit test performance.

(ignore set up environment step - that is slow only the first time it's ran because of no dependency cache; focus on the "test" step)

Before:
Screenshot 2023-03-17 at 20 02 37

After:
Screenshot 2023-03-17 at 20 07 47


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/772 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 3/17/2023 **Status:** ✅ Merged **Merged:** 3/17/2023 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `matiss/upgrade-fast-check` --- ### 📝 Commits (1) - [`a57c636`](https://github.com/actualbudget/actual/commit/a57c636edafb4d2e475ed56e7e5f163c5ab05642) :arrow_up: upgrade fast-check to improve unit test perf ### 📊 Changes **6 files changed** (+26 additions, -20 deletions) <details> <summary>View changed files</summary> 📝 `packages/loot-core/package.json` (+1 -1) 📝 `packages/loot-core/src/mocks/arbitrary-schema.js` (+4 -4) 📝 `packages/loot-core/src/server/sync/migrate.test.js` (+3 -3) 📝 `packages/loot-core/src/server/sync/sync.property.test.js` (+2 -2) ➕ `upcoming-release-notes/772.md` (+6 -0) 📝 `yarn.lock` (+10 -10) </details> ### 📄 Description Upgraded `fast-check` to improve unit test performance. (ignore `set up environment` step - that is slow only the first time it's ran because of no dependency cache; focus on the "test" step) Before: <img width="1305" alt="Screenshot 2023-03-17 at 20 02 37" src="https://user-images.githubusercontent.com/886567/226020436-a36ac0b9-4d4e-4935-8d51-b46284aeea5f.png"> After: <img width="1307" alt="Screenshot 2023-03-17 at 20 07 47" src="https://user-images.githubusercontent.com/886567/226022545-f2e3ca60-7e6c-4f03-86d3-18993380ae7a.png"> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:39:49 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#3317