[PR #766] [CLOSED] [WIP] (nordigen) Add transfer detection based on IBANs #3312

New Issue

GiteaMirror · 2026-02-28T20:39:45-06:00

GiteaMirror commented

2026-02-28 20:39:45 -06:00

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/766
Author: @Jackenmen
Created: 3/17/2023
Status: ❌ Closed

Base: master ← Head: implement_transfer_detection

📝 Commits (10+)

e95f947 First take on transfer detection based on IBANs
ce0fdde Add migration
2b6e537 Fix doubled attribute loookup
a0e66f3 Fix lack of usage of trans in resolvePayeeFromIban
d63621e Generalize IBAN column to any account number
8c9d20c Hash debtor/creditorAccount's IBAN number before lookup
91fa44d Fix typo in usage of table alias in INNER JOIN
93bd539 Use more sensible name for migration file
c26d210 Add missing awaits
b20956e Fix handling of iban = null

📊 Changes

10 files changed (+77 additions, -21 deletions)

View changed files

➕ packages/loot-core/migrations/1681494042597_accounts_account_number.sql (+7 -0)
📝 packages/loot-core/src/server/accounts/link.js (+1 -0)
📝 packages/loot-core/src/server/accounts/sync.js (+43 -8)
📝 packages/loot-core/src/server/db/index.ts (+9 -0)
📝 packages/loot-core/src/server/encryption-internals.js (+0 -4)
📝 packages/loot-core/src/server/encryption-internals.web.js (+0 -9)
📝 packages/loot-core/src/server/main.js (+3 -0)
📝 packages/loot-core/src/server/sync/sync.property.test.js (+1 -0)
➕ packages/loot-core/src/server/util/hash.js (+5 -0)
➕ packages/loot-core/src/server/util/hash.web.js (+8 -0)

📄 Description

This is WIP and untested work for now. The only way for implementing auto-detection of transfers seems to be basing it on the IBAN on the opposite side of the transaction. The issue with that is that we need to get that IBAN from somewhere first - here I'm solving it by more or less caching it under the iban column and updating that cached value whenever transactions get synchronized. It isn't perfect - for one it doesn't support transfer detection when only one side of the transfer has bank sync configured.

Depends on https://github.com/actualbudget/actual-server/pull/166

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/766 **Author:** [@Jackenmen](https://github.com/Jackenmen) **Created:** 3/17/2023 **Status:** ❌ Closed **Base:** `master` ← **Head:** `implement_transfer_detection` --- ### 📝 Commits (10+) - [`e95f947`](https://github.com/actualbudget/actual/commit/e95f9471494cea9dde2a812bce92a4e54c068e7c) First take on transfer detection based on IBANs - [`ce0fdde`](https://github.com/actualbudget/actual/commit/ce0fdde1217a3286309cd7f9e42d6768e9f667a9) Add migration - [`2b6e537`](https://github.com/actualbudget/actual/commit/2b6e5377cfa4b27002cd3d1a41edc8318d912d54) Fix doubled attribute loookup - [`a0e66f3`](https://github.com/actualbudget/actual/commit/a0e66f30647c6069268648d8f6dbb260b58a00f8) Fix lack of usage of `trans` in resolvePayeeFromIban - [`d63621e`](https://github.com/actualbudget/actual/commit/d63621e8d4fe6168bdac3ab21a2bebaae88f6450) Generalize IBAN column to any account number - [`8c9d20c`](https://github.com/actualbudget/actual/commit/8c9d20cf7986b120e95a0c2d0fbacf3a89d3caf6) Hash debtor/creditorAccount's IBAN number before lookup - [`91fa44d`](https://github.com/actualbudget/actual/commit/91fa44db6971ca7fd025f0e31a996a5427d93e75) Fix typo in usage of table alias in INNER JOIN - [`93bd539`](https://github.com/actualbudget/actual/commit/93bd539abb25edd1588908a16e9b82b79e4adf47) Use more sensible name for migration file - [`c26d210`](https://github.com/actualbudget/actual/commit/c26d210cfba983c4606fa6bb506b5ffd0d19e49a) Add missing awaits - [`b20956e`](https://github.com/actualbudget/actual/commit/b20956e2237fed5ada57aebac2f3dc28ab3c2d4f) Fix handling of iban = null ### 📊 Changes **10 files changed** (+77 additions, -21 deletions) <details> <summary>View changed files</summary> ➕ `packages/loot-core/migrations/1681494042597_accounts_account_number.sql` (+7 -0) 📝 `packages/loot-core/src/server/accounts/link.js` (+1 -0) 📝 `packages/loot-core/src/server/accounts/sync.js` (+43 -8) 📝 `packages/loot-core/src/server/db/index.ts` (+9 -0) 📝 `packages/loot-core/src/server/encryption-internals.js` (+0 -4) 📝 `packages/loot-core/src/server/encryption-internals.web.js` (+0 -9) 📝 `packages/loot-core/src/server/main.js` (+3 -0) 📝 `packages/loot-core/src/server/sync/sync.property.test.js` (+1 -0) ➕ `packages/loot-core/src/server/util/hash.js` (+5 -0) ➕ `packages/loot-core/src/server/util/hash.web.js` (+8 -0) </details> ### 📄 Description This is WIP and untested work for now. The only way for implementing auto-detection of transfers seems to be basing it on the IBAN on the opposite side of the transaction. The issue with that is that we need to get that IBAN from somewhere first - here I'm solving it by more or less caching it under the `iban` column and updating that cached value whenever transactions get synchronized. It isn't perfect - for one it doesn't support transfer detection when only one side of the transfer has bank sync configured. Depends on https://github.com/actualbudget/actual-server/pull/166 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-02-28 20:39:45 -06:00

GiteaMirror closed this issue