github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-10 20:23:07 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #765] [MERGED] 🐛 making desktop-client tests independent #3311

New Issue
Closed
opened 2026-02-28 20:39:44 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:39:44 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/765
Author: @MatissJanis
Created: 3/16/2023
Status: ✅ Merged
Merged: 3/16/2023
Merged by: @MatissJanis

Base: master ← Head: matiss/remove-test-fake-randomness

📝 Commits (3)

  • 77dbe09 🐛 making desktop-client tests independent
  • 727620e Release notes
  • 5b7ca6a Update upcoming-release-notes/765.md

📊 Changes

4 files changed (+48 additions, -106 deletions)

View changed files

📝 packages/desktop-client/src/components/accounts/TransactionsTable.test.js (+42 -2)
➖ packages/desktop-client/src/components/accounts/__snapshots__/TransactionsTable.test.js.snap (+0 -85)
📝 packages/loot-design/src/setupTests.js (+0 -19)
➕ upcoming-release-notes/765.md (+6 -0)

📄 Description

Tests cases should be independent. You should be able to run them in whatever order you want. And they should still pass.

Currently this is not the case. The order of the tests is very important due to the "pseudo" randomization algorithm.

This PR makes the mock data IDs truly unique thus better exposing the issue in our tests. Also this PR fixes the dependency issues thus making each test case truly independent.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/765 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 3/16/2023 **Status:** ✅ Merged **Merged:** 3/16/2023 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `matiss/remove-test-fake-randomness` --- ### 📝 Commits (3) - [`77dbe09`](https://github.com/actualbudget/actual/commit/77dbe09e3433ac878697578ba4c5aae70408b0ae) :bug: making desktop-client tests independent - [`727620e`](https://github.com/actualbudget/actual/commit/727620eb8f13845e85842d41ae629ee5e6975bb3) Release notes - [`5b7ca6a`](https://github.com/actualbudget/actual/commit/5b7ca6a1d15e8105c3e56d80f66a721a6634d00e) Update upcoming-release-notes/765.md ### 📊 Changes **4 files changed** (+48 additions, -106 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/accounts/TransactionsTable.test.js` (+42 -2) ➖ `packages/desktop-client/src/components/accounts/__snapshots__/TransactionsTable.test.js.snap` (+0 -85) 📝 `packages/loot-design/src/setupTests.js` (+0 -19) ➕ `upcoming-release-notes/765.md` (+6 -0) </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes --> Tests cases should be independent. You should be able to run them in whatever order you want. And they should still pass. Currently this is not the case. The order of the tests is very important due to the "pseudo" randomization algorithm. This PR makes the mock data IDs truly unique thus better exposing the issue in our tests. Also this PR fixes the dependency issues thus making each test case truly independent. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:39:44 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#3311
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?