github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 07:01:45 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #7437] [MERGED] Add scoped ErrorBoundary to Rules page to contain rendering crashes #33090

New Issue
Closed
opened 2026-04-18 09:01:27 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-18 09:01:27 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/7437
Author: @tmchow
Created: 4/9/2026
Status: ✅ Merged
Merged: 4/14/2026
Merged by: @MatissJanis

Base: master ← Head: osc/7391-rules-error-boundary

📝 Commits (5)

  • c2c1fbc [AI] Add scoped ErrorBoundary to Rules page to contain rendering crashes
  • eee4d7e [autofix.ci] apply automated fixes
  • c70ccd3 docs: add release notes for ErrorBoundary PR
  • af272dd fix(rules): add resetKeys to ErrorBoundary for route navigation reset
  • 93b64ae fix(rules): show error message in fallback UI and log to console

📊 Changes

3 files changed (+76 additions, -2 deletions)

View changed files

➕ packages/desktop-client/src/components/FeatureErrorFallback.tsx (+51 -0)
📝 packages/desktop-client/src/components/FinancesApp.tsx (+19 -2)
➕ upcoming-release-notes/7437.md (+6 -0)

📄 Description

Addresses #7391 (picking the Rules page area from the table).

When a Rules or RuleEdit component throws during rendering, the whole app goes to the Fatal Error screen. This wraps both /rules and /rules/:id routes in a scoped ErrorBoundary so crashes stay contained to that section.

What changed:

  • New FeatureErrorFallback component with a retry button. Reusable for other areas later
  • ErrorBoundary wrapping in FinancesApp.tsx for both Rules routes

The fallback uses the existing react-error-boundary v6 dependency and @actual-app/components primitives. All strings go through Trans for i18n.

The FeatureErrorFallback component follows the pattern from GetCardData.tsx but adds resetErrorBoundary support so users can retry without leaving the page.

This change was made with AI assistance.

CE

Bundle Stats

Bundle Files count Total bundle size % Changed
desktop-client 27 12.86 MB → 12.86 MB (+2.12 kB) +0.02%
loot-core 1 4.84 MB 0%
api 1 3.84 MB 0%
cli 1 7.89 MB 0%
View detailed bundle stats

desktop-client

Total

Files count Total bundle size % Changed
27 12.86 MB → 12.86 MB (+2.12 kB) +0.02%
Changeset
File Δ Size
src/components/FeatureErrorFallback.tsx 🆕 +1.3 kB 0 B → 1.3 kB
src/components/FinancesApp.tsx 📈 +841 B (+4.71%) 17.44 kB → 18.26 kB
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger

Asset File Size % Changed
static/js/index.js 3.31 MB → 3.32 MB (+2.12 kB) +0.06%

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
static/js/BackgroundImage.js 121.09 kB 0%
static/js/FormulaEditor.js 852.77 kB 0%
static/js/ReportRouter.js 1.17 MB 0%
static/js/TransactionList.js 82.49 kB 0%
static/js/ca.js 191.98 kB 0%
static/js/da.js 104.66 kB 0%
static/js/de.js 174.38 kB 0%
static/js/en-GB.js 8.2 kB 0%
static/js/en.js 175.72 kB 0%
static/js/es.js 181.8 kB 0%
static/js/fr.js 177.08 kB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 13.46 kB 0%
static/js/it.js 165.87 kB 0%
static/js/narrow.js 363.02 kB 0%
static/js/nb-NO.js 151.85 kB 0%
static/js/nl.js 108.93 kB 0%
static/js/pl.js 88.34 kB 0%
static/js/pt-BR.js 177.44 kB 0%
static/js/resize-observer.js 18.06 kB 0%
static/js/th.js 179.3 kB 0%
static/js/theme.js 485.18 kB 0%
static/js/uk.js 212.6 kB 0%
static/js/useTransactionBatchActions.js 4.33 MB 0%
static/js/wide.js 295 B 0%
static/js/workbox-window.prod.es5.js 7.33 kB 0%
static/js/zh-Hans.js 99.27 kB 0%

loot-core

Total

Files count Total bundle size % Changed
1 4.84 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.2cr-I6dh.js 4.84 MB 0%

api

Total

Files count Total bundle size % Changed
1 3.84 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
index.js 3.84 MB 0%

cli

Total

Files count Total bundle size % Changed
1 7.89 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
cli.js 7.89 MB 0%

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/7437 **Author:** [@tmchow](https://github.com/tmchow) **Created:** 4/9/2026 **Status:** ✅ Merged **Merged:** 4/14/2026 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `osc/7391-rules-error-boundary` --- ### 📝 Commits (5) - [`c2c1fbc`](https://github.com/actualbudget/actual/commit/c2c1fbca281c5e7477c3103f3fc12438435fdb3e) [AI] Add scoped ErrorBoundary to Rules page to contain rendering crashes - [`eee4d7e`](https://github.com/actualbudget/actual/commit/eee4d7ef834870af9f13087ce7d5080949fa8d21) [autofix.ci] apply automated fixes - [`c70ccd3`](https://github.com/actualbudget/actual/commit/c70ccd3aded4f3c2fe52a1a326d28edee5490c4b) docs: add release notes for ErrorBoundary PR - [`af272dd`](https://github.com/actualbudget/actual/commit/af272dd9855a609e70682251cc3f1ca375bcb326) fix(rules): add resetKeys to ErrorBoundary for route navigation reset - [`93b64ae`](https://github.com/actualbudget/actual/commit/93b64ae375c024499235fb9bfcfe872ab8ad44ec) fix(rules): show error message in fallback UI and log to console ### 📊 Changes **3 files changed** (+76 additions, -2 deletions) <details> <summary>View changed files</summary> ➕ `packages/desktop-client/src/components/FeatureErrorFallback.tsx` (+51 -0) 📝 `packages/desktop-client/src/components/FinancesApp.tsx` (+19 -2) ➕ `upcoming-release-notes/7437.md` (+6 -0) </details> ### 📄 Description Addresses #7391 (picking the Rules page area from the table). When a Rules or RuleEdit component throws during rendering, the whole app goes to the Fatal Error screen. This wraps both `/rules` and `/rules/:id` routes in a scoped `ErrorBoundary` so crashes stay contained to that section. **What changed:** - New `FeatureErrorFallback` component with a retry button. Reusable for other areas later - ErrorBoundary wrapping in `FinancesApp.tsx` for both Rules routes The fallback uses the existing `react-error-boundary` v6 dependency and `@actual-app/components` primitives. All strings go through `Trans` for i18n. The `FeatureErrorFallback` component follows the pattern from `GetCardData.tsx` but adds `resetErrorBoundary` support so users can retry without leaving the page. --- *This change was made with AI assistance.* [![CE](https://img.shields.io/badge/Built_with-Compound_Engineering-6366f1)](https://github.com/EveryInc/compound-engineering-plugin) <!--- actual-bot-sections ---> <hr /> <!--- bundlestats-action-comment key:combined start ---> ### Bundle Stats Bundle | Files count | Total bundle size | % Changed ------ | ----------- | ----------------- | --------- desktop-client | 27 | 12.86 MB → 12.86 MB (+2.12 kB) | +0.02% loot-core | 1 | 4.84 MB | 0% api | 1 | 3.84 MB | 0% cli | 1 | 7.89 MB | 0% <details> <summary>View detailed bundle stats</summary> #### desktop-client **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 27 | 12.86 MB → 12.86 MB (+2.12 kB) | +0.02% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `src/components/FeatureErrorFallback.tsx` | 🆕 +1.3 kB | 0 B → 1.3 kB `src/components/FinancesApp.tsx` | 📈 +841 B (+4.71%) | 17.44 kB → 18.26 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** Asset | File Size | % Changed ----- | --------- | --------- static/js/index.js | 3.31 MB → 3.32 MB (+2.12 kB) | +0.06% **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- static/js/BackgroundImage.js | 121.09 kB | 0% static/js/FormulaEditor.js | 852.77 kB | 0% static/js/ReportRouter.js | 1.17 MB | 0% static/js/TransactionList.js | 82.49 kB | 0% static/js/ca.js | 191.98 kB | 0% static/js/da.js | 104.66 kB | 0% static/js/de.js | 174.38 kB | 0% static/js/en-GB.js | 8.2 kB | 0% static/js/en.js | 175.72 kB | 0% static/js/es.js | 181.8 kB | 0% static/js/fr.js | 177.08 kB | 0% static/js/indexeddb-main-thread-worker-e59fee74.js | 13.46 kB | 0% static/js/it.js | 165.87 kB | 0% static/js/narrow.js | 363.02 kB | 0% static/js/nb-NO.js | 151.85 kB | 0% static/js/nl.js | 108.93 kB | 0% static/js/pl.js | 88.34 kB | 0% static/js/pt-BR.js | 177.44 kB | 0% static/js/resize-observer.js | 18.06 kB | 0% static/js/th.js | 179.3 kB | 0% static/js/theme.js | 485.18 kB | 0% static/js/uk.js | 212.6 kB | 0% static/js/useTransactionBatchActions.js | 4.33 MB | 0% static/js/wide.js | 295 B | 0% static/js/workbox-window.prod.es5.js | 7.33 kB | 0% static/js/zh-Hans.js | 99.27 kB | 0% </div> </details> --- #### loot-core **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 4.84 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.2cr-I6dh.js | 4.84 MB | 0% </div> </details> --- #### api **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 3.84 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- index.js | 3.84 MB | 0% </div> </details> --- #### cli **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 7.89 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- cli.js | 7.89 MB | 0% </div> </details> </details> <!--- bundlestats-action-comment key:combined end ---> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-18 09:01:27 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#33090
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?