github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 03:32:54 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #741] [MERGED] ♻️ (autocomplete) refactor PayeeAutocomplete to react-select #3295

New Issue
Closed
opened 2026-02-28 20:39:29 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:39:29 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/741
Author: @MatissJanis
Created: 3/11/2023
Status: ✅ Merged
Merged: 3/17/2023
Merged by: @MatissJanis

Base: master ← Head: matiss/autocomplete

📝 Commits (10+)

  • 79cf45c ♻️ (autocomplete) refactor PayeeAutocomplete to …
  • d437e7c Fix UT
  • cd7a016 PayeeAutocomplete: multi option
  • 2369fdf Fix highlighted rows overlaying autocomplete
  • 8b36b1b Update packages/loot-design/src/components/NewPayeeAutocomplete.js
  • 396d70b Style improvements
  • 7962d97 Make ESC work correctly
  • e40bd25 Overflow: hidden
  • 56da5d4 Fix tab key
  • 2a580ca Merge branch 'master' into matiss/autocomplete

📊 Changes

15 files changed (+613 additions, -11 deletions)

View changed files

📝 packages/desktop-client/src/components/accounts/Filters.js (+1 -1)
📝 packages/desktop-client/src/components/accounts/TransactionsTable.js (+8 -1)
📝 packages/desktop-client/src/components/accounts/TransactionsTable.test.js (+1 -0)
📝 packages/desktop-client/src/components/schedules/EditSchedule.js (+10 -1)
📝 packages/desktop-client/src/components/settings/Experimental.js (+12 -0)
📝 packages/desktop-client/src/components/util/GenericInput.js (+9 -1)
➕ packages/desktop-client/src/hooks/useFeatureFlag.js (+5 -0)
📝 packages/loot-design/package.json (+1 -0)
➕ packages/loot-design/src/components/NewPayeeAutocomplete.js (+241 -0)
➕ packages/loot-design/src/components/autocomplete-styles.js (+74 -0)
📝 packages/loot-design/src/components/common.js (+2 -0)
📝 packages/loot-design/src/components/modals/EditField.js (+9 -2)
📝 packages/loot-design/src/components/tooltips.js (+2 -1)
➕ upcoming-release-notes/741.md (+6 -0)
📝 yarn.lock (+232 -4)

📄 Description

Refactored PayeeAutocomplete to react-select. The new component is under a feature flag.

I will be slowly refactoring other bits too, but it will take time as it's not an easy migration.. so I've put it under a feature flag for now. Once we're ready to release and are confident we can remove the old code.

This will also allow us to eventually remove lively.

There might be some small functional/design differences. I tried getting it as close to the existing one as possible, but it won't be 1:1.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/741 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 3/11/2023 **Status:** ✅ Merged **Merged:** 3/17/2023 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `matiss/autocomplete` --- ### 📝 Commits (10+) - [`79cf45c`](https://github.com/actualbudget/actual/commit/79cf45c2c40050dfeb3b5cc09fcf7a9c03021686) :recycle: (autocomplete) refactor PayeeAutocomplete to … - [`d437e7c`](https://github.com/actualbudget/actual/commit/d437e7cc48e9cc074cb75c641c2fa671685091aa) Fix UT - [`cd7a016`](https://github.com/actualbudget/actual/commit/cd7a0162245ca15a0d69f13e6b275055f14b0c68) PayeeAutocomplete: multi option - [`2369fdf`](https://github.com/actualbudget/actual/commit/2369fdf20f6124ef087d488a3847f957c4fa791c) Fix highlighted rows overlaying autocomplete - [`8b36b1b`](https://github.com/actualbudget/actual/commit/8b36b1b18bf65ad43429b2bedcfb2a34f3b74eb6) Update packages/loot-design/src/components/NewPayeeAutocomplete.js - [`396d70b`](https://github.com/actualbudget/actual/commit/396d70b84c0100ffb082d6d906ba5f93614dc597) Style improvements - [`7962d97`](https://github.com/actualbudget/actual/commit/7962d975659f017c4e7f61f74ce51af63462311d) Make ESC work correctly - [`e40bd25`](https://github.com/actualbudget/actual/commit/e40bd2571bd95f5dbaf71a18938739eef758ef99) Overflow: hidden - [`56da5d4`](https://github.com/actualbudget/actual/commit/56da5d428f1f7f0aa64693eb65011df6a35023a1) Fix tab key - [`2a580ca`](https://github.com/actualbudget/actual/commit/2a580cab4015218e5541abc679c212b27450d85c) Merge branch 'master' into matiss/autocomplete ### 📊 Changes **15 files changed** (+613 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/accounts/Filters.js` (+1 -1) 📝 `packages/desktop-client/src/components/accounts/TransactionsTable.js` (+8 -1) 📝 `packages/desktop-client/src/components/accounts/TransactionsTable.test.js` (+1 -0) 📝 `packages/desktop-client/src/components/schedules/EditSchedule.js` (+10 -1) 📝 `packages/desktop-client/src/components/settings/Experimental.js` (+12 -0) 📝 `packages/desktop-client/src/components/util/GenericInput.js` (+9 -1) ➕ `packages/desktop-client/src/hooks/useFeatureFlag.js` (+5 -0) 📝 `packages/loot-design/package.json` (+1 -0) ➕ `packages/loot-design/src/components/NewPayeeAutocomplete.js` (+241 -0) ➕ `packages/loot-design/src/components/autocomplete-styles.js` (+74 -0) 📝 `packages/loot-design/src/components/common.js` (+2 -0) 📝 `packages/loot-design/src/components/modals/EditField.js` (+9 -2) 📝 `packages/loot-design/src/components/tooltips.js` (+2 -1) ➕ `upcoming-release-notes/741.md` (+6 -0) 📝 `yarn.lock` (+232 -4) </details> ### 📄 Description Refactored PayeeAutocomplete to `react-select`. The new component is under a feature flag. I will be slowly refactoring other bits too, but it will take time as it's not an easy migration.. so I've put it under a feature flag for now. Once we're ready to release and are confident we can remove the old code. This will also allow us to eventually remove `lively`. **There might be some small functional/design differences. I tried getting it as close to the existing one as possible, but it won't be 1:1.** --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:39:29 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#3295
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?