github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 03:32:54 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #725] [MERGED] Improve handling of large currency amounts #3284

New Issue
Closed
opened 2026-02-28 20:39:19 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:39:19 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/725
Author: @j-f1
Created: 3/4/2023
Status: ✅ Merged
Merged: 3/18/2023
Merged by: @j-f1

Base: master ← Head: jed/who-wants-to-be-a-millionaire

📝 Commits (10+)

  • 634c4fe Update format settings to better match the rest of the settings
  • 15bb6fd Add a setting for hiding currency decimal points
  • 92a21f3 Add a “hideFraction” setting
  • 321850c Slightly tighten letter spacing to allow more digits in no-fraction mode
  • b97a196 Sliiightly widen the balance column to eke out another digit
  • 4f7340f Fix bad tests
  • 52c7657 Don’t set min width of pages on iPhone SE 1
  • e9434b4 Update settings UI per review
  • 87e2fbb Update format preview when hiding fraction
  • e8e864c release notes

📊 Changes

14 files changed (+157 additions, -67 deletions)

View changed files

📝 packages/desktop-client/src/components/accounts/Account.js (+3 -0)
📝 packages/desktop-client/src/components/accounts/MobileAccount.js (+2 -1)
📝 packages/desktop-client/src/components/accounts/MobileAccounts.js (+2 -1)
📝 packages/desktop-client/src/components/accounts/TransactionList.js (+2 -0)
📝 packages/desktop-client/src/components/accounts/TransactionsTable.js (+13 -6)
📝 packages/desktop-client/src/components/budget/MobileBudget.js (+2 -1)
📝 packages/desktop-client/src/components/settings/Format.js (+84 -37)
📝 packages/loot-core/src/client/reducers/prefs.js (+12 -3)
📝 packages/loot-core/src/shared/util.js (+7 -7)
📝 packages/loot-core/src/shared/util.test.js (+18 -9)
📝 packages/loot-design/src/components/common.js (+2 -1)
📝 packages/loot-design/src/style.js (+3 -1)
📝 packages/loot-design/src/tokens.js (+1 -0)
➕ upcoming-release-notes/725.md (+6 -0)

📄 Description

  • Add a “hide decimal places” setting to visually hide the .xx from currency values globally
  • When hiding the fractional digits, slightly decrease character spacing to allow more digits to show up

Ref: #327

New settings:
Screenshot_2023-03-17 14 19 46

Before/after:
Screenshot_2023-02-27 21 47 07Screenshot_2023-02-27 22 02 01

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/725 **Author:** [@j-f1](https://github.com/j-f1) **Created:** 3/4/2023 **Status:** ✅ Merged **Merged:** 3/18/2023 **Merged by:** [@j-f1](https://github.com/j-f1) **Base:** `master` ← **Head:** `jed/who-wants-to-be-a-millionaire` --- ### 📝 Commits (10+) - [`634c4fe`](https://github.com/actualbudget/actual/commit/634c4fee7aeeb3041db212fe13918bbc9a87ef4b) Update format settings to better match the rest of the settings - [`15bb6fd`](https://github.com/actualbudget/actual/commit/15bb6fdc859393edbc95adcab42516cfd703d838) Add a setting for hiding currency decimal points - [`92a21f3`](https://github.com/actualbudget/actual/commit/92a21f3f4da8c88e0e4eaa8e523e16d22c2f50ec) Add a “hideFraction” setting - [`321850c`](https://github.com/actualbudget/actual/commit/321850ca0ecf837e92d762d5db043fe34be5991c) Slightly tighten letter spacing to allow more digits in no-fraction mode - [`b97a196`](https://github.com/actualbudget/actual/commit/b97a196e097719632150f6f9712e09df94137c40) Sliiightly widen the balance column to eke out another digit - [`4f7340f`](https://github.com/actualbudget/actual/commit/4f7340f042a84f9431c19571458b867e3331e672) Fix bad tests - [`52c7657`](https://github.com/actualbudget/actual/commit/52c76579e9b0763a4218946067791a984c391bfc) Don’t set min width of pages on iPhone SE 1 - [`e9434b4`](https://github.com/actualbudget/actual/commit/e9434b4bf49af276a983dfd6a7676f7d256181f6) Update settings UI per review - [`87e2fbb`](https://github.com/actualbudget/actual/commit/87e2fbbf0ffeb65ad2a4f4bdf2b0a24709405595) Update format preview when hiding fraction - [`e8e864c`](https://github.com/actualbudget/actual/commit/e8e864c923386c179e3802a25524dedfd25d93aa) release notes ### 📊 Changes **14 files changed** (+157 additions, -67 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/accounts/Account.js` (+3 -0) 📝 `packages/desktop-client/src/components/accounts/MobileAccount.js` (+2 -1) 📝 `packages/desktop-client/src/components/accounts/MobileAccounts.js` (+2 -1) 📝 `packages/desktop-client/src/components/accounts/TransactionList.js` (+2 -0) 📝 `packages/desktop-client/src/components/accounts/TransactionsTable.js` (+13 -6) 📝 `packages/desktop-client/src/components/budget/MobileBudget.js` (+2 -1) 📝 `packages/desktop-client/src/components/settings/Format.js` (+84 -37) 📝 `packages/loot-core/src/client/reducers/prefs.js` (+12 -3) 📝 `packages/loot-core/src/shared/util.js` (+7 -7) 📝 `packages/loot-core/src/shared/util.test.js` (+18 -9) 📝 `packages/loot-design/src/components/common.js` (+2 -1) 📝 `packages/loot-design/src/style.js` (+3 -1) 📝 `packages/loot-design/src/tokens.js` (+1 -0) ➕ `upcoming-release-notes/725.md` (+6 -0) </details> ### 📄 Description - Add a “hide decimal places” setting to visually hide the `.xx` from currency values globally - When hiding the fractional digits, slightly decrease character spacing to allow more digits to show up Ref: #327 New settings: <img width="566" alt="Screenshot_2023-03-17 14 19 46" src="https://user-images.githubusercontent.com/25517624/225986815-b884b93d-02f9-48b3-a73d-d27f90b678cf.png"> Before/after: <img width="149" alt="Screenshot_2023-02-27 21 47 07" src="https://user-images.githubusercontent.com/25517624/222916856-21ab4f03-56c6-4b24-8fc1-ac4b883138b7.png"><img width="131" alt="Screenshot_2023-02-27 22 02 01" src="https://user-images.githubusercontent.com/25517624/222916859-cf882ca3-6087-4994-818e-239c3374e412.png"> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:39:19 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#3284
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?