github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 03:32:54 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #697] [MERGED] 🏗️ moving back to create-react-app #3262

New Issue
Closed
opened 2026-02-28 20:38:59 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:38:59 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/697
Author: @MatissJanis
Created: 2/26/2023
Status: ✅ Merged
Merged: 2/28/2023
Merged by: @MatissJanis

Base: master ← Head: matiss/move-cra

📝 Commits (7)

📊 Changes

45 files changed (+5634 additions, -5481 deletions)

View changed files

📝 .eslintrc.js (+16 -10)
📝 package.json (+4 -5)
➖ packages/desktop-client/.babelrc (+0 -6)
📝 packages/desktop-client/bin/build-browser (+1 -1)
📝 packages/desktop-client/bin/watch-browser (+1 -1)
➕ packages/desktop-client/config-overrides.js (+38 -0)
➖ packages/desktop-client/config/env.js (+0 -93)
➖ packages/desktop-client/config/getHttpsConfig.js (+0 -65)
➖ packages/desktop-client/config/jest/cssTransform.js (+0 -14)
➖ packages/desktop-client/config/jest/fileTransform.js (+0 -30)
➖ packages/desktop-client/config/paths.js (+0 -92)
➖ packages/desktop-client/config/webpack.config.js (+0 -587)
➖ packages/desktop-client/config/webpackDevServer.config.js (+0 -130)
➖ packages/desktop-client/jest.config.js (+0 -4)
📝 packages/desktop-client/package.json (+16 -37)
➖ packages/desktop-client/scripts/build.js (+0 -192)
➖ packages/desktop-client/scripts/start.js (+0 -113)
➖ packages/desktop-client/scripts/test.js (+0 -53)
📝 packages/desktop-client/src/browser-preload.browser.js (+6 -5)
📝 packages/desktop-client/src/browser-server.js (+1 -1)

...and 25 more files

📄 Description

Why move back to CRA?

Managing build and dev-server configuration is a very labor intensive work. Upgrading webpack and it's dependencies is painful. Especially if you want to jump multiple versions ahead.

It's nice if someone else can manage this for us. Hence moving back to CRA is IMO a good idea.

Long term future: we should consider moving to an even more modern build solution. This is only a stop-gap solution so we're not stuck in 2015 anymore.

Added bonus: this PR upgrades webpack & other dependencies to WAYYY newer versions.

--

Todo:

  • tests aren't working yet
  • electron dev-server requires hard refresh; figure out how we can fix this
  • do manual tests for the entire flow (including deploying this to flyio)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/697 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 2/26/2023 **Status:** ✅ Merged **Merged:** 2/28/2023 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `matiss/move-cra` --- ### 📝 Commits (7) - [`276bc41`](https://github.com/actualbudget/actual/commit/276bc41de62f89a108783550dc49724800fd8a4f) :building_construction: moving back to create-react-app - [`b166f58`](https://github.com/actualbudget/actual/commit/b166f584795d8c463e2dc49928ee8c5c4fec3523) Electron dev-server improvement - [`edec03f`](https://github.com/actualbudget/actual/commit/edec03fdc0ebbc0edd5d7dbef67cd69c1ff1597c) fix TransactionsTable.test.js - [`3506795`](https://github.com/actualbudget/actual/commit/35067959164245ec9094f44fa76f8cd5997fe863) Fix unit tests - [`1052739`](https://github.com/actualbudget/actual/commit/10527394a33ab9f0e6bfba188041726d11a2940c) Fixes - [`710da91`](https://github.com/actualbudget/actual/commit/710da91267c26f8275ce8fe6ebf7e5389e7cbb1c) Rename BackendWorker var - [`0c61321`](https://github.com/actualbudget/actual/commit/0c613215b09cbd399c4c5f9a6a523ec6654d583b) Move polyfills installation ### 📊 Changes **45 files changed** (+5634 additions, -5481 deletions) <details> <summary>View changed files</summary> 📝 `.eslintrc.js` (+16 -10) 📝 `package.json` (+4 -5) ➖ `packages/desktop-client/.babelrc` (+0 -6) 📝 `packages/desktop-client/bin/build-browser` (+1 -1) 📝 `packages/desktop-client/bin/watch-browser` (+1 -1) ➕ `packages/desktop-client/config-overrides.js` (+38 -0) ➖ `packages/desktop-client/config/env.js` (+0 -93) ➖ `packages/desktop-client/config/getHttpsConfig.js` (+0 -65) ➖ `packages/desktop-client/config/jest/cssTransform.js` (+0 -14) ➖ `packages/desktop-client/config/jest/fileTransform.js` (+0 -30) ➖ `packages/desktop-client/config/paths.js` (+0 -92) ➖ `packages/desktop-client/config/webpack.config.js` (+0 -587) ➖ `packages/desktop-client/config/webpackDevServer.config.js` (+0 -130) ➖ `packages/desktop-client/jest.config.js` (+0 -4) 📝 `packages/desktop-client/package.json` (+16 -37) ➖ `packages/desktop-client/scripts/build.js` (+0 -192) ➖ `packages/desktop-client/scripts/start.js` (+0 -113) ➖ `packages/desktop-client/scripts/test.js` (+0 -53) 📝 `packages/desktop-client/src/browser-preload.browser.js` (+6 -5) 📝 `packages/desktop-client/src/browser-server.js` (+1 -1) _...and 25 more files_ </details> ### 📄 Description **Why move back to CRA?** Managing build and dev-server configuration is a very labor intensive work. Upgrading webpack and it's dependencies is painful. Especially if you want to jump multiple versions ahead. It's nice if someone else can manage this for us. Hence moving back to CRA is IMO a good idea. Long term future: we should consider moving to an even more modern build solution. This is only a stop-gap solution so we're not stuck in 2015 anymore. **Added bonus: this PR upgrades webpack & other dependencies to WAYYY newer versions.** -- Todo: - [x] tests aren't working yet - [x] electron dev-server requires hard refresh; figure out how we can fix this - [x] do manual tests for the entire flow (including deploying this to flyio) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:38:59 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#3262
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?