github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-11 01:18:59 -05:00
Code Issues 1.6k Packages Projects Releases 57 Wiki Activity

[PR #6642] [MERGED] lint: patch some no-empty-function violations & delete unused code #32571

New Issue
Closed
opened 2026-04-18 08:35:40 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-18 08:35:40 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/6642
Author: @MatissJanis
Created: 1/13/2026
Status: ✅ Merged
Merged: 1/13/2026
Merged by: @MatissJanis

Base: master ← Head: matiss/lint-patch-no-empty-function

📝 Commits (4)

  • 5feb3f3 lint: patch some no-empty-function violations
  • 564deed docs: update ESLint rules and remove unused loadOwner function in UserAccess component
  • 6bee0fd refactor: remove getRemoteFile function and associated method from budget file handlers
  • 3b36b3c chore: disable docstring checks in coderabbit configuration

📊 Changes

15 files changed (+51 additions, -126 deletions)

View changed files

📝 .coderabbit.yaml (+1 -0)
📝 .oxlintrc.json (+0 -7)
📝 AGENTS.md (+1 -3)
📝 packages/desktop-client/src/components/ServerContext.tsx (+6 -2)
📝 packages/desktop-client/src/components/admin/UserAccess/UserAccess.tsx (+5 -32)
📝 packages/desktop-client/src/components/admin/UserDirectory/UserDirectory.tsx (+7 -33)
📝 packages/desktop-client/src/components/budget/BudgetCategories.tsx (+0 -1)
📝 packages/desktop-client/src/components/budget/SidebarCategory.tsx (+10 -3)
📝 packages/desktop-client/src/components/budget/envelope/BalanceMovementMenu.tsx (+2 -2)
📝 packages/desktop-client/src/components/modals/EditFieldModal.tsx (+0 -1)
📝 packages/desktop-client/src/components/schedules/ScheduleLink.tsx (+0 -1)
📝 packages/desktop-client/src/components/schedules/SchedulesTable.tsx (+13 -3)
📝 packages/loot-core/src/server/budgetfiles/app.ts (+0 -6)
📝 packages/loot-core/src/server/cloud-storage.ts (+0 -32)
➕ upcoming-release-notes/6642.md (+6 -0)

📄 Description

No description provided

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/6642 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 1/13/2026 **Status:** ✅ Merged **Merged:** 1/13/2026 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `matiss/lint-patch-no-empty-function` --- ### 📝 Commits (4) - [`5feb3f3`](https://github.com/actualbudget/actual/commit/5feb3f345ef9885cd5f74e5f2041dc61b7a36613) lint: patch some no-empty-function violations - [`564deed`](https://github.com/actualbudget/actual/commit/564deedda8326687c8d8699dfe4fe0b65d2b6c4b) docs: update ESLint rules and remove unused loadOwner function in UserAccess component - [`6bee0fd`](https://github.com/actualbudget/actual/commit/6bee0fd4bd9d27f6d7a3567b3575ba011a96e90e) refactor: remove getRemoteFile function and associated method from budget file handlers - [`3b36b3c`](https://github.com/actualbudget/actual/commit/3b36b3cc14bdd65cd92188002c84fea1c743f74e) chore: disable docstring checks in coderabbit configuration ### 📊 Changes **15 files changed** (+51 additions, -126 deletions) <details> <summary>View changed files</summary> 📝 `.coderabbit.yaml` (+1 -0) 📝 `.oxlintrc.json` (+0 -7) 📝 `AGENTS.md` (+1 -3) 📝 `packages/desktop-client/src/components/ServerContext.tsx` (+6 -2) 📝 `packages/desktop-client/src/components/admin/UserAccess/UserAccess.tsx` (+5 -32) 📝 `packages/desktop-client/src/components/admin/UserDirectory/UserDirectory.tsx` (+7 -33) 📝 `packages/desktop-client/src/components/budget/BudgetCategories.tsx` (+0 -1) 📝 `packages/desktop-client/src/components/budget/SidebarCategory.tsx` (+10 -3) 📝 `packages/desktop-client/src/components/budget/envelope/BalanceMovementMenu.tsx` (+2 -2) 📝 `packages/desktop-client/src/components/modals/EditFieldModal.tsx` (+0 -1) 📝 `packages/desktop-client/src/components/schedules/ScheduleLink.tsx` (+0 -1) 📝 `packages/desktop-client/src/components/schedules/SchedulesTable.tsx` (+13 -3) 📝 `packages/loot-core/src/server/budgetfiles/app.ts` (+0 -6) 📝 `packages/loot-core/src/server/cloud-storage.ts` (+0 -32) ➕ `upcoming-release-notes/6642.md` (+6 -0) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-18 08:35:40 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#32571
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?