github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 07:01:45 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #6593] [MERGED] :electron: Improve metainfo validation for flathub #32548

New Issue
Closed
opened 2026-04-18 08:34:35 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-18 08:34:35 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/6593
Author: @MikesGlitch
Created: 1/7/2026
Status: ✅ Merged
Merged: 1/8/2026
Merged by: @MikesGlitch

Base: master ← Head: improve-manifest-validation-flathub

📝 Commits (5)

  • 2e77219 manifest validation for flathub
  • bc6fc5a install builder separately
  • f893391 confirmed working, now removing validation errors
  • fb42a9e updates to metainfo with new validation fixes
  • 7dca5fd release notes

📊 Changes

5 files changed (+17 additions, -10 deletions)

View changed files

📝 .github/workflows/electron-master.yml (+2 -3)
📝 .github/workflows/electron-pr.yml (+2 -3)
📝 .github/workflows/publish-nightly-electron.yml (+2 -3)
📝 packages/desktop-electron/extra-resources/linux/com.actualbudget.actual.metainfo.xml (+5 -1)
➕ upcoming-release-notes/6593.md (+6 -0)

📄 Description

The appstream CLI is hard to update and the version seems to be tied to whatever is available for the OS.

I've switched to the flatpak for linting because it keeps us up to date with what will be run on the official flathub repo.

It should fail the build when metainfo is invalid, e.g. https://github.com/actualbudget/actual/actions/runs/20794066730/job/59722940182

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/6593 **Author:** [@MikesGlitch](https://github.com/MikesGlitch) **Created:** 1/7/2026 **Status:** ✅ Merged **Merged:** 1/8/2026 **Merged by:** [@MikesGlitch](https://github.com/MikesGlitch) **Base:** `master` ← **Head:** `improve-manifest-validation-flathub` --- ### 📝 Commits (5) - [`2e77219`](https://github.com/actualbudget/actual/commit/2e77219b32ec6baed2e08cb66bf4c322a3666ef7) manifest validation for flathub - [`bc6fc5a`](https://github.com/actualbudget/actual/commit/bc6fc5a0164475819638c3682bb9ca9f30baadf5) install builder separately - [`f893391`](https://github.com/actualbudget/actual/commit/f893391bbab374d20b990b4321cd611aaf94d368) confirmed working, now removing validation errors - [`fb42a9e`](https://github.com/actualbudget/actual/commit/fb42a9e270a255bc769e36fe03c9f7a824040db1) updates to metainfo with new validation fixes - [`7dca5fd`](https://github.com/actualbudget/actual/commit/7dca5fd796be0bda94898467466c9b4c5dae4925) release notes ### 📊 Changes **5 files changed** (+17 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/electron-master.yml` (+2 -3) 📝 `.github/workflows/electron-pr.yml` (+2 -3) 📝 `.github/workflows/publish-nightly-electron.yml` (+2 -3) 📝 `packages/desktop-electron/extra-resources/linux/com.actualbudget.actual.metainfo.xml` (+5 -1) ➕ `upcoming-release-notes/6593.md` (+6 -0) </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes. Try running yarn generate:release-notes *before* pushing your PR for an interactive experience. --> The appstream CLI is hard to update and the version seems to be tied to whatever is available for the OS. I've switched to the flatpak for linting because it keeps us up to date with what will be run on the official flathub repo. It should fail the build when metainfo is invalid, e.g. https://github.com/actualbudget/actual/actions/runs/20794066730/job/59722940182 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-18 08:34:35 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#32548
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?