github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-10 12:12:39 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #681] [MERGED] Don’t post messages to the worker until it is ready #3249

New Issue
Closed
opened 2026-02-28 20:38:47 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:38:47 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/681
Author: @j-f1
Created: 2/22/2023
Status: ✅ Merged
Merged: 2/24/2023
Merged by: @j-f1

Base: master ← Head: jed/fix-send-dropped

📝 Commits (1)

  • cb1a92a Don’t post messages to the worker until it is ready

📊 Changes

1 file changed (+11 additions, -16 deletions)

View changed files

📝 packages/loot-core/src/platform/client/fetch/index.browser.js (+11 -16)

📄 Description

While reviewing the Nordigen PR locally, I noticed that the frontend would think it was not connected to a server. This seems to be because the get-server-url message is sent super early in the app lifecycle, after the worker has been created but before it is ready to receive a message. This PR uses the existing messageQueue logic but extends it from just the time before init is called all the way until the connect event is sent by the worker to indicate it is ready for messages.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/681 **Author:** [@j-f1](https://github.com/j-f1) **Created:** 2/22/2023 **Status:** ✅ Merged **Merged:** 2/24/2023 **Merged by:** [@j-f1](https://github.com/j-f1) **Base:** `master` ← **Head:** `jed/fix-send-dropped` --- ### 📝 Commits (1) - [`cb1a92a`](https://github.com/actualbudget/actual/commit/cb1a92a97107e9d6a65a1ef535d8e41f667e3413) Don’t post messages to the worker until it is ready ### 📊 Changes **1 file changed** (+11 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `packages/loot-core/src/platform/client/fetch/index.browser.js` (+11 -16) </details> ### 📄 Description While reviewing the Nordigen PR locally, I noticed that the frontend would think it was not connected to a server. This seems to be because the `get-server-url` message is sent super early in the app lifecycle, after the worker has been created but before it is ready to receive a message. This PR uses the existing `messageQueue` logic but extends it from just the time before `init` is called all the way until the `connect` event is sent by the worker to indicate it is ready for messages. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:38:47 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#3249
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?