github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-07 12:28:57 -05:00
Code Issues 1.6k Packages Projects Releases 55 Wiki Activity

[PR #6463] [MERGED] chore: Add a meta.name to the eslint plugin. #32470

New Issue
Closed
opened 2026-04-18 08:30:07 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-18 08:30:07 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/6463
Author: @connorshea
Created: 12/21/2025
Status: ✅ Merged
Merged: 12/21/2025
Merged by: @MatissJanis

Base: master ← Head: meta-name

📝 Commits (3)

  • 10f53c2 Add a name to the eslint plugin.
  • b95e396 Add release note.
  • 45755fc Also update the no-restricted-imports patterns in .oxlintrc.json.

📊 Changes

3 files changed (+11 additions, -2 deletions)

View changed files

📝 .oxlintrc.json (+2 -2)
📝 packages/eslint-plugin-actual/lib/index.js (+3 -0)
➕ upcoming-release-notes/6463.md (+6 -0)

📄 Description

Noticed this'll break when you upgrade oxlint if this isn't done (noticed with https://github.com/oxc-project/oxc-ecosystem-ci/actions/runs/20404230629/job/58631736649), so figured I'd contribute that :)

Also fix the config for the glob patterns in the no-restricted-imports rule. Noticed this by running yarn oxlint --report-unused-disable-directives-severity=error and taking a look at the directives that were unnecessarily-disabled. oxlint uses rust fast-glob for glob matching generally, and so the * character matches everything except / separators. And so you'd be missing files nested under directories with the previous glob.

Summary by CodeRabbit

  • Chores
    • Enhanced the ESLint plugin configuration by adding name metadata, improving plugin identification and proper integration with ESLint tooling.

✏️ Tip: You can customize this high-level summary in your review settings.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/6463 **Author:** [@connorshea](https://github.com/connorshea) **Created:** 12/21/2025 **Status:** ✅ Merged **Merged:** 12/21/2025 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `meta-name` --- ### 📝 Commits (3) - [`10f53c2`](https://github.com/actualbudget/actual/commit/10f53c27493cca9125b592cc697768198b2f0725) Add a name to the eslint plugin. - [`b95e396`](https://github.com/actualbudget/actual/commit/b95e3964a518feaa98257d81ffeb4cf8b78c8172) Add release note. - [`45755fc`](https://github.com/actualbudget/actual/commit/45755fcf9152782261da092cab84f5e716a3a917) Also update the no-restricted-imports patterns in .oxlintrc.json. ### 📊 Changes **3 files changed** (+11 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `.oxlintrc.json` (+2 -2) 📝 `packages/eslint-plugin-actual/lib/index.js` (+3 -0) ➕ `upcoming-release-notes/6463.md` (+6 -0) </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes. Try running yarn generate:release-notes *before* pushing your PR for an interactive experience. --> Noticed this'll break when you upgrade oxlint if this isn't done (noticed with https://github.com/oxc-project/oxc-ecosystem-ci/actions/runs/20404230629/job/58631736649), so figured I'd contribute that :) Also fix the config for the glob patterns in the no-restricted-imports rule. Noticed this by running `yarn oxlint --report-unused-disable-directives-severity=error` and taking a look at the directives that were unnecessarily-disabled. oxlint uses rust fast-glob for glob matching generally, and so the `*` character matches everything _except_ `/` separators. And so you'd be missing files nested under directories with the previous glob. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * Enhanced the ESLint plugin configuration by adding name metadata, improving plugin identification and proper integration with ESLint tooling. <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub> <!-- end of auto-generated comment: release notes by coderabbit.ai --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-18 08:30:07 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#32470
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?