[PR #668] [MERGED] Adds delay before note is displayed on hover. Solves issue #658. #3240

Closed
opened 2026-02-28 20:38:39 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/668
Author: @vsakhamuri12
Created: 2/19/2023
Status: Merged
Merged: 2/27/2023
Merged by: @j-f1

Base: masterHead: master


📝 Commits (10+)

📊 Changes

1 file changed (+22 additions, -2 deletions)

View changed files

📝 packages/loot-design/src/components/NotesButton.js (+22 -2)

📄 Description

Since the issue was to provide some delay so that the note doesn't display immediately on hover, I have added a 2 second delay. As this issue felt fairly easy to solve, I am submitting this PR. This is my first pull request on open source. Thank you for this opportunity. If there's a mistake I would love some feedback as this will be a great learning opportunity.

Fixes #658


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/668 **Author:** [@vsakhamuri12](https://github.com/vsakhamuri12) **Created:** 2/19/2023 **Status:** ✅ Merged **Merged:** 2/27/2023 **Merged by:** [@j-f1](https://github.com/j-f1) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (10+) - [`07dabd0`](https://github.com/actualbudget/actual/commit/07dabd0dba22490546892d377e52fe21403e16d6) Adds delay - [`4861360`](https://github.com/actualbudget/actual/commit/48613606f16a9c568d7dd42b73f33471ddcfda50) change delay to half second. - [`12ad48f`](https://github.com/actualbudget/actual/commit/12ad48fb37aca0539111dbe6ed8eac6fc7d80e5d) Added async - [`6e831d4`](https://github.com/actualbudget/actual/commit/6e831d4cce5cb1818bcea2ea01a411694d6291af) Changed Delay - [`8171c61`](https://github.com/actualbudget/actual/commit/8171c6176ea77b8648ecf6eb969a7163f32a59db) lint fix - [`4b4caad`](https://github.com/actualbudget/actual/commit/4b4caadf9ffe0dd960e87340785bcd5c2ea33400) Merge branch 'master' into pr/668 - [`c931dc6`](https://github.com/actualbudget/actual/commit/c931dc6003327ad47ebb270e93c517c066651f8f) Changed hover actions - [`4f49472`](https://github.com/actualbudget/actual/commit/4f49472523ce8abff4c3633446e938a1e388f850) Merge branch 'master' of github.com:venkata-krishnas/actual - [`c55ab0d`](https://github.com/actualbudget/actual/commit/c55ab0d871c8604dca93dbb9e5f25cd700538560) Merge branch 'master' into master - [`d6dbf9e`](https://github.com/actualbudget/actual/commit/d6dbf9e767e5091d5dde782846902f160864fcef) onMouseLeave ### 📊 Changes **1 file changed** (+22 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `packages/loot-design/src/components/NotesButton.js` (+22 -2) </details> ### 📄 Description Since the issue was to provide some delay so that the note doesn't display immediately on hover, I have added a 2 second delay. As this issue felt fairly easy to solve, I am submitting this PR. This is my first pull request on open source. Thank you for this opportunity. If there's a mistake I would love some feedback as this will be a great learning opportunity. Fixes #658 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:38:39 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#3240