github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-11 09:38:37 -05:00
Code Issues 1.6k Packages Projects Releases 57 Wiki Activity

[PR #6259] [MERGED] chore: replace Prettier with oxfmt and add oxlint #32339

New Issue
Closed
opened 2026-04-18 08:24:09 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-18 08:24:09 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/6259
Author: @MatissJanis
Created: 11/26/2025
Status: ✅ Merged
Merged: 12/4/2025
Merged by: @MatissJanis

Base: master ← Head: matiss/oxc-linter-integration

📝 Commits (5)

  • 92ac089 chore: replace Prettier with oxfmt and add oxlint
  • 623f143 chore: update dependencies in yarn.lock
  • 8b08cb4 chore: update oxlint configuration to disable additional rules
  • bef79b3 Merge branch 'master' into matiss/oxc-linter-integration
  • 16f9406 chore: update oxfmt and oxlint configurations, enhance test readability

📊 Changes

33 files changed (+1137 additions, -1696 deletions)

View changed files

📝 .github/actions/check-migrations.js (+0 -1)
➕ .oxfmtrc.json (+8 -0)
➕ .oxlintrc.json (+77 -0)
➖ .prettierignore (+0 -36)
➖ .prettierrc.json (+0 -5)
📝 eslint.config.mjs (+4 -48)
📝 package.json (+11 -7)
📝 packages/component-library/src/icons/template.ts (+4 -1)
📝 packages/crdt/bin/generate-proto (+1 -1)
📝 packages/crdt/src/proto/sync_pb.js (+443 -531)
📝 packages/desktop-client/src/budgetfiles/budgetfilesSlice.ts (+3 -3)
📝 packages/desktop-client/src/components/App.tsx (+1 -1)
📝 packages/desktop-client/src/components/mobile/MobileNavTabs.tsx (+3 -3)
📝 packages/desktop-client/src/components/mobile/transactions/TransactionList.tsx (+1 -1)
📝 packages/desktop-client/src/components/modals/CreateEncryptionKeyModal.tsx (+1 -2)
📝 packages/desktop-client/src/components/modals/ImportTransactionsModal/ImportTransactionsModal.tsx (+0 -1)
📝 packages/desktop-client/src/components/reports/reports/CustomReport.tsx (+0 -1)
📝 packages/desktop-client/src/components/schedules/ScheduleEditModal.tsx (+0 -1)
📝 packages/desktop-client/src/components/transactions/SelectedTransactionsButton.tsx (+1 -1)
📝 packages/desktop-client/src/hooks/useEffectAfterMount.ts (+0 -1)

...and 13 more files

📄 Description

Same as https://github.com/actualbudget/actual/pull/6248 except using oxc + oxcfmt.

The goal would be to slowly transition all eslint rules over to oxc and thus drastically improve the performance. Using oxc instead of biome because it has better support for migrations such as this one + the community is stronger there.

Before:

$ time yarn lint
Checking formatting...
All matched files use Prettier code style!
yarn lint  47.96s user 3.89s system 178% cpu 29.116 total

After:

$ time yarn lint
Checking formatting...

All matched files use the correct format.
Finished in 249ms on 1561 files using 10 threads.
Found 0 warnings and 0 errors.
Finished in 309ms on 1540 files using 10 threads.
yarn lint  30.32s user 3.87s system 169% cpu 20.170 total

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/6259 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 11/26/2025 **Status:** ✅ Merged **Merged:** 12/4/2025 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `matiss/oxc-linter-integration` --- ### 📝 Commits (5) - [`92ac089`](https://github.com/actualbudget/actual/commit/92ac089b21b9dbc738334bc303a787aa347c1636) chore: replace Prettier with oxfmt and add oxlint - [`623f143`](https://github.com/actualbudget/actual/commit/623f143c3ecd6c5c404179401a473ba5310253ad) chore: update dependencies in yarn.lock - [`8b08cb4`](https://github.com/actualbudget/actual/commit/8b08cb4fadc098b595285488a4c8a2569ed67fb2) chore: update oxlint configuration to disable additional rules - [`bef79b3`](https://github.com/actualbudget/actual/commit/bef79b365fc8c78be707fc7222e9423fbab96b54) Merge branch 'master' into matiss/oxc-linter-integration - [`16f9406`](https://github.com/actualbudget/actual/commit/16f9406152b687eda363645f3369c2028f7594f5) chore: update oxfmt and oxlint configurations, enhance test readability ### 📊 Changes **33 files changed** (+1137 additions, -1696 deletions) <details> <summary>View changed files</summary> 📝 `.github/actions/check-migrations.js` (+0 -1) ➕ `.oxfmtrc.json` (+8 -0) ➕ `.oxlintrc.json` (+77 -0) ➖ `.prettierignore` (+0 -36) ➖ `.prettierrc.json` (+0 -5) 📝 `eslint.config.mjs` (+4 -48) 📝 `package.json` (+11 -7) 📝 `packages/component-library/src/icons/template.ts` (+4 -1) 📝 `packages/crdt/bin/generate-proto` (+1 -1) 📝 `packages/crdt/src/proto/sync_pb.js` (+443 -531) 📝 `packages/desktop-client/src/budgetfiles/budgetfilesSlice.ts` (+3 -3) 📝 `packages/desktop-client/src/components/App.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/mobile/MobileNavTabs.tsx` (+3 -3) 📝 `packages/desktop-client/src/components/mobile/transactions/TransactionList.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/modals/CreateEncryptionKeyModal.tsx` (+1 -2) 📝 `packages/desktop-client/src/components/modals/ImportTransactionsModal/ImportTransactionsModal.tsx` (+0 -1) 📝 `packages/desktop-client/src/components/reports/reports/CustomReport.tsx` (+0 -1) 📝 `packages/desktop-client/src/components/schedules/ScheduleEditModal.tsx` (+0 -1) 📝 `packages/desktop-client/src/components/transactions/SelectedTransactionsButton.tsx` (+1 -1) 📝 `packages/desktop-client/src/hooks/useEffectAfterMount.ts` (+0 -1) _...and 13 more files_ </details> ### 📄 Description Same as https://github.com/actualbudget/actual/pull/6248 except using oxc + oxcfmt. The goal would be to slowly transition all eslint rules over to oxc and thus drastically improve the performance. Using oxc instead of biome because it has better support for migrations such as this one + the community is stronger there. Before: ``` $ time yarn lint Checking formatting... All matched files use Prettier code style! yarn lint 47.96s user 3.89s system 178% cpu 29.116 total ``` After: ``` $ time yarn lint Checking formatting... All matched files use the correct format. Finished in 249ms on 1561 files using 10 threads. Found 0 warnings and 0 errors. Finished in 309ms on 1540 files using 10 threads. yarn lint 30.32s user 3.87s system 169% cpu 20.170 total ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-18 08:24:09 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#32339
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?