github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 03:32:54 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #651] [MERGED] Add Toggle for hiding "Cleared" column (#603) #3230

New Issue
Closed
opened 2026-02-28 20:38:30 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:38:30 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/651
Author: @mnsrv
Created: 2/12/2023
Status: ✅ Merged
Merged: 2/13/2023
Merged by: @MatissJanis

Base: master ← Head: master

📝 Commits (1)

  • e4cbc7d Add Toggle for hiding "Cleared" column (#603)

📊 Changes

4 files changed (+48 additions, -12 deletions)

View changed files

📝 packages/desktop-client/src/components/accounts/Account.js (+24 -0)
📝 packages/desktop-client/src/components/accounts/TransactionList.js (+2 -0)
📝 packages/desktop-client/src/components/accounts/TransactionsTable.js (+21 -12)
📝 packages/desktop-client/src/components/accounts/TransactionsTable.test.js (+1 -0)

📄 Description

Hello. This adds the new option to the account menu to show/hide the checkbox column.

Implements #603

I have a few questions about implementation

  • I named it showCleared by analogy with showBalances. But unlike balances, this part must be enabled by default. so I named prefs in reverse hide-cleared. Is it confusing? I can name variable to hideCleared. But it is confusing too.
  • Should we mark as cleared automatically all new transactions, while Hide Cleared is chosen?
  • Should we hide cleared/uncleared balances from ExtraBalances in Header of Table as well?
  • Should we hide Cleared from filter too?

This is my first PR, please tell me if something wrong. Thank you!

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/651 **Author:** [@mnsrv](https://github.com/mnsrv) **Created:** 2/12/2023 **Status:** ✅ Merged **Merged:** 2/13/2023 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`e4cbc7d`](https://github.com/actualbudget/actual/commit/e4cbc7db84b28889657ff6bf14d28621e8b47142) Add Toggle for hiding "Cleared" column (#603) ### 📊 Changes **4 files changed** (+48 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/accounts/Account.js` (+24 -0) 📝 `packages/desktop-client/src/components/accounts/TransactionList.js` (+2 -0) 📝 `packages/desktop-client/src/components/accounts/TransactionsTable.js` (+21 -12) 📝 `packages/desktop-client/src/components/accounts/TransactionsTable.test.js` (+1 -0) </details> ### 📄 Description Hello. This adds the new option to the account menu to show/hide the checkbox column. Implements #603 I have a few questions about implementation - I named it showCleared by analogy with showBalances. But unlike balances, this part must be enabled by default. so I named prefs in reverse hide-cleared. Is it confusing? I can name variable to hideCleared. But it is confusing too. - Should we mark as cleared automatically all new transactions, while Hide Cleared is chosen? - Should we hide cleared/uncleared balances from ExtraBalances in Header of Table as well? - Should we hide Cleared from filter too? This is my first PR, please tell me if something wrong. Thank you! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:38:30 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#3230
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?