github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 15:12:35 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #6000] [MERGED] Prevent duplicate filters from being applied #32190

New Issue
Closed
opened 2026-04-18 08:16:33 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-18 08:16:33 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/6000
Author: @parapsychic
Created: 10/25/2025
Status: ✅ Merged
Merged: 11/5/2025
Merged by: @matt-fidd

Base: master ← Head: master

📝 Commits (7)

  • 719f3ab Fix an issue where the user could add duplicate filters (#5999)
  • 0894f4d Add release note (#5999)
  • 24058ee [autofix.ci] apply automated fixes
  • 84d3e79 Changed from JSON.stringify to isEqual (#5999)
  • e27b263 [autofix.ci] apply automated fixes
  • e6cc4ff Merge branch 'master' into master
  • 88b1436 Merge branch 'master' into master

📊 Changes

2 files changed (+13 additions, -0 deletions)

View changed files

📝 packages/desktop-client/src/components/accounts/Account.tsx (+7 -0)
➕ upcoming-release-notes/6000.md (+6 -0)

📄 Description

When applying filters in the Budget view, duplicate filter conditions (with the same field, op, type, and value) were being re-applied instead of ignored. This resulted in multiple identical conditions being added to the filter list.

image

I noticed this first while filtering by tags. I am not completely sure if there is any better way to check if the filter is a duplicate. Here, I've use the stringified JSON to compare.

Fixes #5999

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/6000 **Author:** [@parapsychic](https://github.com/parapsychic) **Created:** 10/25/2025 **Status:** ✅ Merged **Merged:** 11/5/2025 **Merged by:** [@matt-fidd](https://github.com/matt-fidd) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (7) - [`719f3ab`](https://github.com/actualbudget/actual/commit/719f3ab44f7d06c792729d91f9ce3855d6d3779c) Fix an issue where the user could add duplicate filters (#5999) - [`0894f4d`](https://github.com/actualbudget/actual/commit/0894f4d7575b00f2b257af14cf7fea1c911e8ba4) Add release note (#5999) - [`24058ee`](https://github.com/actualbudget/actual/commit/24058ee63b8677df669dbefc60e47a9160b3345f) [autofix.ci] apply automated fixes - [`84d3e79`](https://github.com/actualbudget/actual/commit/84d3e7951cf6bfa3ae27c28e917cf3bb8805ea89) Changed from JSON.stringify to isEqual (#5999) - [`e27b263`](https://github.com/actualbudget/actual/commit/e27b26346682d537244d5c94d478321a325a8bc0) [autofix.ci] apply automated fixes - [`e6cc4ff`](https://github.com/actualbudget/actual/commit/e6cc4ff0e1754a5f3da055bce5f2ec794c25ab5b) Merge branch 'master' into master - [`88b1436`](https://github.com/actualbudget/actual/commit/88b1436bcaf597deee9608b705f74af08080aea1) Merge branch 'master' into master ### 📊 Changes **2 files changed** (+13 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/accounts/Account.tsx` (+7 -0) ➕ `upcoming-release-notes/6000.md` (+6 -0) </details> ### 📄 Description When applying filters in the Budget view, duplicate filter conditions (with the same field, op, type, and value) were being re-applied instead of ignored. This resulted in multiple identical conditions being added to the filter list. <img width="1899" height="470" alt="image" src="https://github.com/user-attachments/assets/43724e16-975a-4a09-be9b-b793819931ad" /> I noticed this first while filtering by tags. I am not completely sure if there is any better way to check if the filter is a duplicate. Here, I've use the stringified JSON to compare. Fixes #5999 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-18 08:16:33 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#32190
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?