github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 15:12:35 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #5783] [MERGED] Add data-1p-ignore to transaction amounts #32039

New Issue
Closed
opened 2026-04-18 08:10:00 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-18 08:10:00 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/5783
Author: @MatissJanis
Created: 9/23/2025
Status: ✅ Merged
Merged: 9/24/2025
Merged by: @MatissJanis

Base: master ← Head: cursor/add-data-1p-ignore-to-transaction-amounts-4ca3

📝 Commits (4)

  • 39bc01a Add data-1p-ignore to transaction amount inputs
  • d86c009 Refactor: Improve InputValue component type safety
  • 3c6b7a9 Add release notes for PR #5783
  • 482dd10 Merge branch 'master' into cursor/add-data-1p-ignore-to-transaction-amounts-4ca3

📊 Changes

3 files changed (+11 additions, -0 deletions)

View changed files

📝 packages/desktop-client/src/components/table.tsx (+2 -0)
📝 packages/desktop-client/src/components/transactions/TransactionsTable.tsx (+2 -0)
➕ upcoming-release-notes/5783.md (+7 -0)

📄 Description

This PR resolves the issue where 1Password attempts to autofill amount fields in split transactions.

Fixes https://github.com/actualbudget/actual/issues/5739

By adding the data-1p-ignore attribute to the debit and credit input fields in the transaction table, we instruct 1Password to ignore these fields, preventing unwanted autofill behavior. Type assertions (as Record<string, unknown>) were used for TypeScript compatibility.

Open in Cursor Open in Web

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/5783 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 9/23/2025 **Status:** ✅ Merged **Merged:** 9/24/2025 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `cursor/add-data-1p-ignore-to-transaction-amounts-4ca3` --- ### 📝 Commits (4) - [`39bc01a`](https://github.com/actualbudget/actual/commit/39bc01a9051549f7cb239965585ba0ffcaf2e039) Add data-1p-ignore to transaction amount inputs - [`d86c009`](https://github.com/actualbudget/actual/commit/d86c009880e1e30da6f00240189e88e2b1c77a93) Refactor: Improve InputValue component type safety - [`3c6b7a9`](https://github.com/actualbudget/actual/commit/3c6b7a984a0af4b801be6910b4b96c68b28a28f3) Add release notes for PR #5783 - [`482dd10`](https://github.com/actualbudget/actual/commit/482dd107b86440a5294e8202521ba5c4586cb4d6) Merge branch 'master' into cursor/add-data-1p-ignore-to-transaction-amounts-4ca3 ### 📊 Changes **3 files changed** (+11 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/table.tsx` (+2 -0) 📝 `packages/desktop-client/src/components/transactions/TransactionsTable.tsx` (+2 -0) ➕ `upcoming-release-notes/5783.md` (+7 -0) </details> ### 📄 Description This PR resolves the issue where 1Password attempts to autofill amount fields in split transactions. Fixes https://github.com/actualbudget/actual/issues/5739 By adding the `data-1p-ignore` attribute to the debit and credit input fields in the transaction table, we instruct 1Password to ignore these fields, preventing unwanted autofill behavior. Type assertions (`as Record<string, unknown>`) were used for TypeScript compatibility. --- <a href="https://cursor.com/background-agent?bcId=bc-8d6e17c1-2869-4191-bce2-0bb77738f34a"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/open-in-cursor-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/open-in-cursor-light.svg"><img alt="Open in Cursor" src="https://cursor.com/open-in-cursor.svg"></picture></a>&nbsp;<a href="https://cursor.com/agents?id=bc-8d6e17c1-2869-4191-bce2-0bb77738f34a"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/open-in-web-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/open-in-web-light.svg"><img alt="Open in Web" src="https://cursor.com/open-in-web.svg"></picture></a> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-18 08:10:00 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#32039
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?