github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 19:52:56 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #591] [MERGED] Allow libofx to handle decoding imported files #3194

New Issue
Closed
opened 2026-02-28 20:37:56 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:37:56 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/591
Author: @j-f1
Created: 1/30/2023
Status: ✅ Merged
Merged: 2/3/2023
Merged by: @j-f1

Base: master ← Head: libofx-charset

📝 Commits (4)

  • 5dadd6b Allow libofx to handle decoding imported files
  • b84c58a Add releve.qfx as a test file
  • 5478c76 Remove irrelevant redacted transactions from test file
  • e0c23f1 Fix console overload from long console.warn stacks

📊 Changes

5 files changed (+118 additions, -2 deletions)

View changed files

➕ packages/loot-core/src/mocks/files/8859-1.qfx (+63 -0)
📝 packages/loot-core/src/server/accounts/__snapshots__/parse-file.test.js.snap (+29 -0)
📝 packages/loot-core/src/server/accounts/parse-file.js (+1 -1)
📝 packages/loot-core/src/server/accounts/parse-file.test.js (+24 -0)
📝 packages/node-libofx/ffi.js (+1 -1)

📄 Description

This avoids assuming that imported OFX files are UTF-8 and defers to libofx, which handles reading the CHARSET header in the file and using that encoding to read its content. Fixes #189. (Tested with the provided file and it works fine!)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/591 **Author:** [@j-f1](https://github.com/j-f1) **Created:** 1/30/2023 **Status:** ✅ Merged **Merged:** 2/3/2023 **Merged by:** [@j-f1](https://github.com/j-f1) **Base:** `master` ← **Head:** `libofx-charset` --- ### 📝 Commits (4) - [`5dadd6b`](https://github.com/actualbudget/actual/commit/5dadd6bd44632d094182f0175dababb7bdaaee4d) Allow libofx to handle decoding imported files - [`b84c58a`](https://github.com/actualbudget/actual/commit/b84c58ad0bf1db194ad954b995b8ff6d65d496e1) Add releve.qfx as a test file - [`5478c76`](https://github.com/actualbudget/actual/commit/5478c76d291a97ef74f7caf8092638cd1f988687) Remove irrelevant redacted transactions from test file - [`e0c23f1`](https://github.com/actualbudget/actual/commit/e0c23f17034d5e20132867e4eb2a72c7e9c241e8) Fix console overload from long console.warn stacks ### 📊 Changes **5 files changed** (+118 additions, -2 deletions) <details> <summary>View changed files</summary> ➕ `packages/loot-core/src/mocks/files/8859-1.qfx` (+63 -0) 📝 `packages/loot-core/src/server/accounts/__snapshots__/parse-file.test.js.snap` (+29 -0) 📝 `packages/loot-core/src/server/accounts/parse-file.js` (+1 -1) 📝 `packages/loot-core/src/server/accounts/parse-file.test.js` (+24 -0) 📝 `packages/node-libofx/ffi.js` (+1 -1) </details> ### 📄 Description This avoids assuming that imported OFX files are UTF-8 and defers to libofx, which handles reading the `CHARSET` header in the file and using that encoding to read its content. Fixes #189. (Tested with the provided file and it works fine!) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:37:56 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#3194
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?