github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-08-31 12:41:54 -05:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[PR #588] [MERGED] Updates to the template/goal feature #3192

New Issue
Closed
opened 2026-02-28 20:37:53 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:37:53 -06:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/588
Author: @j-f1
Created: 1/29/2023
Status: ✅ Merged
Merged: 2/12/2023
Merged by: @j-f1

Base: master ← Head: jed/goal-parser

📝 Commits (10+)

  • 8526679 Dedupe loot-core webpack configs
  • c7f84f4 Swap to parsing using Peggy
  • b61dae7 Actually record syntax errors
  • d74581f Refactor template types
  • 45af78c Add notifications after applying the templates
  • 8bd5369 “Successfully”
  • 1e11c07 Try a Nearley grammar
  • 28a4727 Revert "Try a Nearley grammar"
  • 9c4c48c switch to PEG.js which has slightly better tooling support
  • 4274974 Merge branch 'master' into jed/goal-parser

📊 Changes

10 files changed (+697 additions, -197 deletions)

View changed files

📝 packages/desktop-client/src/components/Notifications.js (+18 -1)
📝 packages/loot-core/jest.config.js (+6 -3)
📝 packages/loot-core/jest.web.config.js (+6 -3)
📝 packages/loot-core/package.json (+4 -0)
📝 packages/loot-core/src/client/actions/queries.js (+9 -3)
➕ packages/loot-core/src/server/budget/goal-template.pegjs (+52 -0)
📝 packages/loot-core/src/server/budget/goaltemplates.js (+65 -124)
📝 packages/loot-core/webpack/webpack.browser.config.js (+27 -16)
📝 packages/loot-core/webpack/webpack.desktop.config.js (+13 -24)
📝 yarn.lock (+497 -23)

📄 Description

  • switch from using regexes to a regular grammar provided by Peggy PEG.js.
  • Using the \p{Sc} regex specifier, all currency symbols are now supported!
  • Add a notification when the templates are applied. If there are errors parsing the templates, they will be called out, and the user must manually dismiss the notification once they are done looking at it:
    Screenshot_2023-01-29 14 36 57

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/588 **Author:** [@j-f1](https://github.com/j-f1) **Created:** 1/29/2023 **Status:** ✅ Merged **Merged:** 2/12/2023 **Merged by:** [@j-f1](https://github.com/j-f1) **Base:** `master` ← **Head:** `jed/goal-parser` --- ### 📝 Commits (10+) - [`8526679`](https://github.com/actualbudget/actual/commit/852667941fdf63b90c6fc92c427c76892db141b3) Dedupe loot-core webpack configs - [`c7f84f4`](https://github.com/actualbudget/actual/commit/c7f84f4ddfa8a7b14766ada9a1d15ecd308335ee) Swap to parsing using Peggy - [`b61dae7`](https://github.com/actualbudget/actual/commit/b61dae76771c306131df8148265318f8ddaf5ffa) Actually record syntax errors - [`d74581f`](https://github.com/actualbudget/actual/commit/d74581fe792f820ef8f5c1c1c14b452e168447bc) Refactor template types - [`45af78c`](https://github.com/actualbudget/actual/commit/45af78ca9e84cca369356d5d18b687f88eebe0b4) Add notifications after applying the templates - [`8bd5369`](https://github.com/actualbudget/actual/commit/8bd5369915ab95eb6efa9aae3cd51eddfa204c6b) “Successfully” - [`1e11c07`](https://github.com/actualbudget/actual/commit/1e11c07b855a492b905f1291c3eadd93f78ac3de) Try a Nearley grammar - [`28a4727`](https://github.com/actualbudget/actual/commit/28a472722881f0c917327c300afdbe1d52289a80) Revert "Try a Nearley grammar" - [`9c4c48c`](https://github.com/actualbudget/actual/commit/9c4c48c4ec57a72858f2b24d48168b65e4667f5e) switch to PEG.js which has slightly better tooling support - [`4274974`](https://github.com/actualbudget/actual/commit/4274974745b62c53313f88bb443e1390c7f5de18) Merge branch 'master' into jed/goal-parser ### 📊 Changes **10 files changed** (+697 additions, -197 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/Notifications.js` (+18 -1) 📝 `packages/loot-core/jest.config.js` (+6 -3) 📝 `packages/loot-core/jest.web.config.js` (+6 -3) 📝 `packages/loot-core/package.json` (+4 -0) 📝 `packages/loot-core/src/client/actions/queries.js` (+9 -3) ➕ `packages/loot-core/src/server/budget/goal-template.pegjs` (+52 -0) 📝 `packages/loot-core/src/server/budget/goaltemplates.js` (+65 -124) 📝 `packages/loot-core/webpack/webpack.browser.config.js` (+27 -16) 📝 `packages/loot-core/webpack/webpack.desktop.config.js` (+13 -24) 📝 `yarn.lock` (+497 -23) </details> ### 📄 Description - switch from using regexes to a regular grammar provided by ~[Peggy](https://peggyjs.org/index.html)~ [PEG.js](https://pegjs.org). - Using the `\p{Sc}` regex specifier, all currency symbols are now supported! - Add a notification when the templates are applied. If there are errors parsing the templates, they will be called out, and the user must manually dismiss the notification once they are done looking at it: <img width="572" alt="Screenshot_2023-01-29 14 36 57" src="https://user-images.githubusercontent.com/25517624/215351508-201f6cce-760c-48ed-b6b6-5475ffed75db.png"> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:37:54 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#3192