[PR #480] [MERGED] Update Victory to the latest version #3166

Closed
opened 2026-02-28 20:37:27 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/480
Author: @j-f1
Created: 1/18/2023
Status: Merged
Merged: 1/18/2023
Merged by: @j-f1

Base: masterHead: update-victory


📝 Commits (5)

📊 Changes

6 files changed (+644 additions, -147 deletions)

View changed files

📝 packages/desktop-client/package.json (+1 -1)
📝 packages/desktop-client/src/components/reports/Overview.js (+2 -2)
📝 packages/desktop-client/src/components/reports/chart-theme.js (+39 -22)
📝 packages/desktop-client/src/components/reports/graphs/CashFlowGraph.js (+1 -1)
📝 packages/desktop-client/src/components/reports/graphs/NetWorthGraph.js (+11 -2)
📝 yarn.lock (+590 -119)

📄 Description

This addresses some warnings caused by the old Victory version using deprecated React APIs. Everything is mostly the same, except that the font is now always Inter, and the bars on the cash flow graph are slightly wider in the 6mo, 12mo, and “all time” views: (before/after)

Screenshot_2023-01-18 13 07 43 Screenshot_2023-01-18 13 07 52

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/480 **Author:** [@j-f1](https://github.com/j-f1) **Created:** 1/18/2023 **Status:** ✅ Merged **Merged:** 1/18/2023 **Merged by:** [@j-f1](https://github.com/j-f1) **Base:** `master` ← **Head:** `update-victory` --- ### 📝 Commits (5) - [`4ebb4fa`](https://github.com/actualbudget/actual/commit/4ebb4fa1a4c5fcb4c7a8e7415d7806d18e9cb17d) Update Victory - [`500f06f`](https://github.com/actualbudget/actual/commit/500f06ff92ecc304b2956741f24430090c751e31) Fix net worth graph - [`e9334ed`](https://github.com/actualbudget/actual/commit/e9334eda1c2d5c73f1198d414f5399862c9c0e25) Fix cash flow graph in overview - [`1f2f202`](https://github.com/actualbudget/actual/commit/1f2f202b769ccd783f97181cedaea23bbb6e89fe) Use Inter for chart labels - [`1f8f910`](https://github.com/actualbudget/actual/commit/1f8f910d3f9c3c01f66c589af1b8275d08a8e3bc) Fix warning on CashFlowGraph ### 📊 Changes **6 files changed** (+644 additions, -147 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/package.json` (+1 -1) 📝 `packages/desktop-client/src/components/reports/Overview.js` (+2 -2) 📝 `packages/desktop-client/src/components/reports/chart-theme.js` (+39 -22) 📝 `packages/desktop-client/src/components/reports/graphs/CashFlowGraph.js` (+1 -1) 📝 `packages/desktop-client/src/components/reports/graphs/NetWorthGraph.js` (+11 -2) 📝 `yarn.lock` (+590 -119) </details> ### 📄 Description This addresses some warnings caused by the old Victory version using deprecated React APIs. Everything is mostly the same, except that the font is now always Inter, and the bars on the cash flow graph are slightly wider in the 6mo, 12mo, and “all time” views: (before/after) <img width="1222" alt="Screenshot_2023-01-18 13 07 43" src="https://user-images.githubusercontent.com/25517624/213260323-045abf54-8a48-48a2-8fad-c1f159907f46.png"> <img width="1223" alt="Screenshot_2023-01-18 13 07 52" src="https://user-images.githubusercontent.com/25517624/213260330-562948ab-8459-408c-affb-310fa3858f0e.png"> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:37:27 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#3166