github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-10 20:23:07 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #479] [MERGED] Fix a bunch of warnings/errors #3165

New Issue
Closed
opened 2026-02-28 20:37:26 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:37:26 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/479
Author: @j-f1
Created: 1/18/2023
Status: ✅ Merged
Merged: 1/18/2023
Merged by: @j-f1

Base: master ← Head: warnings

📝 Commits (10+)

  • 2918faf Remove invalid ref={} prop
  • f5ad138 Fix height being less than 0
  • 2e056d4 Improve history.push override
  • b60b86c Filters: add missing key prop
  • 648a652 DateSelect: don’t pass null to an input
  • 2a0db4b Filters: add missing key prop
  • d1aa897 EditRule: fix key props
  • 2c28421 ScheduleDetails: Fix for prop
  • d890649 usePayees: default payees to empty array instead of null
  • 57a8cb0 safeNumber: better error if value is not a number

📊 Changes

10 files changed (+42 additions, -17 deletions)

View changed files

📝 packages/desktop-client/src/components/FinancesApp.js (+6 -1)
📝 packages/desktop-client/src/components/Titlebar.js (+2 -2)
📝 packages/desktop-client/src/components/accounts/Filters.js (+4 -0)
📝 packages/desktop-client/src/components/modals/EditRule.js (+15 -5)
📝 packages/desktop-client/src/components/reports/graphs/NetWorthGraph.js (+1 -1)
📝 packages/desktop-client/src/components/schedules/EditSchedule.js (+8 -3)
📝 packages/loot-core/src/client/data-hooks/payees.js (+1 -1)
📝 packages/loot-core/src/shared/util.js (+3 -1)
📝 packages/loot-design/src/components/DateSelect.js (+2 -2)
📝 packages/loot-design/src/components/sidebar.js (+0 -1)

📄 Description

Most of the remaining errors are due to using deprecated APIs via lively, but those should be fixed by #438.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/479 **Author:** [@j-f1](https://github.com/j-f1) **Created:** 1/18/2023 **Status:** ✅ Merged **Merged:** 1/18/2023 **Merged by:** [@j-f1](https://github.com/j-f1) **Base:** `master` ← **Head:** `warnings` --- ### 📝 Commits (10+) - [`2918faf`](https://github.com/actualbudget/actual/commit/2918faf718022ecb6b99438b08b69f18a7de3df6) Remove invalid ref={} prop - [`f5ad138`](https://github.com/actualbudget/actual/commit/f5ad1382ebc74696483f91e3ce2f1f04c1f6747b) Fix <rect> height being less than 0 - [`2e056d4`](https://github.com/actualbudget/actual/commit/2e056d426f32abd7e136c66fc3d924f4228c11d9) Improve history.push override - [`b60b86c`](https://github.com/actualbudget/actual/commit/b60b86cf810be1fb0bd871a4b113a312b7982e0c) Filters: add missing key prop - [`648a652`](https://github.com/actualbudget/actual/commit/648a6522b1827a43b117c81f460656b495461dea) DateSelect: don’t pass `null` to an input - [`2a0db4b`](https://github.com/actualbudget/actual/commit/2a0db4b6e2953668ace79364a7d272afb18740f8) Filters: add missing key prop - [`d1aa897`](https://github.com/actualbudget/actual/commit/d1aa897f92acb854d2a7cbc344ac92e93ab6515d) EditRule: fix key props - [`2c28421`](https://github.com/actualbudget/actual/commit/2c28421d4ad672b38ac05b052d54a85bb9d25c43) ScheduleDetails: Fix `for` prop - [`d890649`](https://github.com/actualbudget/actual/commit/d890649ddcdf3a3590b4e963fe929adf20a39284) usePayees: default `payees` to empty array instead of null - [`57a8cb0`](https://github.com/actualbudget/actual/commit/57a8cb0ba945d66caec7265563de71a118be2bd7) safeNumber: better error if `value` is not a number ### 📊 Changes **10 files changed** (+42 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/FinancesApp.js` (+6 -1) 📝 `packages/desktop-client/src/components/Titlebar.js` (+2 -2) 📝 `packages/desktop-client/src/components/accounts/Filters.js` (+4 -0) 📝 `packages/desktop-client/src/components/modals/EditRule.js` (+15 -5) 📝 `packages/desktop-client/src/components/reports/graphs/NetWorthGraph.js` (+1 -1) 📝 `packages/desktop-client/src/components/schedules/EditSchedule.js` (+8 -3) 📝 `packages/loot-core/src/client/data-hooks/payees.js` (+1 -1) 📝 `packages/loot-core/src/shared/util.js` (+3 -1) 📝 `packages/loot-design/src/components/DateSelect.js` (+2 -2) 📝 `packages/loot-design/src/components/sidebar.js` (+0 -1) </details> ### 📄 Description Most of the remaining errors are due to using deprecated APIs via lively, but those should be fixed by #438. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:37:26 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#3165
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?