github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-11-12 03:42:19 -06:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[PR #4930] [MERGED] ⚙️ Moving TransactionsTable and TransactionList over to Typescript #31591

New Issue
Closed
opened 2026-04-18 07:48:54 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-18 07:48:54 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/4930
Author: @alecbakholdin
Created: 5/3/2025
Status: ✅ Merged
Merged: 5/16/2025
Merged by: @alecbakholdin

Base: master ← Head: transactionsns-table-ts

📝 Commits (10+)

  • f9a81ef moved over some util functions
  • b53de3c moved over TransactionHeader
  • d004700 Added the bulk of Transaction typing data
  • e15a1aa moved PayeeCell into its own file
  • 548542d moved StatusCell over
  • 21676df added NotesCell file
  • 9dc2320 Moved over NewTransaction
  • 4f67625 converted TransactionsTable
  • 91292cc Converted TransactionList to use new typed TransactionsTable
  • 6a63d7c Converted consumers of TransactionList to use TransactionList

📊 Changes

17 files changed (+1314 additions, -808 deletions)

View changed files

📝 packages/desktop-client/src/components/accounts/Account.tsx (+6 -5)
📝 packages/desktop-client/src/components/reports/reports/Calendar.tsx (+12 -12)
📝 packages/desktop-client/src/components/schedules/StatusBadge.tsx (+14 -7)
📝 packages/desktop-client/src/components/table.tsx (+19 -17)
📝 packages/desktop-client/src/components/transactions/SelectedTransactionsButton.tsx (+1 -1)
📝 packages/desktop-client/src/components/transactions/TransactionList.tsx (+89 -25)
📝 packages/desktop-client/src/components/transactions/TransactionMenu.tsx (+4 -1)
📝 packages/desktop-client/src/components/transactions/TransactionsTable.test.tsx (+5 -4)
📝 packages/desktop-client/src/components/transactions/TransactionsTable.tsx (+977 -712)
➕ packages/desktop-client/src/components/transactions/table/utils.ts (+140 -0)
📝 packages/desktop-client/src/hooks/useProperFocus.tsx (+1 -1)
📝 packages/desktop-client/src/hooks/useSplitsExpanded.tsx (+5 -1)
📝 packages/desktop-client/src/queries/queriesSlice.ts (+14 -12)
📝 packages/loot-core/src/shared/arithmetic.ts (+2 -2)
📝 packages/loot-core/src/shared/transactions.ts (+15 -7)
📝 packages/loot-core/src/shared/util.ts (+4 -1)
➕ upcoming-release-notes/4930.md (+6 -0)

📄 Description

I know this PR is very very large; given how interconnected the TransactionsTable is, I didn't feel a great path in moving things over one PR at a time. I tried to separate as much as I could into more readable commits but I don't think it turned out very well.

I still have to fix tests

There are a bunch of TODOs I hope to nail down at some point, maybe not part of this PR

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/4930 **Author:** [@alecbakholdin](https://github.com/alecbakholdin) **Created:** 5/3/2025 **Status:** ✅ Merged **Merged:** 5/16/2025 **Merged by:** [@alecbakholdin](https://github.com/alecbakholdin) **Base:** `master` ← **Head:** `transactionsns-table-ts` --- ### 📝 Commits (10+) - [`f9a81ef`](https://github.com/actualbudget/actual/commit/f9a81ef667d14d2c2c6f448b3b5e6ecabfae3a59) moved over some util functions - [`b53de3c`](https://github.com/actualbudget/actual/commit/b53de3c2c1f2bdc4ebd52f600020fc481f13e305) moved over TransactionHeader - [`d004700`](https://github.com/actualbudget/actual/commit/d0047008bf98397704a6ccd245e43fac3f462bb8) Added the bulk of Transaction typing data - [`e15a1aa`](https://github.com/actualbudget/actual/commit/e15a1aa4d8e2c6badca5b296d569e91bcd369439) moved PayeeCell into its own file - [`548542d`](https://github.com/actualbudget/actual/commit/548542d8a3168ca64a9b0c6aa28b94091af0bc4d) moved StatusCell over - [`21676df`](https://github.com/actualbudget/actual/commit/21676df3017d058595bc9bd031efc549130f2951) added NotesCell file - [`9dc2320`](https://github.com/actualbudget/actual/commit/9dc23207ea8afbff52b10fbc2bee3f656dd951e8) Moved over NewTransaction - [`4f67625`](https://github.com/actualbudget/actual/commit/4f6762591d34377c8adf1adec8569412b51e069c) converted TransactionsTable - [`91292cc`](https://github.com/actualbudget/actual/commit/91292cc1d850255082e6e4848158dd318aad365b) Converted TransactionList to use new typed TransactionsTable - [`6a63d7c`](https://github.com/actualbudget/actual/commit/6a63d7c715cab02257418b15d4f5f9058b5f8e00) Converted consumers of TransactionList to use TransactionList ### 📊 Changes **17 files changed** (+1314 additions, -808 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/accounts/Account.tsx` (+6 -5) 📝 `packages/desktop-client/src/components/reports/reports/Calendar.tsx` (+12 -12) 📝 `packages/desktop-client/src/components/schedules/StatusBadge.tsx` (+14 -7) 📝 `packages/desktop-client/src/components/table.tsx` (+19 -17) 📝 `packages/desktop-client/src/components/transactions/SelectedTransactionsButton.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/transactions/TransactionList.tsx` (+89 -25) 📝 `packages/desktop-client/src/components/transactions/TransactionMenu.tsx` (+4 -1) 📝 `packages/desktop-client/src/components/transactions/TransactionsTable.test.tsx` (+5 -4) 📝 `packages/desktop-client/src/components/transactions/TransactionsTable.tsx` (+977 -712) ➕ `packages/desktop-client/src/components/transactions/table/utils.ts` (+140 -0) 📝 `packages/desktop-client/src/hooks/useProperFocus.tsx` (+1 -1) 📝 `packages/desktop-client/src/hooks/useSplitsExpanded.tsx` (+5 -1) 📝 `packages/desktop-client/src/queries/queriesSlice.ts` (+14 -12) 📝 `packages/loot-core/src/shared/arithmetic.ts` (+2 -2) 📝 `packages/loot-core/src/shared/transactions.ts` (+15 -7) 📝 `packages/loot-core/src/shared/util.ts` (+4 -1) ➕ `upcoming-release-notes/4930.md` (+6 -0) </details> ### 📄 Description I know this PR is very very large; given how interconnected the TransactionsTable is, I didn't feel a great path in moving things over one PR at a time. I tried to separate as much as I could into more readable commits but I don't think it turned out very well. ~I still have to fix tests~ There are a bunch of TODOs I hope to nail down at some point, maybe not part of this PR --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-18 07:48:54 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#31591