github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 20:15:33 -05:00
Code Issues 1.5k Packages Projects Releases 55 Wiki Activity

[PR #4824] [MERGED] Slow improvements to Account.tsx (1/many) #31528

New Issue
Closed
opened 2026-04-18 07:45:16 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-18 07:45:16 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/4824
Author: @jfdoming
Created: 4/16/2025
Status: ✅ Merged
Merged: 4/17/2025
Merged by: @jfdoming

Base: master ← Head: jfdoming/mini-account-refactor

📝 Commits (3)

  • e8df6d8 Move Account EmptyMessage to a separate file
  • 8d2e144 Move a tiny bit of state out of Account.tsx
  • 0fa2927 Add release notes

📊 Changes

4 files changed (+76 additions, -79 deletions)

View changed files

📝 packages/desktop-client/src/components/accounts/Account.tsx (+3 -65)
➕ packages/desktop-client/src/components/accounts/AccountEmptyMessage.tsx (+57 -0)
📝 packages/desktop-client/src/components/accounts/Header.tsx (+10 -14)
➕ upcoming-release-notes/4824.md (+6 -0)

📄 Description

Account.tsx is frustratingly large and hard to grok. It would be really good to split it out into smaller components with clearer boundaries for state, and eventually move to functional components. For now, this PR addresses two low-hanging fruit within the file—I hope to open more PRs like this in the future, but no promises.

Suggest reviewing by commit as the changes are isolated.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/4824 **Author:** [@jfdoming](https://github.com/jfdoming) **Created:** 4/16/2025 **Status:** ✅ Merged **Merged:** 4/17/2025 **Merged by:** [@jfdoming](https://github.com/jfdoming) **Base:** `master` ← **Head:** `jfdoming/mini-account-refactor` --- ### 📝 Commits (3) - [`e8df6d8`](https://github.com/actualbudget/actual/commit/e8df6d8c7c1ff8c10c172ff323a2f91a6da7b6cc) Move Account EmptyMessage to a separate file - [`8d2e144`](https://github.com/actualbudget/actual/commit/8d2e144e703f053d02d14e0ec43fd7d50059091b) Move a tiny bit of state out of Account.tsx - [`0fa2927`](https://github.com/actualbudget/actual/commit/0fa2927eeb5b36e24aaef1751ee14938d557ef12) Add release notes ### 📊 Changes **4 files changed** (+76 additions, -79 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/accounts/Account.tsx` (+3 -65) ➕ `packages/desktop-client/src/components/accounts/AccountEmptyMessage.tsx` (+57 -0) 📝 `packages/desktop-client/src/components/accounts/Header.tsx` (+10 -14) ➕ `upcoming-release-notes/4824.md` (+6 -0) </details> ### 📄 Description `Account.tsx` is frustratingly large and hard to grok. It would be really good to split it out into smaller components with clearer boundaries for state, and eventually move to functional components. For now, this PR addresses two low-hanging fruit within the file—I hope to open more PRs like this in the future, but no promises. Suggest reviewing by commit as the changes are isolated. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-18 07:45:16 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#31528
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?