github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 19:52:56 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #434] [MERGED] Split the Settings component into multiple files #3132

New Issue
Closed
opened 2026-02-28 20:36:55 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:36:55 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/434
Author: @j-f1
Created: 1/5/2023
Status: ✅ Merged
Merged: 1/6/2023
Merged by: @trevdor

Base: trevdor-responsive ← Head: reorganize-settings-code

📝 Commits (6)

  • 00dd82e Split the Settings component into multiple files
  • a078af9 Also add the bottom margin to the “Show advanced settings” link
  • 3762b68 Fix build issues
  • 3490a96 Fix mobile error
  • b1191bd Export → ExportBudget
  • de3108d Move mobile close budget/budget name to a new section

📊 Changes

9 files changed (+463 additions, -413 deletions)

View changed files

📝 packages/desktop-client/src/components/FinancesApp.js (+1 -1)
➖ packages/desktop-client/src/components/Settings.js (+0 -412)
➕ packages/desktop-client/src/components/settings/Encryption.js (+49 -0)
➕ packages/desktop-client/src/components/settings/Export.js (+30 -0)
➕ packages/desktop-client/src/components/settings/Format.js (+65 -0)
➕ packages/desktop-client/src/components/settings/Global.js (+75 -0)
➕ packages/desktop-client/src/components/settings/Reset.js (+61 -0)
➕ packages/desktop-client/src/components/settings/UI.js (+70 -0)
➕ packages/desktop-client/src/components/settings/index.js (+112 -0)

📄 Description

This makes the code easier to look at, and simpler to add to (since each block is now a separate component, you only have to look at the parts that are relevant to your changes rather than reading through the whole thing). Should have minimal to no visual differences.

Also fixes https://github.com/actualbudget/actual/discussions/433#discussioncomment-4603917 by adding bottom margin to the “Show advanced settings” link. This change also affects short desktop viewports.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/434 **Author:** [@j-f1](https://github.com/j-f1) **Created:** 1/5/2023 **Status:** ✅ Merged **Merged:** 1/6/2023 **Merged by:** [@trevdor](https://github.com/trevdor) **Base:** `trevdor-responsive` ← **Head:** `reorganize-settings-code` --- ### 📝 Commits (6) - [`00dd82e`](https://github.com/actualbudget/actual/commit/00dd82eebb73d79a0baa47e35e3ec6abdda6425b) Split the Settings component into multiple files - [`a078af9`](https://github.com/actualbudget/actual/commit/a078af970d8622dd6200b4ebc8a8e93dba553731) Also add the bottom margin to the “Show advanced settings” link - [`3762b68`](https://github.com/actualbudget/actual/commit/3762b6820fa7d0f524631f63095b741d8207e226) Fix build issues - [`3490a96`](https://github.com/actualbudget/actual/commit/3490a96e7dc0a3e4be7a8408ba418130f7b5977a) Fix mobile error - [`b1191bd`](https://github.com/actualbudget/actual/commit/b1191bd9bdda47b86c6ef1a10b4897ed5b53099e) Export → ExportBudget - [`de3108d`](https://github.com/actualbudget/actual/commit/de3108d80213f7b84ded00c0e4e71e85c11fb11c) Move mobile close budget/budget name to a new section ### 📊 Changes **9 files changed** (+463 additions, -413 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/FinancesApp.js` (+1 -1) ➖ `packages/desktop-client/src/components/Settings.js` (+0 -412) ➕ `packages/desktop-client/src/components/settings/Encryption.js` (+49 -0) ➕ `packages/desktop-client/src/components/settings/Export.js` (+30 -0) ➕ `packages/desktop-client/src/components/settings/Format.js` (+65 -0) ➕ `packages/desktop-client/src/components/settings/Global.js` (+75 -0) ➕ `packages/desktop-client/src/components/settings/Reset.js` (+61 -0) ➕ `packages/desktop-client/src/components/settings/UI.js` (+70 -0) ➕ `packages/desktop-client/src/components/settings/index.js` (+112 -0) </details> ### 📄 Description This makes the code easier to look at, and simpler to add to (since each block is now a separate component, you only have to look at the parts that are relevant to your changes rather than reading through the whole thing). Should have minimal to no visual differences. Also fixes https://github.com/actualbudget/actual/discussions/433#discussioncomment-4603917 by adding bottom margin to the “Show advanced settings” link. This change also affects short desktop viewports. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:36:55 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#3132
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?